David Heinemeier Hansson
edcaa2e5f7
More eager fixes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 18:21:20 +00:00
David Heinemeier Hansson
f8783abf0c
Made eager loading work even more
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 17:50:11 +00:00
David Heinemeier Hansson
46f2b03eac
Fixed .id => .object_id in TMail
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 16:26:21 +00:00
David Heinemeier Hansson
d3a64c04ec
Fixed javascript_include_tag to output type instead of language and conform to XHTML #1018 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 16:23:56 +00:00
David Heinemeier Hansson
efb55d1cf5
Allow order, conditions, and joins in finds that include associations
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 12:06:23 +00:00
David Heinemeier Hansson
4f6c943b05
Only include associations when the relevant rows have content
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 12:04:57 +00:00
David Heinemeier Hansson
430ca4d04f
Added tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 11:19:14 +00:00
David Heinemeier Hansson
abc895b828
Added new Base.find API and deprecated find_all, find_first. Added preliminary support for eager loading of associations
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 10:52:05 +00:00
Leon Breedt
17e5035bc5
use #rescue_action in WS scaffolding so that exceptions in API methods give a standard Rails
...
error page on failure
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1076 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 05:23:30 +00:00
Leon Breedt
e5fdff8f46
remove finished tasks
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 00:48:32 +00:00
Leon Breedt
fcfe3febd3
allow selecting the protocol to use when invoking the
...
scaffolded method. fix bug in walking delegated container
services.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 00:12:11 +00:00
Leon Breedt
353497458b
filter out embedded nil values for XML-RPC
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1073 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 22:05:16 +00:00
Leon Breedt
aaea48fe98
* collapse 'ws' back into protocols, it just added complexity and indirection, and was hard to extend.
...
* extract casting into seperate support file
* ensure casting always does the right thing for return values, should fix interoperability issues with Ecto and possibly other XML-RPC clients
* add functional unit tests for scaffolding
* represent signature items with classes instead of symbols/Class objects, much more flexible
* tweak logging to always show casted versions of parameters and return values, if possible.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1072 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 21:03:36 +00:00
David Heinemeier Hansson
aa09c770e9
Added NumberHelper for common string representations like phone number, currency, and percentage #1015 [DeLynn]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1071 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 15:14:57 +00:00
David Heinemeier Hansson
91834e0c3f
Fixed that benchmarking times for rendering included db runtimes #987 [skaes@web.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:31:58 +00:00
David Heinemeier Hansson
7c8d2f28e1
Removed broken attempt to DRY module ClassMethod #970
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:29:43 +00:00
David Heinemeier Hansson
c788bcb416
Automatically extend the class which gets a module included with the ClassMethods module if it exists #970 [Lucas Carlson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1068 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:14:19 +00:00
David Heinemeier Hansson
3532455404
Added pagination for scaffolding (10 items per page) #964 [mortonda@dgrmm.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1067 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:11:17 +00:00
David Heinemeier Hansson
5b36c9275d
Fixed boolean queries for t/f fields in PostgreSQL #995 [dave@cherryville.org]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:58:43 +00:00
David Heinemeier Hansson
ce96c5b30b
Added assert_no_cookie and fixed assert_cookie_equal to deal with non-existing cookies #979 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:54:25 +00:00
David Heinemeier Hansson
1ba1779754
Added that model.items.delete(child) will delete the child, not just set the foreign key to nil, if the child is dependent on the model #978 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:52:51 +00:00
David Heinemeier Hansson
c6cc707854
Fixed auto-stamping of dates (created_on/updated_on) for PostgreSQL #985 [dave@cherryville.org]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1063 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:42:21 +00:00
David Heinemeier Hansson
f84044a83f
decrease reliance on instantiated fixtures #980 [Jeremy Kemper]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:36:32 +00:00
David Heinemeier Hansson
5d42774b62
Fixed :overwrite_param so it doesn't delete but reject elements from @request.parameters #982 [raphinou@yahoo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1061 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:35:04 +00:00
David Heinemeier Hansson
00121b2ca2
Added :method option to verify for ensuring that either GET, POST, etc is allowed #984 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:33:30 +00:00
David Heinemeier Hansson
aec31cd09f
Fixed Base.silence/benchmark to only log if a logger has been configured #986 [skaes@web.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:31:26 +00:00
David Heinemeier Hansson
06a6133fff
Added a join parameter as the third argument to Base.find_first and as the second to Base.count #426 , #988 [skaes@web.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:29:54 +00:00
David Heinemeier Hansson
0ca544d7b3
Fixed problem with classes being required twice. Object#const_missing now uses require_dependency to load files. It used to use require_or_load which would cause models to be loaded twice, which was not good for validations and other class methods #971 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:24:39 +00:00
David Heinemeier Hansson
f7c61b629e
Added options to set cc, bcc, subject, and body for UrlHelper#mail_to #966 [DeLynn]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1056 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:16:57 +00:00
David Heinemeier Hansson
7d09b8d723
Fixed include_blank for select_hour/minute/second #527 [edward@debian.org]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 07:54:01 +00:00
David Heinemeier Hansson
52e5d748bc
Made sure all MySQL tables are created as InnoDB
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 07:46:41 +00:00
David Heinemeier Hansson
8d488264b5
Added install.rbs for all frameworks and made all of them generic enough not to require maintenance #1013 , #1012
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1053 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 07:29:08 +00:00
David Heinemeier Hansson
998ab50974
Improved the message display on the exception handler pages #963 [Johan Sorensen]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1048 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 14:46:11 +00:00
David Heinemeier Hansson
e130b9e017
Added a join parameter as the third argument to Base.find_first #426 [skaes@web.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1047 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 14:35:14 +00:00
David Heinemeier Hansson
8499c24770
Added Effect.Puff and Effect.Appear #990 , #996
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1046 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 11:53:06 +00:00
David Heinemeier Hansson
93e361e58a
Fixed that on very rare occasions, webrick would raise a NoMethodError: private method 'split' called for nil #1001 [Flurin Egger]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 11:46:50 +00:00
Leon Breedt
0de97c81db
display the amount of time taken to invoke a scaffolding request
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1044 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 10:47:01 +00:00
Leon Breedt
0f198eb58e
remove ActiveRecordSoapMarshallable, can't reproduce the problem it was intended to fix.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1043 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 09:12:10 +00:00
David Heinemeier Hansson
cfef86c645
Fixed bug in Base#hash method that would treat records with the same string-based id as different [Dave Thomas]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-30 14:25:29 +00:00
David Heinemeier Hansson
ea3016f5d9
Renamed DateHelper#distance_of_time_in_words_to_now to DateHelper#time_ago_in_words (old method name is still available as a deprecated alias)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1038 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-30 13:06:19 +00:00
Leon Breedt
b94bd32f31
first pass of web service scaffolding. add ability to quickly generate an
...
action pack request for a protocol, add missing log_error when we fail to parse
protocol messages. add RDoc for scaffolding and functional testing.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1037 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-29 12:31:39 +00:00
David Heinemeier Hansson
715715aed4
Dont load the target before the proxy has had a chance to answer the respond_to? -- this would cause an .empty? query to trigger loading the entire collection if the proxy had already been initialized
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1036 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-29 12:31:05 +00:00
Leon Breedt
37270359ac
remove wrongheaded uses of "rescue nil" if it will mask a useful exception. also include
...
the whole backtrace in the 500 error response body if exception reporting is turned on (the default).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1035 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-29 09:04:31 +00:00
David Heinemeier Hansson
c73a414a9a
Fixed references to element
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-28 23:57:43 +00:00
David Heinemeier Hansson
ce2fe88d53
Added Effect.Scale for smoothly scaling images or text up and down #972 [thomas@fesch.at] Added Effect.Squish for scaling down an element and making it disappear at the end #972 [thomas@fesch.at]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-28 23:32:24 +00:00
David Heinemeier Hansson
b0c0c9c2ef
Added Effect.Fade which smoothly turns opacity from 100 to 0 and then hides the element #960 [thomas@fesch.at]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1032 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-28 10:22:44 +00:00
Leon Breedt
b14e5d8334
don't hide exceptions when we fail to parse XML-RPC messages.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-28 06:55:30 +00:00
Leon Breedt
594063f23c
generalize casting code to be used by both SOAP and XML-RPC (previously only XML-RPC). switch
...
to better model for API methods, and improve the ability to generate protocol requests/response,
will be required by upcoming scaffolding.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1030 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-28 03:20:13 +00:00
David Heinemeier Hansson
439a216dcb
Fixed problem with page caching #958 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1029 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-27 21:52:48 +00:00
David Heinemeier Hansson
b7c7b35b07
Fixed the Rakefile #959
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1028 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-27 21:50:54 +00:00