github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-26 23:08:58 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,049 Commits 34 Branches 105 Tags
ee5fe97ac4edbe1d2d6fbf034a485070286cfebb
Commit Graph

2049 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
ee5fe97ac4 Ticket #2282 - fix parsing of timestamps with time zone 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 12:09:13 +00:00
David Heinemeier Hansson
3b108e7d35 Dont redefine RAILS_ENV once set 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 11:11:21 +00:00
David Heinemeier Hansson
562b69829d Not the avenue we want to go down 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 08:13:46 +00:00
David Heinemeier Hansson
735f08aca0 Made the order of framework settings significant so config.action_controller.allow_concurrency can be specified before config.action_controller.fragment_cache_store, which relies on the value of the former 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2423 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 07:20:57 +00:00
David Heinemeier Hansson
d994b41a05 Added method access to OrdredOptions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 07:14:37 +00:00
David Heinemeier Hansson
28329ec8f8 Include OrderedOptions by default 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 07:07:44 +00:00
David Heinemeier Hansson
ab2a24de9d Added test for looping in order 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 07:02:28 +00:00
David Heinemeier Hansson
9f146ea0ac Added OrderedOptions array/hash for use with initializer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 06:51:42 +00:00
Jeremy Kemper
3f1aad8ac9 No need to string.to_s right after checking that string.is_a?(String) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 04:34:07 +00:00
Jeremy Kemper
e828657973 Move transaction thread-safety test to transactions_test. Check that simultaneous transactions don't step on each others' toes. Check that simultaneous transactions don't give dirty reads (read-committed txn isolation or greater.) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 03:39:15 +00:00
Jeremy Kemper
4ce9b4c557 Use transactional fixtures by default for AR tests. Set ENV['AR_NO_TX_FIXTURES'] to yes to disable. Tidy up abstract_unit. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 01:00:04 +00:00
Jeremy Kemper
093a87d1a3 Require topic model rather than assume another test has already. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 00:58:26 +00:00
Jeremy Kemper
110360f858 Disable transactional fixtures for ar_schema_test and schema_test_postgresql 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2414 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 00:57:27 +00:00
David Heinemeier Hansson
854048a2ac Dont bitch over resetting const 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2413 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 12:37:44 +00:00
David Heinemeier Hansson
d219d54930 Clean up the act of commands 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 12:33:48 +00:00
David Heinemeier Hansson
0a0ac86845 Removed all the scripts in script/* and replaced it with one generic portal: script/run 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2411 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 12:18:51 +00:00
David Heinemeier Hansson
070d218c47 Going to pull all commands into Rails 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 11:49:56 +00:00
Nicholas Seckar
6f38041133 Fix broken testcase for transactions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 11:16:51 +00:00
David Heinemeier Hansson
438db964ad Testing should also use a default REQUEST_METHOD 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 08:43:17 +00:00
Jeremy Kemper
67d1e0cd3d Clean up and extend test coverage for validates_numericality_of 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 02:35:41 +00:00
David Heinemeier Hansson
ba91f9feaf Dont log size of request, doesnt work well with procs, not that interesting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 20:03:31 +00:00
David Heinemeier Hansson
00e085f5a5 Solved the hanging issue.. USR2 is now the preferred way of restarting FCGIs! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 19:39:12 +00:00
David Heinemeier Hansson
8e4f27a50a Solved the hanging issue.. USR2 is now the preferred way of restarting FCGIs! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 19:31:41 +00:00
Nicholas Seckar
fc83920383 Fix transactions so that calling return while inside a transaction will not leave an open transaction on the connection. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 18:53:22 +00:00
Marcel Molina
0d07152aab Make schema definition column lookups agnostic w/r/t/ whether a key or symbol is passed. Fixes failing test in [2396]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 18:07:18 +00:00
Marcel Molina
f43d97a860 Add failing test that shows that AR::Migration.remove_column fails silently with SQLite when passed arguments as symbols. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2396 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 17:50:28 +00:00
Thomas Fuchs
4d6ad9c48b Updated rdoc for javascript_include_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 10:55:57 +00:00
Jeremy Kemper
db8f727229 Ticket #2156 - Use foreign_key inflection uniformly 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 09:14:33 +00:00
David Heinemeier Hansson
981763e53e My life for white space 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2393 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 09:06:34 +00:00
David Heinemeier Hansson
ac8f76b521 Dont log it twice 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2392 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:55:04 +00:00
David Heinemeier Hansson
d87618d20d Log request method and response size / status code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2391 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:43:17 +00:00
David Heinemeier Hansson
b7faeb20e9 Added in-process restarting on USR2 -- still missing a good way to free up the socket, so not a complete solution yet. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2390 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:38:26 +00:00
Jeremy Kemper
5d19fd7841 Unit tests and fixtures for multipart posts. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2389 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:19:26 +00:00
Thomas Fuchs
9084f5b6e8 Forgot about CHANGELOGs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:26:06 +00:00
Thomas Fuchs
516dc2c0f1 Update script.aculo.us to 1.5_rc2, and Prototype to 1.4.0_pre7 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2386 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:20:47 +00:00
Jeremy Kemper
dd21e9ae39 r3657@asus: jeremy | 2005-09-28 00:32:33 -0700 
Also test that client.firm_id.nil? after firm.clients.clear when clients is not :dependent


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2385 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 04:00:59 +00:00
Jeremy Kemper
efaf2af07c r3653@asus: jeremy | 2005-09-28 00:23:49 -0700 
Ticket 2221 - model.association.clear should destroy associated objects if :dependent => true instead of nullifying their foreign keys


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 03:52:57 +00:00
Marcel Molina
1e87d6e887 Added test coverage for stylesheet_path to show that it works as requested in #1471. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2383 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 02:08:58 +00:00
Marcel Molina
93db2f3895 Include additional ticket number that is closed by [2380]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 00:21:01 +00:00
Scott Barron
83b390bcfc Returning false in before_destroy should cancel action. Closes #1829. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2381 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 00:09:50 +00:00
Marcel Molina
8e78e9335b Make table_name and controller_name in generators honor AR::Base.pluralize_table_names. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 00:06:39 +00:00
Nicholas Seckar
0b1abc3360 Undo condition change made in [2345] to prevent normal parameters arriving as StringIO. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:39:56 +00:00
Jeremy Kemper
0bd11857ef Ticket 2256 - Recognize PostgreSQL NOW() default as equivalent to CURRENT_TIMESTAMP/CURRENT_DATE 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:37:57 +00:00
Scott Barron
e1024e50cf #2261 was supposed to have been closed as wontfix, not sure why it wasn't, 
sorry.  We discussed this on IRC and reached the conclusion that it was
an undesirable addition.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2377 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:31:32 +00:00
Jeremy Kemper
5217b90909 Ticket 2261 - Include lib/tasks/*.rake in rake stats 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2376 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:57:05 +00:00
Jeremy Kemper
17d2732b1c Ticket #2295 - Tolerate consecutive delimiters in query parameters 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:23:37 +00:00
Jeremy Kemper
0c23f06129 Update change log for #2297 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:10:33 +00:00
Jeremy Kemper
ec019d7bc1 Ticket 2297 - rake stats clearly labels functional and unit tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2373 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:09:21 +00:00
Jeremy Kemper
fcd0133f69 Update change log for #2250. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 20:47:34 +00:00
Marcel Molina
b9fa3541b4 Add extensive documentation to the ActiveRecord::AbstractAdapter. #2250 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 20:37:23 +00:00