Commit Graph

1839 Commits

Author SHA1 Message Date
David Heinemeier Hansson
eec24a16c7 Fixed that Active Record would call SHOW FIELDS twice (or more) for the same model when the cached results were available #1947 [sd@notso.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 12:21:36 +00:00
Nicholas Seckar
bf92aacf40 Avoid extending view instance with helper modules each request. Closes #1979
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 12:08:24 +00:00
Nicholas Seckar
689cca132a Performance improvements to CGI methods. Closes #1980
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 11:28:54 +00:00
David Heinemeier Hansson
7b235f0213 Use this.href, not unexisting url
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 13:04:09 +00:00
David Heinemeier Hansson
7e3dc807df Added :post option to UrlHelper#link_to that makes it possible to do POST requests through normal ahref links using Javascript
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 12:56:33 +00:00
Nicholas Seckar
2f66e873b0 Symbolize the keys of overwritten parameters. Really closes #1909.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 08:59:33 +00:00
Nicholas Seckar
3108764367 Fix overwrite params. Closes #1909
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 22:06:11 +00:00
David Heinemeier Hansson
f2a89d7862 Give AR the new benchmark method too
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2143 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 17:47:31 +00:00
David Heinemeier Hansson
f86276b305 Fix fragment benchmark calls and limit timings to 5 decimals
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 17:33:11 +00:00
David Heinemeier Hansson
291c667d66 Only do benchmarking if log level matches and log caching
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 17:07:08 +00:00
David Heinemeier Hansson
5e8e8d6564 Added use_silence parameter to ActiveRecord::Base.benchmark that can be passed false to include all logging statements during the benchmark block. Added ActionController::Base.benchmark and ActionController::Base.silence to allow for easy benchmarking and turning off the log
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 16:48:18 +00:00
David Heinemeier Hansson
50debfa96c Dont encode the default subject for the test cases since they are within the ascii range
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2139 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 11:01:23 +00:00
Jamis Buck
b70e2db64a Make the default stats task extendable by modifying the STATS_DIRECTORIES constant
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-05 15:39:20 +00:00
Jamis Buck
9eef247339 Allow the selected environment to define RAILS_DEFAULT_LOGGER, and have Rails::Initializer use it if it exists.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-05 12:36:40 +00:00
Jamis Buck
bfdb437508 Updated vendor copy of html-scanner to support better xml parsing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-05 09:44:22 +00:00
Jamis Buck
873be1258e Fix vendor require paths to prevent files being required twice
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-05 09:06:55 +00:00
David Heinemeier Hansson
258bacbf82 Added :popup option to UrlHelper#link_to #1996 [gabriel.gironda@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-04 00:33:45 +00:00
David Heinemeier Hansson
9e803e081a Get rid of that silly lock
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-04 00:28:28 +00:00
David Heinemeier Hansson
558707f61a Silence logger initialization
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 23:05:58 +00:00
David Heinemeier Hansson
3f14b1e94e Updated the options_for_select to deal with the fact that Strings now implement :first
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 21:30:54 +00:00
David Heinemeier Hansson
9fdd453257 Fix mocks dir
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 20:21:38 +00:00
David Heinemeier Hansson
a4994d077f Fix the spot looking for migrations
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2122 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 16:24:36 +00:00
David Heinemeier Hansson
6c3be611d4 Fix the spot looking for migrations
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2121 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 16:22:28 +00:00
David Heinemeier Hansson
177934e1d0 Talk about whats missing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 16:04:33 +00:00
David Heinemeier Hansson
29436edb73 Also configure template view path
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2119 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 15:44:19 +00:00
David Heinemeier Hansson
8367316826 Proper clean rakefile
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 15:20:42 +00:00
David Heinemeier Hansson
bc011df210 Moved all the shared tasks from Rakefile into Rails, so that the Rakefile is empty and doesn't require updating. Added Rails::Initializer and Rails::Configuration to abstract all of the common setup out of config/environment.rb (uses config/boot.rb to bootstrap the initializer and paths)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 15:13:06 +00:00
David Heinemeier Hansson
9bbb195c03 You will never sleep again!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 10:33:18 +00:00
David Heinemeier Hansson
51a1af96d4 Added note about how pre-packaged error functionality can be easier to recreate yourself than attempt to overly tailor #1489
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2112 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 07:43:15 +00:00
David Heinemeier Hansson
1448d749f5 Fixed the scaffold generator to fail right away if the database isn't accessible instead of in mid-air #1169 [Chad Fowler]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 07:29:30 +00:00
David Heinemeier Hansson
1e145099a7 Added String#at, String#from, String#to, String#first, String#last in ActiveSupport::CoreExtensions::String::Access to ease access to individual characters and substrings in a string serving basically as human names for range access. Added easy extendability to the inflector through Inflector.inflections (using the Inflector::Inflections singleton class)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 07:11:47 +00:00
Jamis Buck
89550ee7e9 Use chop! instead of chop! for efficiency
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 18:01:26 +00:00
Jamis Buck
62ec1a5373 Drop trailing \000 if present on RAW_POST_DATA (works around bug in Safari Ajax implementation) #918
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 14:40:33 +00:00
Jamis Buck
7a0e1bd56a Make sure the schema_info table is created before querying the current version #1903
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2105 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 14:20:20 +00:00
Jamis Buck
fd9c15e420 Fix observe_field to fall back to event-based observation if frequency <= 0 #1916 [michael@schubert.cx]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 14:06:17 +00:00
Jamis Buck
97adfdaa65 * Allow use of the :with option for submit_to_remote #1936 [jon@instance-design.co.uk]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 13:56:38 +00:00
Jamis Buck
e3d34286e3 Fixtures ignore table name prefix and suffix #1987 [Jakob S]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2101 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 10:51:23 +00:00
Jamis Buck
bf3f920989 Add documentation for index_type argument to add_index method for migrations #2005 [blaine@odeo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 10:07:14 +00:00
Jamis Buck
14b8fa308e Corrected project-local generator location in scripts.rb #2010 [Michael Schuerig]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2099 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 10:04:15 +00:00
Jamis Buck
6c44d35268 AbstractRequest#domain returns nil when host is an ip address #2012 [kevin.clark@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 09:10:31 +00:00
David Heinemeier Hansson
d54aea29fc Fix documentation for mailer generator
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2097 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 08:50:55 +00:00
Jamis Buck
69d662051e Modify read_attribute to allow a symbol argument #2024 [Ken Kunz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 08:31:11 +00:00
Jamis Buck
46c4fd4177 ActionController documentation update #2051 [fbeausoleil@ftml.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:54:29 +00:00
Jamis Buck
e758c2e9db Yield @content_for_ variables to templates #2058 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:51:27 +00:00
Jamis Buck
01af965a3e Make rendering an empty partial collection behave like :nothing => true #2080 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2093 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:43:38 +00:00
Jamis Buck
49c67ea1b7 Don't require the environment just to clear the logs #2093 [Scott Barron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2092 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:36:50 +00:00
Jamis Buck
8373b55055 * Don't add charset to content-type header for a part that contains subparts (for AOL compatibility) #2013 [John Long]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 16:00:08 +00:00
Jamis Buck
a322514871 Preserve underscores when unquoting message bodies #1930
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 14:45:10 +00:00
Jamis Buck
ca410998ab Encode multibyte characters correctly #1894
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 14:26:13 +00:00
Jamis Buck
2fed808ee4 Make Time#last_month work when invoked on the 31st of a month.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-31 10:47:05 +00:00