github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-31 09:18:17 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,190 Commits 34 Branches 105 Tags
ef6921628d4906fcd2945f2f90b050ff5b5ec258
Commit Graph

4190 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jamis Buck
ef6921628d make sure filters in subclasses with :only or :except conditions are treated like skip_filter calls 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 01:54:42 +00:00
Michael Koziarski
81ddeadd49 Replace KCODE checks with String#chars for truncate. Closes #6385 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5300 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 00:31:30 +00:00
Jamis Buck
d73f32ce00 make sure the String::Access methods return strings, and not multibyte Char instances 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5299 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 20:27:46 +00:00
Rick Olson
2c6b6e2866 automatically add primary key to #select_limited_ids_list order by clause for databases that require order columns in the distinct statements (postgresql) [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5292 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 08:52:33 +00:00
Rick Olson
e789b26e65 fix select_limited_ids_list issues in postgresql, retain current behavior in other adapters [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5291 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 08:29:00 +00:00
Rick Olson
ce1d14430f add test for select_limited_ids_list that passes in mysql/sqlite and fails in postgresql 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5290 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 07:46:38 +00:00
Marcel Molina
065908a4c5 Make page caching respect the format of the resource that is being requested even if the current route is the default route so that, e.g. posts.rss is not transformed by url_for to '/' and subsequently cached as '/index.html' when it should be cached as '/posts.rss'. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 23:29:04 +00:00
Michael Koziarski
41c3623524 Use String#chars in TextHelper::excerpt. Closes #6386 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5288 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 21:13:05 +00:00
Michael Koziarski
48cef84150 Make core_ext/string/access.rb multibyte safe. Closes #6388 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 21:03:32 +00:00
Michael Koziarski
cb927c8774 Make String#chars slicing behaviour consistent with String. Closes #6387 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5286 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 21:00:34 +00:00
Rick Olson
7870494673 Restore eager condition interpolation, document it's differences [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 14:02:24 +00:00
Nicholas Seckar
214d236e7d Install named routes into ActionView::Base instead of proxying them to the view via helper_method. Closes #5932. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 04:31:57 +00:00
Jeremy Kemper
1117387376 Compare to 0 rather than call zero? to handle nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 00:29:59 +00:00
Jeremy Kemper
629b8af2b0 Wrap save! in a transaction. Closes #6324. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-10 19:34:25 +00:00
David Heinemeier Hansson
5e08c668d2 Fixed default 404.html and 500.htmls to remove extreme ugliness and added error language fit for humans [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-10 18:18:27 +00:00
Nicholas Seckar
bbcd508d64 Fix typo 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 22:54:53 +00:00
Thomas Fuchs
b0e78c6278 Update to latest Prototype and script.aculo.us trunk versions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5276 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 22:09:08 +00:00
Jeremy Kemper
f65ab3b233 improve example in migrations docs, closes #6370 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 22:05:50 +00:00
Jamis Buck
02dc646d55 Fix relative URL root matching problems 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 19:14:11 +00:00
Jeremy Kemper
2c3ca4c4e6 Don't rollback in teardown unless a transaction was started. Don't start a transaction in create_fixtures if a transaction is started. Closes #6282. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 07:48:27 +00:00
Jeremy Kemper
419226fe11 PostgreSQL: db:test:purge closes open database connections first. Closes #6236. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 06:34:57 +00:00
Jeremy Kemper
eaae0399ad r5540@ks: jeremy | 2006-10-08 23:05:30 -0700 
#5949
 r5541@ks:  jeremy | 2006-10-08 23:07:08 -0700
 Fix filter skipping in controller subclasses.
 r5557@ks:  jeremy | 2006-10-08 23:11:24 -0700
 Update changelog.  Closes #5949, references #6297, references #6299.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 06:11:40 +00:00
Rick Olson
850087f0bd Add #delete support to has_many :through associations. Closes #6049 [Martin Landers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 03:21:52 +00:00
Rick Olson
4e66f5bfe7 learn to clean up after myself 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5266 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 03:13:06 +00:00
Rick Olson
c98b471ca4 Reverted old select_limited_ids_list postgresql fix that caused issues in mysql. Closes #5851 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 03:12:32 +00:00
Rick Olson
8e3bf70bcd Removes the ability for eager loaded conditions to be interpolated, since there is no model instance to use as a context for interpolation. #5553 [turnip@turnipspatch.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:46:57 +00:00
David Heinemeier Hansson
ccd32adeca Fixed test:uncommitted on Windows (backslash issue) (closes #4999) [paul@paulbutcher.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:23:03 +00:00
David Heinemeier Hansson
0d8b8056be Docfix (closes #6234) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:20:43 +00:00
David Heinemeier Hansson
a21e86f023 Fixed migration creation to work with namespaced models, so script/generate model Gallery::Image will use create_table :gallery_images #6327 [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:19:58 +00:00
David Heinemeier Hansson
fe4d5ea786 Fixed rename_table on SQLite tables with indexes defined (closes #5942) [brandon@opensoul.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:14:36 +00:00
David Heinemeier Hansson
fc7fd4c5ce Docfix (closes #6040) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:05:50 +00:00
David Heinemeier Hansson
943be923f0 Added timeout option to SQLite3 configurations to deal more gracefully with SQLite3::BusyException, now the connection can instead retry for x seconds to see if the db clears up before throwing that exception (closes #6126) [wreese@gmail.com] Added default timeout setting of 5 seconds to SQLite3 database.yml configurations [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:02:27 +00:00
David Heinemeier Hansson
8f93516168 Docfix (closes #5143) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:53:51 +00:00
David Heinemeier Hansson
55aab5b8ac Added update_attributes! which uses save! to raise an exception if a validation error prevents saving (closes #6192) [jonathan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:52:24 +00:00
David Heinemeier Hansson
9fd88d7939 Deprecated add_on_boundary_breaking (use validates_length_of instead) (closes #6292) [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:42:09 +00:00
David Heinemeier Hansson
cb0837a2b7 Doc fixes (closes #6325) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:32:11 +00:00
Jeremy Kemper
a307b8c7dc render_text may optionally append to the response body. render_javascript appends by default. This allows you to chain multiple render :update calls by setting @performed_render = false between them (awaiting a better public API). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:26:35 +00:00
Nicholas Seckar
bc85e6ac4c Rename test assertion to prevent shadowing. Closes #6306. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:20:36 +00:00
Jeremy Kemper
5d1edc55a8 one render per test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:14:38 +00:00
David Heinemeier Hansson
a49e7d5c0c Fixed that NumberHelper#number_to_delimiter should respect precision of higher than two digits (closes #6231) [phallstrom] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:59:19 +00:00
David Heinemeier Hansson
f9650a23f0 Fixed that caches_action breaks with file extensions (closes #6257) [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:56:13 +00:00
David Heinemeier Hansson
211ffd3f79 Fixed that FormHelper#radio_button didn't respect an :id being passed in (closes #6266) [evansj] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:53:59 +00:00
David Heinemeier Hansson
8ff92e2435 Added an html_options hash parameter to javascript_tag() and update_page_tag() helpers #6311 [tzaharia] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:50:11 +00:00
David Heinemeier Hansson
ca35e264a4 Also update escaping for prototype rescues [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:45:41 +00:00
David Heinemeier Hansson
31d3048706 Fixed that rescue template path shouldn't be hardcoded, then it's easier to hook in your own (closes #6295) [mnaberez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:40:05 +00:00
David Heinemeier Hansson
4b3e964a1a Fixed escaping of backslashes in JavaScriptHelper#escape_javascript (closes #6302) [sven@c3d2.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:34:43 +00:00
David Heinemeier Hansson
2e766b159f Fixed that some 500 rescues would cause 500's themselves because the response had not yet been generated #6329 [cmselmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:21:47 +00:00
David Heinemeier Hansson
3c6b7a2191 Fixed that assert_select selects the wrong tag by its contents (closes #6332) [jgarber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:20:31 +00:00
David Heinemeier Hansson
717e26dd0e Deprecation cleanup for rescues (closes #6339) [adam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:17:11 +00:00
David Heinemeier Hansson
3ba5e39b54 Docfix (closes #6356) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:15:28 +00:00