github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,667 Commits 34 Branches 105 Tags
f0be2cb19274bb6029f84ca274a72c4d7fbee2d3
Commit Graph

25667 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Prem Sichanugrist
f0be2cb192 Add some note on adding index to HABTM table 2011-10-20 17:15:28 -04:00
Prem Sichanugrist
d64e0955d0 Use new migration style in HABTM join table 
Yes, we're on Rails 3.1 now.
 2011-10-20 17:13:01 -04:00
Pepe Hipolito
0cd93a6e2b Fixed typo. 
Ruby will know to look for this file at => Ruby will know how to look for this file at
 2011-10-20 15:58:51 -04:00
Pepe Hipolito
48e1f8ba4c Fixed typo. 
a long the way => along the way
 2011-10-20 15:37:35 -04:00
Vijay Dev
af1b5c54cf Merge branch 'master' of github.com:lifo/docrails 2011-10-20 23:20:44 +05:30
Aaron Patterson
ee9d9fb5fa Merge pull request #3258 from ileitch/3-1-stable 
Postgres: Do not attempt to deallocate a statement if the connection is no longer active.
 2011-10-20 08:45:22 -07:00
Martin Svalin
274c3fad50 Fixed misleading docs for String#to_formatted_s(:db) 2011-10-20 16:31:23 +02:00
Andrew France
66880cfe41 Correct ActionMailer subject i18n lookup scope. 
The :actionmailer i18n scope part is not used and according to https://github.com/rails/rails/pull/2542 the implementation is correct.
 2011-10-20 12:32:11 +02:00
José Valim
ef3e149db3 Merge pull request #3375 from arunagw/middleware_test_fix 
Adding ActionDispatch::RequestId in middleware test
 2011-10-20 00:35:07 -07:00
Ryan Bigg
ee1223c1ee [engines guide] explanation of overriding views + referencing routes from an engine within an application 2011-10-20 18:30:50 +11:00
Arun Agrawal
5c5d5b3d25 Adding ActionDispatch::RequestId in middleware test 2011-10-20 12:59:27 +05:30
José Valim
00eb67e01f Merge pull request #3374 from marcbowes/master 
Regexp fixup
 2011-10-20 00:11:06 -07:00
Marc Bowes
951a325c99 Remove the unneeded \d when sanitizing X-Request-Id. 2011-10-20 10:00:42 +03:00
Ryan Bigg
13e6f0cea8 [engines guide] some fixes for the author id migration including proof of not copying over other migrations again 2011-10-20 17:32:48 +11:00
Ryan Bigg
3e2d35b050 [engines guide] add missing end for to_s method 2011-10-20 17:10:46 +11:00
José Valim
4e9729df3f Don't use :path in Gemfile for --dev except for Rails. 2011-10-20 00:38:58 +02:00
Ryan Bigg
1cc6105d4d [engines guide] wrap up 'Configuring an Engine' section 2011-10-20 08:48:06 +11:00
Ryan Bigg
8ede74e73a [engines guide] Rather than calling name, require a to_s method to be defined on the 'User' class 2011-10-20 08:48:06 +11:00
Ryan Bigg
9694ca1a3b [engines guide] mention that we cover similar ground to the Getting Started Guide 2011-10-20 08:48:05 +11:00
David Heinemeier Hansson
be27bf17e3 Fix the proper production.rb 2011-10-19 16:24:00 -05:00
David Heinemeier Hansson
1359152345 Encourage use of tagged logging even when using a different logger 2011-10-19 16:17:06 -05:00
Martin Svalin
930dc335d7 Removed mention of deprecated ActiveModel::Errors#on 2011-10-19 23:13:15 +02:00
José Valim
c83d9a11c0 Unify logger and taggedlogging middleware as both address logging concerns. 2011-10-19 22:39:11 +02:00
José Valim
6c126015a6 Ensure TaggegLogging is thread safe. 2011-10-19 22:26:56 +02:00
José Valim
4ef7453694 Load object/blank and make use of presence. 2011-10-19 22:10:43 +02:00
José Valim
f1fecd9b4e Make tests run on 1.8.x, add integration setup. 2011-10-19 22:09:36 +02:00
David Heinemeier Hansson
18dbfcb363 Programatically define the log level methods and use the Logger constants instead (SyslogLogger didnt define them as I expected) 2011-10-19 14:54:00 -05:00
José Valim
533451a5b6 Merge pull request #3369 from martinsvalin/am_errors_added 
New #added? method on ActiveModel::Errors
 2011-10-19 12:52:48 -07:00
David Heinemeier Hansson
ada78066fd Blah, SecureRandom#uuid is not supported in 1.8.7 -- cant wait for Rails 4.0 to drop compatibility with 1.8.x 2011-10-19 14:45:42 -05:00
Martin Svalin
c9ca86c29d New #added? method on ActiveModel::Errors 
The #added? method makes it possible to check if a specific error has been added, using the same parameters as for #add.
 2011-10-19 21:29:20 +02:00
José Valim
1b50207ed3 Require missing string access dependency. 2011-10-19 22:17:54 +03:00
José Valim
ddbb2cae31 Require securerandom as it is the proper dependency. 2011-10-19 22:15:25 +03:00
David Heinemeier Hansson
4a4927f753 Simplify TaggedLogging symbol shortcuts (thanks Jose!) 2011-10-19 13:24:28 -05:00
David Heinemeier Hansson
afde6fdd5e Added X-Request-Id tracking and TaggedLogging to easily log that and other production concerns 2011-10-19 12:59:33 -05:00
Jeremy Kemper
3a746f7c48 Use toplevel Rack::ContentLength 2011-10-19 12:31:06 -05:00
Vijay Dev
89a164ab9b Merge pull request #3362 from avakhov/p-superfluous-assign-cookies 
Remove superfluous assignment in cookies
 2011-10-19 00:28:33 -07:00
Andy Lindeman
044e6ac245 Fixes the defaults for config.cache_classes 2011-10-18 23:45:56 -03:00
Aaron Patterson
c2f3c9bf56 only use now() on pg! 2011-10-18 13:30:01 -07:00
Alexey Vakhov
bed5825f77 Remove superfluous assignment in cookies 2011-10-18 22:57:55 +04:00
Aaron Patterson
6a28c512e3 reset prepared statement when schema changes imapact statement results. fixes #3335 2011-10-18 11:20:13 -07:00
Santiago Pastorino
d44702c830 Use again Rack's ContentLength middleware part 2 2011-10-18 16:14:38 -02:00
Santiago Pastorino
7f184aaf43 Use again Rack's ContentLength middleware 2011-10-18 16:04:15 -02:00
José Valim
71325bb308 Merge pull request #3350 from whilefalse/rake_environment_in_engines 
Added environment rake task to engines
 2011-10-18 10:09:13 -07:00
Aaron Patterson
76af2818a6 use now() for dates in pg 2011-10-18 10:07:40 -07:00
steve
40d1555091 Added test for rake environment in an engine 2011-10-18 17:11:50 +01:00
Steven Anderson
c547e968f5 Added environment rake task to engines 2011-10-18 15:46:39 +01:00
José Valim
5e1b912f3b Merge pull request #3356 from arunagw/bunp_rack 
Bump Rack to 1.3.5
 2011-10-17 23:04:24 -07:00
Arun Agrawal
124bb17638 Bump Rack to 1.3.5 2011-10-18 11:09:59 +05:30
José Valim
7511f9794d Merge pull request #3340 from surfacedamage/exclude_destroy_in_all_blank_check 
Exclude _destroy parameter in :all_blank check (issue #2937)
 2011-10-17 11:15:58 -07:00
Aaron Christy
8510a0bb5a Exclude _destroy parameter in :all_blank check (issue #2937) 2011-10-17 13:29:11 -04:00