Commit Graph

12197 Commits

Author SHA1 Message Date
José Valim
f2d276fefd Ensure no notification is on the queue before running notifications related tests. 2010-01-03 23:39:09 +01:00
José Valim
53c6984944 Add notifications to ActionDispatch::ShowExceptions, this can be used as hooks for plugins like ExceptionNotifier. 2010-01-03 23:33:34 +01:00
José Valim
6fbe9ef2ff Use namespaces in notifications. 2010-01-03 20:39:42 +01:00
José Valim
4796be33a4 Add missing tests to Validators. 2010-01-03 17:14:50 +01:00
José Valim
271e7c803f Move all generators tests to use new test case syntax. 2010-01-03 17:14:50 +01:00
José Valim
441227a10f Create Rails::Generators::TestCase. 2010-01-03 17:14:49 +01:00
José Valim
e88ea3255f Assert for valid application names. [#3556 status:resolved] 2010-01-03 17:14:49 +01:00
José Valim
6716e4bc0c Use regexp in lookups instead of traversing namespaces. This removes the need of special cases. 2010-01-03 17:14:48 +01:00
Pratik Naik
00f3f6dc31 Relation#merge and Relation#except should respect locks 2010-01-03 21:25:19 +05:30
Pratik Naik
3db876cb76 Relation#merge and Relation#except should respect havings 2010-01-03 20:50:04 +05:30
Pratik Naik
af5e1b4cc6 Add Relation#except 2010-01-03 19:43:29 +05:30
Pratik Naik
22bfd8b098 Rename a variable name for consistency 2010-01-03 19:20:40 +05:30
Pratik Naik
8edfa8f82f Move Relation#spawn and Relation#merge to a separate module 2010-01-03 18:57:57 +05:30
Pratik Naik
3eca0ab838 Give preference to the second relation's order when merging 2010-01-03 18:52:30 +05:30
Stefan Penner
d531cbc809 fixed missing or incorrect session data error message 2010-01-02 23:01:06 -08:00
Yehuda Katz
106d8f7688 AppName::Application.root should work 2010-01-02 22:49:40 -08:00
Yehuda Katz
f1cd3a98f3 Doc fix 2010-01-02 22:46:09 -08:00
Mikel Lindsaar
42aa9b87c2 Silence warnings 2010-01-02 22:39:00 -08:00
Mikel Lindsaar
bf6d0e2bc2 Updating to Mail 1.5.0, including default values for all Message#field_name methods, can access field objects by calling Message#[:field_name] 2010-01-02 22:39:00 -08:00
Pratik Naik
4939f95c9b Reapply "Remove optional join_dependency argument as Relation always supplies it" - Now without syntax errors 2010-01-03 11:08:57 +05:30
Jeremy Kemper
7ad7c82caf Skip isolation test tests until they work 2010-01-02 20:29:47 -08:00
Xavier Noria
7a2554d9a3 Let Integer#multiple_of? accept zero as argument
[#2982 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-01-02 20:25:15 -08:00
Jeremy Kemper
8571aa613f Revert "Remove optional join_dependency argument as Relation always supplies it"
This reverts commit 8e57deed8b.
2010-01-02 18:39:36 -08:00
Steve Agalloco
c3d19eb950 app_generator option should be skip_activerecord not no_activerecord
(Thor actually accepts both, the patch was applied to improve readability)

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-01-03 00:47:01 +01:00
Pratik Naik
8e57deed8b Remove optional join_dependency argument as Relation always supplies it 2010-01-03 04:09:36 +05:30
Pratik Naik
47da00e94b Further simplify Relation#references_eager_loaded_tables? 2010-01-03 03:58:34 +05:30
Pratik Naik
e9ebf8b898 Cache Relation#to_sql 2010-01-03 03:56:21 +05:30
Pratik Naik
0d1a2a3c22 Remove unused code from association.rb now that Relation takes care of checking the referenced tables 2010-01-03 03:49:10 +05:30
Pratik Naik
eb7fdb9464 Make Relation#includes behave exactly like the existing :include option 2010-01-03 03:46:08 +05:30
Pratik Naik
6f5f23aaa7 Add Relation#includes to be an equivalent of current finder option :include 2010-01-03 03:24:28 +05:30
Pratik Naik
c51347152a Get rid of Model.construct_finder_arel_with_includes. Use construct_finder_arel instead 2010-01-03 03:08:01 +05:30
Pratik Naik
a9c790e10f Simply methods for checking eager loaded tables references in the query 2010-01-03 03:00:30 +05:30
José Valim
4c5b5024c3 Rails notifications are set through Railtie in each framework. 2010-01-02 22:27:03 +01:00
José Valim
08986ce290 Remove deprecated ActiveModel tests (%d and %s is no longer supported in error messages a couple months already) 2010-01-02 22:27:03 +01:00
José Valim
fd719d7ecf Update vendored Thor. 2010-01-02 22:27:03 +01:00
José Valim
f50bb48e04 Do not enforce human_attribute_name as required API. 2010-01-02 22:27:03 +01:00
Carsten Gehling
bef968d379 I18n label helper [#745 status:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-01-02 22:27:02 +01:00
José Valim
653fa4c10c Add naming to AMo::Lint 2010-01-02 22:27:02 +01:00
José Valim
7cc0a4cfa1 Use activerecord.errors.format as in Rails 2.3.5. 2010-01-02 22:27:02 +01:00
José Valim
5fdd0e80a4 Be sure to convert namespaced names to we have 'Parrots name' instead of 'Parrots.name' in error messages. 2010-01-02 22:27:02 +01:00
José Valim
dcafe995bf Make nested attributes behave like in 2.3.5 and add a sanity test for it with I18n. 2010-01-02 22:27:02 +01:00
Pratik Naik
ac1df91e5e Implement Relation#create and Relation#create! 2010-01-03 00:16:14 +05:30
Pratik Naik
65200d2933 Implement Relation#new 2010-01-03 00:08:59 +05:30
Pratik Naik
32b48bf419 Use arel predicates instead of strings wherever possible when merging relations 2010-01-02 22:43:40 +05:30
Pratik Naik
f1acf1cc74 Give higher preference to second relation's equality predicates when merging 2010-01-02 21:16:16 +05:30
Pratik Naik
3e6e3e90ef Remove the test which was testing a non-existing method, always failing on 1.9 and never even running on 1.8 2010-01-02 16:12:01 +05:30
Pratik Naik
7ff131f740 Make sure not to spalt string arguments 2010-01-02 13:43:50 +05:30
Xavier Noria
abae712213 fixes a couple of wrong requires 2010-01-01 14:28:57 -08:00
Xavier Noria
9ab528df8d nokogiri.rb needs active_support/core_ext/object/blank 2010-01-01 14:28:57 -08:00
Xavier Noria
2d233ebdcf libxml.rb needs active_support/core_ext/object/blank 2010-01-01 14:28:57 -08:00