github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-02 02:04:59 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,962 Commits 34 Branches 105 Tags
f7bb3ddce85dcafe8ae2c52f7b7fbd53b0859732
Commit Graph

1251 Commits

Author SHA1 Message Date
David Heinemeier Hansson
17f7f8a091 Made documentation ready for release (AR) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1733 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 10:14:58 +00:00
David Heinemeier Hansson
977b4be208 Changed logging of SQL statements to use the DEBUG level instead of INFO. Added logging of the request URI in the benchmark statement (makes it easy to grep for slow actions). Changed the default logging level in config/environment.rb to INFO for production (so SQL statements won't be logged) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 17:23:41 +00:00
Jamis Buck
56c3d72aa7 Fix regression from [1631] that caused an attribute to be set to nil if it was assigned false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1709 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 12:38:06 +00:00
David Heinemeier Hansson
0bef168238 Made default changes work in both postgresql and mysql #1612 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1703 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 09:16:23 +00:00
David Heinemeier Hansson
0e92f36d75 Added callbacks on push_with_attributes #1594 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1698 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 07:20:24 +00:00
David Heinemeier Hansson
f1880cac58 Sugared up migrations with even more bling #1609 [Tobias Luekte] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1697 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 07:19:20 +00:00
David Heinemeier Hansson
4160b518a8 Added new Migrations framework for describing schema transformations in a way that can be easily applied across multiple databases #1604 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1672 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 18:51:02 +00:00
David Heinemeier Hansson
a43c227f84 Fixed migration initialization of table 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1655 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 09:20:43 +00:00
David Heinemeier Hansson
4180e57b70 Added callback hooks to association collections #1549 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1653 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 08:43:57 +00:00
David Heinemeier Hansson
55692003d4 Fixed Base.content_columns call for SQL Server adapter #1450 [DeLynn Berry] And a bug with the offset rules 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1647 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 12:34:22 +00:00
David Heinemeier Hansson
aaa5637249 Fixed Base#write_attribute to work with both symbols and strings #1190 [Paul Legato] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 09:51:24 +00:00
Jeremy Kemper
e24e2c41c2 Mark ticket # in changelog. Snip some trailing whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 09:04:52 +00:00
David Heinemeier Hansson
df95128e94 Fixed that has_and_belongs_to_many didn't respect single table inheritance types #1081 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:52:59 +00:00
Jeremy Kemper
b210edce38 r1618@asus: jeremy | 2005-07-03 08:24:19 -0700 
base attribute_present? on blank?, accounting for zero


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:33:03 +00:00
Jeremy Kemper
67adc0b5b3 r1617@asus: jeremy | 2005-07-03 08:23:31 -0700 
settle on the 'slow' MysqlAdapter#select since it means fewer comparisons later.  strip trailing whitespace.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1635 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:57 +00:00
Jeremy Kemper
94cd3fd135 r1616@asus: jeremy | 2005-07-03 08:07:13 -0700 
remove duplicate conditional


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1634 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:52 +00:00
Jeremy Kemper
9a10b31fe8 r1615@asus: jeremy | 2005-07-03 08:06:00 -0700 
oops, back out DELETE typo


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:47 +00:00
Jeremy Kemper
6e39c9e561 r1614@asus: jeremy | 2005-07-03 08:01:08 -0700 
minor perf tweaks + excise trailing whitespace


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1632 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:43 +00:00
Jeremy Kemper
81737fc0dd r1613@asus: jeremy | 2005-07-03 07:04:53 -0700 
optimize method_missing for common case (read_attribute).  minor perf tweaks


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:39 +00:00
Jeremy Kemper
5bc1e39b35 r1612@asus: jeremy | 2005-07-03 04:35:59 -0700 
don't include Benchmark into AbstractAdapter directly.  call Benchmark.realtime instead of bm = Benchmark.measure, bm.real


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:34 +00:00
Jeremy Kemper
45c4b07f5a r1611@asus: jeremy | 2005-07-03 04:21:52 -0700 
No longer pass superfluous connection to AbstractAdapter#log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1629 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:27 +00:00
Jeremy Kemper
f51f12d819 r1610@asus: jeremy | 2005-07-03 00:19:06 -0700 
remove Column#primary for now


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1628 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:22 +00:00
Jeremy Kemper
af9d03824a r1609@asus: jeremy | 2005-07-03 00:18:43 -0700 
more minor perf tweaks


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:17 +00:00
Jeremy Kemper
397c8ee2a9 r1608@asus: jeremy | 2005-07-03 00:13:57 -0700 
quoter required for column quoting


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:12 +00:00
Jeremy Kemper
b02776c232 r1607@asus: jeremy | 2005-07-02 23:36:52 -0700 
Rollback MysqlAdapter#select speedup; fix add_limit_offset


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1625 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:07 +00:00
Jeremy Kemper
018e12da31 r1605@asus: jeremy | 2005-07-02 14:50:23 -0700 
And take it out again.. passing around the quoter doesn't make sense any more because we're calling quote_column_name, not the generic quote method.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:02 +00:00
Jeremy Kemper
121b15bfc9 r1604@asus: jeremy | 2005-07-02 14:40:20 -0700 
Bring the column_quoter arg back to locking.rb.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1623 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:31:57 +00:00
Jeremy Kemper
96c60b0ec6 r1603@asus: jeremy | 2005-07-02 14:38:52 -0700 
Faster MysqlAdapter#select.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:31:14 +00:00
Jeremy Kemper
a250a98a52 r1602@asus: jeremy | 2005-07-02 14:34:00 -0700 
Don't pass connection to quoted_comma_pair_list


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1621 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:31:09 +00:00
Jeremy Kemper
9ebe33f14b r1601@asus: jeremy | 2005-07-02 14:33:08 -0700 
Only notify observers of after_find and after_initialize if these methods are defined on the model.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:27:18 +00:00
David Heinemeier Hansson
d9d22c7596 Fixed that single-table inheritance sub-classes couldn't be used to limit the result set with eager loading #1215 [Chris McGrath] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1619 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:21:22 +00:00
David Heinemeier Hansson
20d27f6b74 Fixed validates_numericality_of to work with overrided getter-method when :allow_nil is on #1316 [raidel@onemail.at] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1603 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 07:52:29 +00:00
David Heinemeier Hansson
9ac02777e7 Clarified intentions of validates_associated #870 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1602 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:59:08 +00:00
David Heinemeier Hansson
ebd7bf7945 Added roots, root, and siblings to the batch of methods added by acts_as_tree #1541 [michael@schuerig.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-01 18:33:38 +00:00
David Heinemeier Hansson
f2a29ca43c Added support for ODBC connections to MS SQL Server so you can connect from a non-Windows machine #1569 [Mark Imbriaco/DeLynn Berry] Added support for limit/offset with the MS SQL Server driver so that pagination will now work #1569 [DeLynn Berry] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-01 17:20:04 +00:00
David Heinemeier Hansson
c92ecb82b8 Fixed that multiparameter posts ignored attr_protected #1532 [alec+rails@veryclever.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 17:15:01 +00:00
David Heinemeier Hansson
3dfa56ccfb Updated all references to the old find_first and find_all to use the new style #1511 [Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 11:25:32 +00:00
David Heinemeier Hansson
1bb676b6c0 Fixed problem with eager loading when using a has_and_belongs_to_many association using :association_foreign_key #1504 [flash@vanklinkenbergsoftware.nl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1516 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 04:49:52 +00:00
David Heinemeier Hansson
302c23d5a6 Fixed Base#find to honor the documentation on how :joins work and make them consistent with Base#count #1405 [pritchie@gmail.com] Improved dynamic finder docs #1495 [laurel@gorgorg.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 11:47:37 +00:00
David Heinemeier Hansson
3eed3272d7 Fixed that validations didn't respecting custom setting for too_short, too_long messages #1437 [Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 11:24:43 +00:00
David Heinemeier Hansson
deda0ee4a8 Fixed that clear_association_cache doesn't delete new associations on new records (so you can safely place new records in the session with Action Pack without having new associations wiped) #1494 [cluon] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 10:56:20 +00:00
Jeremy Kemper
c8e2cf3ed0 Pass association finder arguments through to the association class exactly as we received them. Fixes case where parent.children.find() is interpreted as Child.find([]) instead of Child.find(). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1498 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-24 20:23:38 +00:00
David Heinemeier Hansson
1d4d721782 Fixed docs #856 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1475 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 17:11:01 +00:00
David Heinemeier Hansson
a9fd639adf Fixed that calling Model.find([]) returns [] and doesn't throw an exception #1379 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1471 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 16:36:18 +00:00
Jamis Buck
361be5a7dd Removed the AR::Recursion module--it broke more code than it fixed 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 12:58:27 +00:00
David Heinemeier Hansson
0bdd44acca Make migrations work with the latest SQLite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1458 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 06:00:17 +00:00
David Heinemeier Hansson
a2f26b971b Fixed that adding a record to a has_and_belongs_to collection would always save it -- now it only saves if its a new record #1203 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-18 05:28:59 +00:00
David Heinemeier Hansson
4f00d181d5 Document better #1057 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1452 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-18 05:18:59 +00:00
David Heinemeier Hansson
d808cd4582 Fixed saving of in-memory association structures to happen as a after_create/after_update callback instead of after_save -- that way you can add new associations in after_create/after_update callbacks without getting them saved twice 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1448 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-17 10:08:41 +00:00
David Heinemeier Hansson
c2ed453880 Fix quote_bound_value to not map Strings #1416 [htonl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1445 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 10:13:37 +00:00