github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-01 09:44:56 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,962 Commits 34 Branches 105 Tags
f7bb3ddce85dcafe8ae2c52f7b7fbd53b0859732
Commit Graph

1251 Commits

Author SHA1 Message Date
David Heinemeier Hansson
a263612b7e Refactored a bit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1202 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 07:02:12 +00:00
David Heinemeier Hansson
1a6954af01 Changed habtm eager loading to also use joins 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 05:55:20 +00:00
David Heinemeier Hansson
76690111d5 Fixes for postgresql testing #1129, #1130, #1131 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1199 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 05:03:56 +00:00
David Heinemeier Hansson
0591c53efd Made the dynamic finders use the new find API and updated the examples here and there 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 17:16:24 +00:00
David Heinemeier Hansson
7ff635c8eb Fixes a problem with the SQL Adapter which was resulting in IDENTITY_INSERT not being set to ON when it should be #1104 [adelle] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1192 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 13:59:02 +00:00
David Heinemeier Hansson
d5b67ed8d3 Added the option to specify the acceptance string in validates_acceptance_of #1106 [caleb@aei-tech.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1188 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 10:04:07 +00:00
David Heinemeier Hansson
339f4956b3 Added acts_as_nested_set #1000 [wschenk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1185 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:52:12 +00:00
David Heinemeier Hansson
ed46cc3058 Added insert_at(position) to acts_as_list #1083 [DeLynnB] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:50:17 +00:00
David Heinemeier Hansson
949294e0f7 Cleaned up validates_length_of by calling existing validations on the common stuff #1108 [caleb@aei-tech.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:34:13 +00:00
David Heinemeier Hansson
5e9dc49744 Dont prefix on updates and deletes, only selects 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:32:49 +00:00
David Heinemeier Hansson
0baf344457 Made migrations create InnoDB tables per default 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1168 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-16 06:38:12 +00:00
David Heinemeier Hansson
9dd8d3d3e4 Honor the order in the new finder 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-15 08:32:56 +00:00
David Heinemeier Hansson
75b8ac80d9 Dont initialize the association proxy for nil records 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-14 07:49:13 +00:00
David Heinemeier Hansson
cef09015c7 Order by is no longer a guarentee 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-14 04:07:26 +00:00
David Heinemeier Hansson
ff1db4de5f Qualify the ids used such that eager loading can avoid ambigious keys 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 18:12:59 +00:00
David Heinemeier Hansson
71bdf13b60 Removed the default order by id on has_and_belongs_to_many queries as it could kill performance on large sets (you can still specify by hand with :order) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 17:51:43 +00:00
David Heinemeier Hansson
ad24c6d756 Fixed pagination to work with joins #1034 [scott@sigkill.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 05:40:22 +00:00
David Heinemeier Hansson
908e9a17d8 Fixed that Base.silence should restore the old logger level when done, not just set it to DEBUG #1084 [yon@milliped.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 05:16:52 +00:00
David Heinemeier Hansson
5fe0ecce0a Fixed boolean saving on Oracle #1093 [mparrish@pearware.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 04:46:59 +00:00
David Heinemeier Hansson
d5cadfc110 Address parsing failed when the "to" (or "cc", or whatever) was an array. It was also too restrictive in the formats of the addresses #1097 [Jamis] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 04:44:58 +00:00
David Heinemeier Hansson
3b9e90a4da Moved build_association and create_association for has_one and belongs_to out of deprecation as they work when the association is nil unlike association.build and association.create, which require the association to be already in place #864 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1146 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-12 05:34:10 +00:00
David Heinemeier Hansson
b59619600f No conditions relevant here 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1145 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-11 15:13:43 +00:00
David Heinemeier Hansson
ea803aa4e3 Doc changes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-10 17:47:04 +00:00
David Heinemeier Hansson
a677da209b Added rollbacks of transactions if they're active as the dispatcher is killed gracefully (TERM signal) #1054 [Leon Bredt] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1136 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-10 17:34:29 +00:00
David Heinemeier Hansson
057cf4918b Added support for has_and_belongs_to_many associations in eager loading #1064 [Dan Peterson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1132 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-10 17:24:56 +00:00
David Heinemeier Hansson
fdd268138a Made eager loading work with inheritance hierarchies #1065 [Ryan Carver] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-10 15:49:49 +00:00
David Heinemeier Hansson
e819da27f4 Updated docs #1070 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-10 15:13:05 +00:00
David Heinemeier Hansson
7ad57c4f02 Added quoting of column names for fixtures #997 [jcfischer@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-07 06:54:25 +00:00
David Heinemeier Hansson
8afc284e2c Fixed check_box with postgresql booleans is more work now again #995 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-07 06:44:33 +00:00
David Heinemeier Hansson
7b37c779d8 Fixed counter_sql when no records exist in database for PostgreSQL (would give error, not 0) #1039 [Caleb Tennis] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-07 06:29:31 +00:00
David Heinemeier Hansson
81014da84c Use :foreign_key option if specified on the association 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-05 17:11:49 +00:00
David Heinemeier Hansson
d6901bfe93 Dont include multiple versions of the same association object 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1087 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-04 07:20:32 +00:00
David Heinemeier Hansson
9e799e731c Prefix primary key with table name so it works as part of a joined fetch 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-04 04:56:23 +00:00
David Heinemeier Hansson
edcaa2e5f7 More eager fixes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-03 18:21:20 +00:00
David Heinemeier Hansson
f8783abf0c Made eager loading work even more 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-03 17:50:11 +00:00
David Heinemeier Hansson
efb55d1cf5 Allow order, conditions, and joins in finds that include associations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-03 12:06:23 +00:00
David Heinemeier Hansson
4f6c943b05 Only include associations when the relevant rows have content 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-03 12:04:57 +00:00
David Heinemeier Hansson
abc895b828 Added new Base.find API and deprecated find_all, find_first. Added preliminary support for eager loading of associations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-03 10:52:05 +00:00
David Heinemeier Hansson
7c8d2f28e1 Removed broken attempt to DRY module ClassMethod #970 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 09:29:43 +00:00
David Heinemeier Hansson
c788bcb416 Automatically extend the class which gets a module included with the ClassMethods module if it exists #970 [Lucas Carlson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1068 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 09:14:19 +00:00
David Heinemeier Hansson
5b36c9275d Fixed boolean queries for t/f fields in PostgreSQL #995 [dave@cherryville.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 08:58:43 +00:00
David Heinemeier Hansson
1ba1779754 Added that model.items.delete(child) will delete the child, not just set the foreign key to nil, if the child is dependent on the model #978 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 08:52:51 +00:00
David Heinemeier Hansson
c6cc707854 Fixed auto-stamping of dates (created_on/updated_on) for PostgreSQL #985 [dave@cherryville.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1063 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 08:42:21 +00:00
David Heinemeier Hansson
aec31cd09f Fixed Base.silence/benchmark to only log if a logger has been configured #986 [skaes@web.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 08:31:26 +00:00
David Heinemeier Hansson
06a6133fff Added a join parameter as the third argument to Base.find_first and as the second to Base.count #426, #988 [skaes@web.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 08:29:54 +00:00
David Heinemeier Hansson
e130b9e017 Added a join parameter as the third argument to Base.find_first #426 [skaes@web.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1047 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-31 14:35:14 +00:00
David Heinemeier Hansson
cfef86c645 Fixed bug in Base#hash method that would treat records with the same string-based id as different [Dave Thomas] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-30 14:25:29 +00:00
David Heinemeier Hansson
715715aed4 Dont load the target before the proxy has had a chance to answer the respond_to? -- this would cause an .empty? query to trigger loading the entire collection if the proxy had already been initialized 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1036 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-29 12:31:05 +00:00
David Heinemeier Hansson
55cb8c8f0d Fixed that Active Record objects with float attribute could not be cloned #808 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1022 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-27 13:56:02 +00:00
David Heinemeier Hansson
5cd38ca25d Added documentation about named bind variables 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-27 12:04:07 +00:00