github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
13,568 Commits 34 Branches 105 Tags
fb89aba8b45bc5adbd3181ebb2e92ec99e63f821
Commit Graph

13568 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
José Valim
fb89aba8b4 Killing fixtures in mailer before they kill me (they usually lead to very brittle tests). 2010-03-22 21:07:37 +01:00
Emilio Tagua
d289e15af9 From and lock should be defined to be consistent with other ivars. Limit and offset are always defined, no need to test that. 
[#4253 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-22 11:48:39 -07:00
Evan Phoenix
4f5de7f89a Reset class attribute after changing it 2010-03-22 10:00:04 -07:00
Evan Phoenix
ab3503b496 Remove test ordering bug 
Don't reuse classes with class attributes when testing different use cases
of class attributes.
 2010-03-22 10:00:04 -07:00
Evan Phoenix
0b608abeb8 Clear the query cache between tests that test the query cache 2010-03-22 10:00:04 -07:00
Evan Phoenix
79b0861624 Remove obsolete use case that was broken in AR::Observers 2010-03-22 10:00:04 -07:00
Evan Phoenix
a307fd6bd3 Don't depend on order of elements in Set 2010-03-22 10:00:03 -07:00
Evan Phoenix
1e4be20672 Fix ActionMailer test issues 
* Don't depend so much no the message in a NameError
* Reset the delivery method properly
 2010-03-22 10:00:03 -07:00
Evan Phoenix
34497c0b36 Remove test ordering bug by using another class 2010-03-22 10:00:03 -07:00
Santiago Pastorino
3bd85e2748 db group makes more sense here 2010-03-22 02:55:28 -03:00
Santiago Pastorino
16cad60fd3 avoid active_support/core_ext/time/conversions.rb warnings 
[#4250 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-21 18:16:18 -07:00
Jeremy Kemper
4884f28c80 Also revert mailer generator test changes in 8b50f89 2010-03-21 16:18:32 -07:00
Jeremy Kemper
49416550fe Fix regression introduced in 8b50f89. Generated views mentioned the wrong path. 2010-03-21 16:07:21 -07:00
Denis Odorcic
b7adec3563 Remove data-url support from url_helper [#4236 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-21 19:31:59 +01:00
Sebastian Martinez
0137566c85 do not support 'data-url' anymore, just use 'href' [#4236 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-21 19:31:54 +01:00
José Valim
8b50f89ba7 Make ERB generators more flexible and customizable. 2010-03-21 19:30:42 +01:00
Joshua Peek
87db863fa2 Remove invalid builtin tests since we aren't adding that dir to the 
load path anymore
 2010-03-20 15:14:59 -05:00
Joshua Peek
fcc6b12e77 Autoload Rails::Info 2010-03-20 14:03:43 -05:00
Joshua Peek
14b7452c57 Require info controller from info routes 2010-03-20 13:33:25 -05:00
Joshua Peek
f38e89cfba Move railties/builtin into lib 2010-03-20 12:34:21 -05:00
wycats
f868c2afa9 response_body is an Array in 1.9, so an Array was being pushed onto the cache 2010-03-19 18:56:06 -07:00
wycats
e1c030edd8 Fixed a bunch of tests that failed in 1.9 because they assumed that a Rack response was a String. 2010-03-19 18:46:29 -07:00
Sam Ruby
80095c54bd Controller generators should generate tests when action is supplied. [#3421 state:resolved] 2010-03-20 00:51:56 +01:00
José Valim
525382f638 Clean up Mime::Type and remove deprecated stuff (from 2.3). 2010-03-20 00:28:27 +01:00
wycats
9f92563892 Eliminate an error from an implicit dependency on AV::Base 2010-03-19 11:50:03 -07:00
Carlhuda
7f53dca1a1 Fix protect_against_forgery 2010-03-19 11:11:02 -07:00
José Valim
562154fcbc Controller generator now creates routes as well [#4233 state:resolved] 2010-03-19 18:12:54 +01:00
Aaron Patterson
541194f641 switching migrations to use require cleans up many warnings [#4234 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-19 09:56:22 -07:00
José Valim
ae499b53ef Merge branch 'master' of gitproxy:rails/rails 2010-03-19 17:23:44 +01:00
José Valim
f28d856cec Improve performance of the rendering stack by freezing formats as a sign that they shouldn't be further modified. 2010-03-19 17:20:20 +01:00
Xavier Noria
f3743362c2 cleans a bit #compute_public_path 
[#4232 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-19 07:32:41 -07:00
José Valim
fbe35656a9 Singleton classes returns parent's methods with instance_methods(false) and this makes remove_method in Module#delegate fail. Add a test case and fix the bug. 2010-03-19 12:01:48 +01:00
Sebastian Martinez
b395c81e3c removed useless require line 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-19 11:08:06 +01:00
wycats
0aa0c37b59 Well that was a bust 2010-03-18 22:55:44 -07:00
wycats
995f57033f We seem to have removed the URL helpers from ActionView subclasses... 2010-03-18 22:21:25 -07:00
Carlhuda
a5d80f84d2 Each controller class has it's own view context subclass. This removes the need for ActionView::Base.for_controller 2010-03-18 18:14:54 -07:00
Santiago Pastorino
e629e21135 remove duplicated self.view_paths assingment on controller tests [#4206 state:commited] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 17:50:28 -07:00
Santiago Pastorino and Sebastian Martinez
e7276a9f09 Make dependencies_test pass running standalone [#4215 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 17:50:28 -07:00
Santiago Pastorino and Sebastian Martinez
1e2caa5d52 Added missing requires abstract_unit and activesupport to the loadpath of ts_isolated [#4215 state:committed] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 17:50:28 -07:00
Carlhuda
1dacc19702 Return a valid Rack response from bare ActionController::Metal 2010-03-18 17:32:53 -07:00
Carlhuda
edb5991a14 Make render :partial, :layout consistent between AC and AV 2010-03-18 16:55:32 -07:00
Carlhuda
71c9337f45 All tests pass without memoizing view_context 2010-03-18 15:52:43 -07:00
Carlhuda
523d0f3700 Remove caching's dependency on view_context. Also, make it so that the layout is always rendered the same way (so that layout dependencies on the action actually being rendered aren't masked on the first render) 2010-03-18 14:55:29 -07:00
Carlhuda
d8c7efece6 Make action_has_layout? non-private 2010-03-18 14:55:29 -07:00
Carlhuda
3deb60e6b4 @layout is a confusing name... use @cache_layout 2010-03-18 14:55:29 -07:00
Aaron Patterson
587f468282 kill where / having method redefine warnings. [#4225 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 13:30:59 -07:00
wycats
014bd4b287 Merge branch 'master' of github.com:rails/rails 2010-03-18 13:30:52 -07:00
Sebastian Martinez
14b1dc209d Fixed require line 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 11:54:50 -07:00
Carlhuda
8e64998951 While isolated tests are useful, they take far too long to run for us to be getting useful information from CI. Perhaps another box that runs the isolated tests every 3 hours (instead of per commit) 2010-03-18 11:37:04 -07:00
Sebastian Martinez
bc36618ae6 added require abstract_unit on setter_trap.rb 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 11:32:51 -07:00