Denis Odorcic
b7adec3563
Remove data-url support from url_helper [ #4236 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-21 19:31:59 +01:00
wycats
f868c2afa9
response_body is an Array in 1.9, so an Array was being pushed onto the cache
2010-03-19 18:56:06 -07:00
wycats
e1c030edd8
Fixed a bunch of tests that failed in 1.9 because they assumed that a Rack response was a String.
2010-03-19 18:46:29 -07:00
José Valim
525382f638
Clean up Mime::Type and remove deprecated stuff (from 2.3).
2010-03-20 00:28:27 +01:00
wycats
9f92563892
Eliminate an error from an implicit dependency on AV::Base
2010-03-19 11:50:03 -07:00
Carlhuda
7f53dca1a1
Fix protect_against_forgery
2010-03-19 11:11:02 -07:00
José Valim
ae499b53ef
Merge branch 'master' of gitproxy:rails/rails
2010-03-19 17:23:44 +01:00
José Valim
f28d856cec
Improve performance of the rendering stack by freezing formats as a sign that they shouldn't be further modified.
2010-03-19 17:20:20 +01:00
Xavier Noria
f3743362c2
cleans a bit #compute_public_path
...
[#4232 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-19 07:32:41 -07:00
wycats
0aa0c37b59
Well that was a bust
2010-03-18 22:55:44 -07:00
wycats
995f57033f
We seem to have removed the URL helpers from ActionView subclasses...
2010-03-18 22:21:25 -07:00
Carlhuda
a5d80f84d2
Each controller class has it's own view context subclass. This removes the need for ActionView::Base.for_controller
2010-03-18 18:14:54 -07:00
Santiago Pastorino
e629e21135
remove duplicated self.view_paths assingment on controller tests [ #4206 state:commited]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 17:50:28 -07:00
Carlhuda
1dacc19702
Return a valid Rack response from bare ActionController::Metal
2010-03-18 17:32:53 -07:00
Carlhuda
edb5991a14
Make render :partial, :layout consistent between AC and AV
2010-03-18 16:55:32 -07:00
Carlhuda
71c9337f45
All tests pass without memoizing view_context
2010-03-18 15:52:43 -07:00
Carlhuda
523d0f3700
Remove caching's dependency on view_context. Also, make it so that the layout is always rendered the same way (so that layout dependencies on the action actually being rendered aren't masked on the first render)
2010-03-18 14:55:29 -07:00
Carlhuda
d8c7efece6
Make action_has_layout? non-private
2010-03-18 14:55:29 -07:00
Carlhuda
3deb60e6b4
@layout is a confusing name... use @cache_layout
2010-03-18 14:55:29 -07:00
José Valim
191a2f78b1
Sending the partial as info is no longer required.
2010-03-18 12:12:07 +01:00
Jeremy Kemper
41af6d9a78
Use Array.wrap not Array()
2010-03-17 22:27:48 -07:00
Mathias Biilmann Christensen
c8dd6f224c
Deleting and setting a cookie in the same request was broken
...
Made sure to remove a cookie from @deleted_cookies when set
[#4211 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 18:04:32 -07:00
Carlhuda
0e15f07b75
Get modules back into integration tests
2010-03-17 17:52:21 -07:00
Mathias Biilmann Christensen
6c0c0f41a3
Fix for missing dependency in ActionDispatch::Integration
...
When running cucumber features from a new rails 3 app requiring
'cucumber/rails/world' would raise:
uninitialized constant ActionDispatch::Integration::Session::Test (NameError)
Fixed by requiring 'test/unit/assertions' in action_dispatch/integration
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 16:53:42 -07:00
Carlhuda
d9375f3f30
Modify assert_template to use notifications. Also, remove ActionController::Base#template since it is no longer needed.
2010-03-17 16:29:35 -07:00
José Valim
a6dc227167
Mark bang instrumentations as something that you shuold not be listening to.
2010-03-17 23:44:03 +01:00
José Valim
21dcbb17de
Ensure json is loaded before using responders.
2010-03-17 23:09:28 +01:00
Carlhuda
6416a35f4b
Remove unneeded AV::Base and AV::Template monkey-patches
2010-03-17 14:29:18 -07:00
Carlhuda
947f86c699
Modify assert_template to use instrumentation
2010-03-17 14:29:18 -07:00
Joshua Peek
13a783672a
Install url helpers on module instance so they can be accessed
...
globally
2010-03-17 16:05:29 -05:00
wycats
a5587efc19
Remove some 1.9 warnings (resulting in some fixed bugs). Remaining AM warnings are in dependencies.
2010-03-17 00:20:09 -07:00
wycats
cd9ffd11e1
Eliminate warnings for AM on 1.8
2010-03-16 23:24:00 -07:00
wycats
c738812415
Another missing require
2010-03-16 21:37:54 -07:00
Joshua Peek
d69e5616e8
link_to_function is here to stay
2010-03-16 22:06:16 -05:00
wycats
55aac2c696
Fix missing require
2010-03-16 17:32:42 -07:00
wycats
7c49b1adbb
Make sure options[:anchor] is correct in shorthand cases
2010-03-16 17:29:11 -07:00
Santiago Pastorino
0c1ac36ccb
scope_key_by_partial fix for Ruby 1.9 when there's virtual_path [ #4202 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 16:20:10 -07:00
Carl Lerche
23b6def0eb
Do not always include the named URL helpers into AC::Base and AV::Base.
2010-03-16 15:47:49 -07:00
Carl Lerche
3abf5ad7f8
Make RouteSet#finalize! a NOOP if it's been called already. Call finalize! the first time call() and url_for() are called if the RouteSet has not been finalized yet.
2010-03-16 15:47:48 -07:00
José Valim
56fb60ebfe
Fix rendering of HTML partials inside JS templates [ #4197 status:resolved]
2010-03-16 23:36:29 +01:00
Santiago Pastorino
12bf636461
translation method of TranslationHelper module returns always SafeBuffer [ #4194 status:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 13:49:13 -07:00
Xavier Noria
9659d18c9b
adds tests for #flush_output_buffer
...
[#4196 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 13:16:44 -07:00
Xavier Noria
986cac73e3
adds tests for #capture
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 13:10:54 -07:00
Carlhuda
c61ed70b00
Some more tweaks on <% %>.
...
* The cache helper is now semantically "mark this region for caching"
* As a result, <% x = cache do %> no longer works
2010-03-16 11:43:04 -07:00
Santiago Pastorino
e13c179499
Change array entries to safe doesn't worth then the array is joined as a string losing the safe property of his entries [ #4134 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-16 11:10:31 +01:00
Jeremy Kemper
b65b989725
Break a window :/
2010-03-15 23:49:35 -07:00
Jeremy Kemper
748c78ffc8
RJS may cache an array
2010-03-15 23:48:32 -07:00
Jeremy Kemper
b3b6ff48df
Fix link_to with block
2010-03-15 23:26:48 -07:00
Jeremy Kemper
9e1e95f70a
link_to_remote -> link_to :remote => true
2010-03-15 23:05:12 -07:00
Jeremy Kemper
b9c48f519f
Swear I ran this test
2010-03-15 22:44:49 -07:00
