github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
13,568 Commits 34 Branches 105 Tags
fb89aba8b45bc5adbd3181ebb2e92ec99e63f821
Commit Graph

3588 Commits

Author SHA1 Message Date
Emilio Tagua
d289e15af9 From and lock should be defined to be consistent with other ivars. Limit and offset are always defined, no need to test that. 
[#4253 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-22 11:48:39 -07:00
Evan Phoenix
4f5de7f89a Reset class attribute after changing it 2010-03-22 10:00:04 -07:00
Evan Phoenix
0b608abeb8 Clear the query cache between tests that test the query cache 2010-03-22 10:00:04 -07:00
Evan Phoenix
79b0861624 Remove obsolete use case that was broken in AR::Observers 2010-03-22 10:00:04 -07:00
Evan Phoenix
a307fd6bd3 Don't depend on order of elements in Set 2010-03-22 10:00:03 -07:00
Evan Phoenix
34497c0b36 Remove test ordering bug by using another class 2010-03-22 10:00:03 -07:00
Aaron Patterson
541194f641 switching migrations to use require cleans up many warnings [#4234 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-19 09:56:22 -07:00
Aaron Patterson
587f468282 kill where / having method redefine warnings. [#4225 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 13:30:59 -07:00
Aaron Patterson
3911a7c197 squelching more warnings in the AR tests. [#4218 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 10:24:16 -07:00
Aaron Patterson
b652aa8121 cleaning up a bunch of method already defined warnings [#4209 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-17 13:56:33 -07:00
Jeremy Kemper
067b350301 Move require closer to home 2010-03-17 10:11:38 -07:00
Aaron Patterson
843255a763 fixing activerecord tests [#4205 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-17 10:09:14 -07:00
Aaron Patterson
df735cf5b7 fisting uninitialized ivar warnings. [#4198 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-16 15:11:00 -07:00
Aaron Patterson
8c3e46c093 clean up more warnings, remove unnecessary methods, fix eval line numbers. [#4193 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-16 11:48:34 -07:00
Aaron Patterson
dcf1441c0f removing dead code from activerecord tests. [#4187 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-15 18:36:08 -07:00
Aaron Patterson
1def14309f cleaning up a bunch of parse time warnings in AR [#4186 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-15 18:22:31 -07:00
Jeremy Kemper
1f2738261f Hack to keep column metadata queries out of test query counts 2010-03-15 13:56:19 -07:00
Jeremy Kemper
30f5f95544 Hack to keep column metadata queries out of test query counts 2010-03-15 11:00:25 -07:00
Aaron Patterson
5de3698e2b cleaning up many more warnings in activerecord [#4180 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-15 08:57:41 -07:00
Aaron Patterson
95bd56e3cc speeding up clone_attributes, changing readonly to be initialized in def initialize 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-14 17:29:25 -06:00
Aaron Patterson
115230e619 cleaning up some test warnings 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-14 17:28:27 -06:00
Xavier Noria
c8f1aac761 restricts a test to < 1.9, and rewrites it using a proper expectation 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-13 17:04:08 -06:00
Xavier Noria
89eae2d187 adds coverage for the issue addressed in fe43bbd 
[#4166 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-12 13:22:47 -08:00
Xavier Noria
fe43bbd8c7 keep AssociationProxy#to_a to avoid warning in Array(post.author), and delegate it to @target in association collections 
[#4165 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-12 11:53:22 -08:00
Jeremy Kemper
c5ff181480 Use arel 0.3.1, for srs 2010-03-10 14:04:10 -08:00
Jeremy Kemper
275df55106 Bump arel dep to 0.3.0+ 2010-03-10 13:49:11 -08:00
Emilio Tagua
e08c153a08 Arel now fallback to using Arel::Attribute if the table/column doesn't exists. 
[#4142 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-10 13:49:11 -08:00
Aaron Patterson
aad432a9e9 removing spawn from SpawnMethods 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-10 13:29:00 -08:00
Pratik Naik
181c414baa Fix scope loading issue when the table doesn't exist 2010-03-10 11:28:04 +00:00
Carlos Antonio da Silva
47d252f992 Fix associations to call :destroy or :delete based on the right :dependent option 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-09 00:11:34 +01:00
wycats
39d6f9e112 Make many parts of Rails lazy. In order to facilitate this, 
add lazy_load_hooks.rb, which allows us to declare code that
should be run at some later time. For instance, this allows
us to defer requiring ActiveRecord::Base at boot time purely
to apply configuration. Instead, we register a hook that should
apply configuration once ActiveRecord::Base is loaded.

With these changes, brings down total boot time of a
new app to 300ms in production and 400ms in dev.

TODO: rename base_hook
 2010-03-07 06:24:30 -08:00
Aaron Patterson
a424f199a9 drying up more code in associations.rb 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 21:41:13 -08:00
Aaron Patterson
939291e8f2 deleting repeated code 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 21:33:29 -08:00
Stefan Penner
4bc2cbc3cf Load RAILS_VERSION relative to the gemspec file. 2010-03-06 21:33:28 -08:00
Aaron Patterson
3789539916 converting inject to each and map 
[#4119 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-06 20:31:50 -08:00
Aaron Patterson
45c36ea096 refactoring build_where 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 13:25:12 -08:00
Bryan Helmkamp
deb00bcb8c Read Rails version from a file instead of modifying the load path and doing requires 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-04 21:25:52 -08:00
Carl Lerche
0de3b9ec93 Somehow this fixes the AR tests when ran with rake. I should probably figure out why. 2010-03-04 02:20:01 -08:00
Carl Lerche
07b5146442 Fix active_records' log tests 2010-03-02 23:01:31 -08:00
Jeremy Kemper
56ea20605a Wordsmith gem descriptions 2010-03-02 10:43:41 -08:00
Bryan Helmkamp
f221a6f19f Leverage VERSION constants from gemspecs to avoid tedious updates when releasing 2010-03-02 00:32:53 -05:00
Bryan Helmkamp
a4111bbca0 Update versions of all components to normalize them to new format 2010-03-02 00:32:48 -05:00
Bryan Helmkamp
11db694e0b Remove cruft in the gem packaging and release code 2010-03-01 19:00:19 -08:00
Joshua Peek
5cc17da894 activerecord test load paths 2010-02-28 18:28:25 -06:00
José Valim
f3839b2b99 ActiveRecord should raise an error on invalid migration types. 2010-02-28 11:53:48 +01:00
S. Christoffer Eliesen
09cb0977d4 Print database.rake errors to stderr. 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-02-27 16:53:40 -08:00
Santiago Pastorino
b25c41e6d8 no more warning interpreted as argument prefix on association_preload.rb 2010-02-26 14:54:10 -08:00
Tobias Bielohlawek
4db72b702f fixed a 'RecordNotFound' bug when calling 'reload' on a object which doesn't met the default_scope conditions, added test [#3166 status:resolved] 
The reload method didn't made use of 'with_exclusive_scope' when reloading the object. This lead to a RecordNotFound exception, in case the object doesn't met the default_scope condition (anymore) - which is obviously a bug. This quick fix makes use of with_exclusive_scope in the reload method as well. See test for full example.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-26 11:14:16 +01:00
Henry Hsu
bf9a0ae12b Fix a bug where default_scope was overriding attributes given on model initialization [#3218 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-26 11:09:43 +01:00
Jeremy Kemper
f7b0a857e9 Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice. 2010-02-25 09:32:29 -08:00