José Valim
fbe35656a9
Singleton classes returns parent's methods with instance_methods(false) and this makes remove_method in Module#delegate fail. Add a test case and fix the bug.
2010-03-19 12:01:48 +01:00
Sebastian Martinez
b395c81e3c
removed useless require line
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-19 11:08:06 +01:00
wycats
0aa0c37b59
Well that was a bust
2010-03-18 22:55:44 -07:00
wycats
995f57033f
We seem to have removed the URL helpers from ActionView subclasses...
2010-03-18 22:21:25 -07:00
Carlhuda
a5d80f84d2
Each controller class has it's own view context subclass. This removes the need for ActionView::Base.for_controller
2010-03-18 18:14:54 -07:00
Santiago Pastorino
e629e21135
remove duplicated self.view_paths assingment on controller tests [ #4206 state:commited]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 17:50:28 -07:00
Santiago Pastorino and Sebastian Martinez
e7276a9f09
Make dependencies_test pass running standalone [ #4215 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 17:50:28 -07:00
Santiago Pastorino and Sebastian Martinez
1e2caa5d52
Added missing requires abstract_unit and activesupport to the loadpath of ts_isolated [ #4215 state:committed]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 17:50:28 -07:00
Carlhuda
1dacc19702
Return a valid Rack response from bare ActionController::Metal
2010-03-18 17:32:53 -07:00
Carlhuda
edb5991a14
Make render :partial, :layout consistent between AC and AV
2010-03-18 16:55:32 -07:00
Carlhuda
71c9337f45
All tests pass without memoizing view_context
2010-03-18 15:52:43 -07:00
Carlhuda
523d0f3700
Remove caching's dependency on view_context. Also, make it so that the layout is always rendered the same way (so that layout dependencies on the action actually being rendered aren't masked on the first render)
2010-03-18 14:55:29 -07:00
Carlhuda
d8c7efece6
Make action_has_layout? non-private
2010-03-18 14:55:29 -07:00
Carlhuda
3deb60e6b4
@layout is a confusing name... use @cache_layout
2010-03-18 14:55:29 -07:00
Aaron Patterson
587f468282
kill where / having method redefine warnings. [ #4225 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 13:30:59 -07:00
wycats
014bd4b287
Merge branch 'master' of github.com:rails/rails
2010-03-18 13:30:52 -07:00
Sebastian Martinez
14b1dc209d
Fixed require line
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 11:54:50 -07:00
Carlhuda
8e64998951
While isolated tests are useful, they take far too long to run for us to be getting useful information from CI. Perhaps another box that runs the isolated tests every 3 hours (instead of per commit)
2010-03-18 11:37:04 -07:00
Sebastian Martinez
bc36618ae6
added require abstract_unit on setter_trap.rb
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 11:32:51 -07:00
Carlhuda
9da153c2d3
Fix an error in isolated running of tests
2010-03-18 11:31:52 -07:00
snusnu
d164d868b3
AS datetime conversions now require AS time conversions
2010-03-18 10:48:11 -07:00
Aaron Patterson
3911a7c197
squelching more warnings in the AR tests. [ #4218 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 10:24:16 -07:00
José Valim
191a2f78b1
Sending the partial as info is no longer required.
2010-03-18 12:12:07 +01:00
Jeremy Kemper
41af6d9a78
Use Array.wrap not Array()
2010-03-17 22:27:48 -07:00
Jeremy Kemper
fe2f383cf3
Fix broken test due to constant collision
2010-03-17 22:27:34 -07:00
Jeremy Kemper
db9e67a6c8
Kill nonexistent method removal
2010-03-17 21:43:01 -07:00
Mathias Biilmann Christensen
c8dd6f224c
Deleting and setting a cookie in the same request was broken
...
Made sure to remove a cookie from @deleted_cookies when set
[#4211 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 18:04:32 -07:00
Carlhuda
0e15f07b75
Get modules back into integration tests
2010-03-17 17:52:21 -07:00
Mathias Biilmann Christensen
6c0c0f41a3
Fix for missing dependency in ActionDispatch::Integration
...
When running cucumber features from a new rails 3 app requiring
'cucumber/rails/world' would raise:
uninitialized constant ActionDispatch::Integration::Session::Test (NameError)
Fixed by requiring 'test/unit/assertions' in action_dispatch/integration
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 16:53:42 -07:00
Carlhuda
d9375f3f30
Modify assert_template to use notifications. Also, remove ActionController::Base#template since it is no longer needed.
2010-03-17 16:29:35 -07:00
José Valim
7872fa9a43
Merge branch 'master' of gitproxy:rails/rails
2010-03-17 23:47:22 +01:00
José Valim
a6dc227167
Mark bang instrumentations as something that you shuold not be listening to.
2010-03-17 23:44:03 +01:00
snusnu
644219a680
Require AS singleton_class code in AS output_safety
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 15:14:35 -07:00
José Valim
21dcbb17de
Ensure json is loaded before using responders.
2010-03-17 23:09:28 +01:00
Carlhuda
6416a35f4b
Remove unneeded AV::Base and AV::Template monkey-patches
2010-03-17 14:29:18 -07:00
Carlhuda
947f86c699
Modify assert_template to use instrumentation
2010-03-17 14:29:18 -07:00
Joshua Peek
13a783672a
Install url helpers on module instance so they can be accessed
...
globally
2010-03-17 16:05:29 -05:00
Aaron Patterson
b652aa8121
cleaning up a bunch of method already defined warnings [ #4209 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-17 13:56:33 -07:00
Aaron Patterson
db2d96a6ba
fixing activemodel tests. [ #4210 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-17 13:46:21 -07:00
Jeremy Kemper
067b350301
Move require closer to home
2010-03-17 10:11:38 -07:00
Aaron Patterson
843255a763
fixing activerecord tests [ #4205 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 10:09:14 -07:00
wycats
7a83abe52f
Any reason we can't just use the slow 1.8 path for transliteration in 1.9?
2010-03-17 00:54:42 -07:00
wycats
640ee5b68d
Fix some more warnings on 1.9
2010-03-17 00:53:48 -07:00
wycats
a5587efc19
Remove some 1.9 warnings (resulting in some fixed bugs). Remaining AM warnings are in dependencies.
2010-03-17 00:20:09 -07:00
wycats
cd9ffd11e1
Eliminate warnings for AM on 1.8
2010-03-16 23:24:00 -07:00
wycats
c738812415
Another missing require
2010-03-16 21:37:54 -07:00
Joshua Peek
d69e5616e8
link_to_function is here to stay
2010-03-16 22:06:16 -05:00
wycats
55aac2c696
Fix missing require
2010-03-16 17:32:42 -07:00
wycats
7c49b1adbb
Make sure options[:anchor] is correct in shorthand cases
2010-03-16 17:29:11 -07:00
Santiago Pastorino
0c1ac36ccb
scope_key_by_partial fix for Ruby 1.9 when there's virtual_path [ #4202 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 16:20:10 -07:00
