Commit Graph

17712 Commits

Author SHA1 Message Date
Neeraj Singh
fc01adee79 correcting wrong example 2010-08-06 15:51:52 -04:00
Neeraj Singh
74dde5951a updating documentation for method configure_dependency_for_has_many 2010-08-06 15:24:53 -04:00
Xavier Noria
62bb83d0a2 AS guide: documents calculations with Time objects 2010-08-06 17:29:52 +02:00
Xavier Noria
3e678240f4 edit pass to AMo::Serializers::JSON 2010-08-06 13:56:38 +02:00
Xavier Noria
23abf46112 AR guide: fixes a query 2010-08-06 13:33:02 +02:00
Xavier Noria
e0a0638094 commit review: say clearly that AS::OrderedHash is about insertion order, be more neutral in wording, do not imply lack of ordering is a problem 2010-08-06 13:11:44 +02:00
Neeraj Singh
cdbc880055 adding documentation for OrderedHash and OrderedOptions 2010-08-06 01:51:11 -04:00
Neeraj Singh
d0ac56b5b4 adding an example of skipping a callback 2010-08-06 01:51:11 -04:00
Xavier Noria
d62700f7dc Merge remote branch 'docrails/master' 2010-08-05 22:56:15 +02:00
Xavier Noria
02e711bf1c documents that :terminator is a string to be eval'ed, and that it sees the result variable 2010-08-05 22:54:43 +02:00
Xavier Noria
232218f465 Revert "correcting the documentation that default to false. it does not default to false. returing either false or nil will not halt the chain unless :terminator is explicitly mentioned"
This reverts commit cd87cf771a.

Reason: it does default to "false".
2010-08-05 22:46:04 +02:00
Neeraj Singh
86842fd1ce fixing typo 2010-08-05 16:35:40 -04:00
Neeraj Singh
5130b0cf45 more documentation for class_inheritable_* 2010-08-05 11:55:45 -04:00
Neeraj Singh
cd87cf771a correcting the documentation that default to false. it does not default to false. returing either false or nil will not halt the chain unless :terminator is explicitly mentioned 2010-08-05 11:55:45 -04:00
Aaron Patterson
1ca18a6f85 fixing whitespace errors 2010-08-05 08:15:22 -07:00
Xavier Noria
8a657c0dc7 adds test coverage to ensure DateTime#advance processes first the date deltas, and then the time deltas 2010-08-05 16:12:43 +02:00
Xavier Noria
9989d3337f Merge remote branch 'docrails/master' 2010-08-05 15:56:42 +02:00
Xavier Noria
02572399a5 AS guide: documents DateTime#advance 2010-08-05 14:10:07 +02:00
Tom Stuart
f544c0a32d Fix ActiveSupport::Callbacks' define_callbacks and ActiveSupport::Concern documentation to look like native English 2010-08-05 09:06:47 +01:00
Aaron Patterson
117b096d0a avoid passing lists of lists to the group clause 2010-08-04 16:24:01 -07:00
Xavier Noria
3cbe111439 Merge remote branch 'docrails/master' 2010-08-05 01:15:57 +02:00
Xavier Noria
d191db76e0 standarizes the use of the article "an" for "SQL" and "SQLite" 2010-08-05 01:09:09 +02:00
Aaron Patterson
ec736dff7b call to_a since we are not passing anything to all() 2010-08-04 14:22:29 -07:00
Aaron Patterson
30abb01d07 fisting indentation 2010-08-04 14:11:30 -07:00
Neeraj Singh
589e6977d7 adding documentation to ActiveSupport::Concern ht:strictly typed for an awesome example
some minor documentation changes
2010-08-04 17:03:03 -04:00
Piotr Sarnacki
84f0a0bc30 Reload action_methods in AbstractController after defining new method.
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-04 14:44:34 -03:00
José Valim
462666b737 Revert "If a file is in the load path, require it without its full path (in more places)"
Caused failures in ActionMailer test suite.

This reverts commit 991cd59a22.
2010-08-04 14:17:46 -03:00
Aaron Patterson
cff7f53fbc do not pass AR objects to ARel 2010-08-04 08:44:53 -07:00
José Valim
7e2399a42f Revert "Put lib back on the autoload path"
This was causing engines/gems to eager load everything in lib. Another fix is comming soon.

This reverts commit 02a5842cd0.
2010-08-04 14:13:50 +02:00
Simone Carletti
7745f716a1 Fixed Railtie Rdoc examples not properly formatted [#4918 state:resolved]
Signed-off-by: Simone Carletti <weppos@weppos.net>
2010-08-04 13:27:14 +02:00
wycats
c25c3879ce I'm unsure how cloning was working in Rails 3 before 2010-08-04 04:05:54 -07:00
wycats
847c123ca5 Concernify SanitizeHelper and TextHelper so including TextHelper correctly include SanitizeHelper and extends its ClassMethods 2010-08-04 03:25:57 -07:00
wycats
991cd59a22 If a file is in the load path, require it without its full path (in more places) 2010-08-04 03:25:57 -07:00
wycats
8bf79739b4 require_dependency should require using the normal mechanism if possible to avoid double-requires 2010-08-04 03:25:57 -07:00
Aaron Patterson
6d6ed55324 avoid passing AR::Base objects to Arel when we can 2010-08-03 17:58:56 -07:00
RainerBlessing
7e4e1f0ca5 query value is converted to_s instead of to_yaml
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-03 21:08:43 -03:00
wycats
02a5842cd0 Put lib back on the autoload path 2010-08-03 14:57:55 -07:00
wycats
c0fa4de65b Allow :name to be a Symbol (was this removed by accident?) 2010-08-03 12:22:36 -07:00
Mark Hayes
b3bb684ecb removed duplicate word 2010-08-03 12:12:16 -07:00
Subba Rao Pasupuleti
8d9d8bc93c Tidy up error.rb code
[#5288 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-03 14:54:13 -03:00
Aaron Patterson
41c1aa607d order query is already a string, no need to to_s 2010-08-03 09:16:01 -07:00
Santiago Pastorino
b8634dddab Stub is_a? not instance_of? here 2010-08-03 12:17:53 -03:00
José Valim
84081fcc54 Freeze options so we raise an error when people modify it in place. 2010-08-03 15:36:23 +02:00
José Valim
f23bc8444b validates_length_of should not change the options hash in place. [#5283 state:resolved] 2010-08-03 15:22:54 +02:00
rohit
621246f997 Failing test for validates_length_of, when both too_short and too_long messages are set [#5283 state:open]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-03 15:11:51 +02:00
Samuel Lebeau
f01184ad9e Avoid potentially expensive inspect call in router. [#4491 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-03 11:52:19 +02:00
Curtis Cablegram
e1142dfcae Refactor log-tailer to depend on File#eof? rather than File#mtime
[#5220 state:resolved]

Eliminate 1 instance variable and 1 local variable.

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-03 10:50:25 +02:00
Curtis Cablegram
1466f312ba Change log-tailer to properly track multi-byte characters.
When end-of-line is represented within a file as "\r\n",
it is represented in memory as a single "\n".  This patch eliminates
the discrepancy between size on disk and size in memory.

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-03 10:50:21 +02:00
Tore Darell
2c8a4a53a8 Remove or fix non-working examples and add a few tests to Dirty [#5185 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-03 10:47:30 +02:00
Neeraj Singh
fb2b8fec24 adding test cases for ActiveModel::Errors
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-03 10:46:16 +02:00