github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
19,587 Commits 34 Branches 105 Tags
fd47a4bf438e37a20756e0341cd7cd4e472fd3cb
Commit Graph

19587 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ryan Bigg
fd47a4bf43 Document the :path option for resources :posts 2010-11-24 09:28:21 +11:00
Ryan Bigg
01af50d8b6 Add :module option documentation for the resources method 2010-11-24 09:27:12 +11:00
Ryan Bigg
2974f57aae Remove non-sensical first couple of lines for scope method documentation 2010-11-24 09:25:01 +11:00
Ryan Bigg
04af510b56 Paths in ActionDispatch::Scoping documentation should be for /admin/posts, not /admin/photos 2010-11-24 09:21:25 +11:00
Ryan Bigg
769575300a Fix formatting issue with rake routes output for the namespace method 2010-11-24 09:19:27 +11:00
Xavier Noria
85d64316a4 Merge branch 'master' of git://github.com/lifo/docrails 2010-11-23 21:59:50 +01:00
Emilio Tagua
9f35799221 Refactor && simplify count_records. 2010-11-23 09:51:07 -08:00
Emilio Tagua
e2bad8a2e7 No need to create a variables to use them once. 2010-11-24 01:37:02 +08:00
Emilio Tagua
d29d793c90 Don't create local vars. 2010-11-24 01:37:01 +08:00
Emilio Tagua
6ffe0ef55b Avoid creating local var. 2010-11-24 01:37:01 +08:00
Emilio Tagua
63c9185b62 Remove explicit return and avoid creating local var. 2010-11-24 01:37:01 +08:00
Emilio Tagua
1b531b7ee2 Remove explicit return. 2010-11-24 01:37:00 +08:00
Emilio Tagua
b8df3a9197 Use params default. 2010-11-24 01:37:00 +08:00
Emilio Tagua
861cdc4c59 Remove unneeded local var. 2010-11-24 01:36:59 +08:00
Emilio Tagua
9c161599ac Remove uneeded local var definition. 2010-11-24 01:36:59 +08:00
Emilio Tagua
a9e963d51d Remove confusing parenthesis. 2010-11-24 01:36:59 +08:00
Emilio Tagua
14055ea282 No need to define a local var here. 2010-11-24 01:36:59 +08:00
Jaime Iniesta
fd64bba648 i18n guide: fix RedCloth artifacts that were rendering bad format and broken links on 2.3 warnings 2010-11-23 17:53:59 +01:00
José Valim
da583df50c Remove bazillion warnings from AP suite. 2010-11-23 10:09:24 +01:00
José Valim
56b1214024 Speed up subdomain and domain calculus. 2010-11-23 10:05:47 +01:00
Josh Kalderimis
2fe43b694f :subdomain, :domain and :tld_length options can now be used in url_for, allowing for easy manipulation of the host during link generation. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-23 09:54:42 +01:00
Ray Baxter
de829f871b fix typo 2010-11-22 22:11:56 -08:00
Santiago Pastorino
9938a3fc78 Update to Prototype 1.7 
[#6042 state:committed]
 2010-11-23 00:32:30 -02:00
Aaron Patterson
dc320d5873 skip cloning if arguments are blank 2010-11-22 17:23:37 -08:00
Aaron Patterson
4ece7e06fd removing space error 2010-11-22 17:06:55 -08:00
Aaron Patterson
4d31ee1e0e removing unused variables 2010-11-22 16:14:37 -08:00
Aaron Patterson
e83d15376d adding a test for the runner module [#6027 state:resolved] 2010-11-22 15:57:03 -08:00
Aaron Patterson
4395d493c5 sort lists before comparing them 2010-11-22 15:51:29 -08:00
Sven Fuchs
5c86286dd6 add respond_to? to ActionDispatch::Integration::Runner 
since Runner uses method_missing to delegate to the integration session it also should define respond_to? accordingly
 2010-11-22 15:42:28 -08:00
Alex Rothenberg
66c09372f3 Removed ids_in_list_limit in favor of in_clause_length defined in database_limits.rb 2010-11-23 06:43:18 +08:00
Neeraj Singh
5debc65c35 Merge branch 'master' of github.com:lifo/docrails 2010-11-22 17:32:27 -05:00
Neeraj Singh
1c68e55ae5 Revert "unscoped takes care of named_scopes too" 
This reverts commit 126fbd7ed8.
 2010-11-22 17:32:15 -05:00
Neeraj Singh
21fd93cedd make test more resilient to future changes by not 
testing the count and not testing the internal value
of the registered mime type.

Ideally all mime type registration should be cleaned up
in teardown.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:15 +01:00
Neeraj Singh
794b34306e remove select, collect and then inject with 
something better

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:15 +01:00
Neeraj Singh
c5bfc6abe4 string include method is 10x faster than creating 
a new regex object every single time

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:14 +01:00
Neeraj Singh
8154f4b816 Compile regex only once 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:14 +01:00
Neeraj Singh
cdbbf6fd6b move the mime registration code to setup so that 
it could be cleaned up on teardown.

Currently the test code
test/controller/mime_responds_test.rb impacts
test/dispatch/mime_type_test.rb.

dispatch/mime_type_test.rb runs independently fine
but when run as part of rake breaks because of
new mime types registered in
controller/mime_responds_test.rb

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:14 +01:00
Neeraj Singh
23ea19e20d rename star star to just one star 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:14 +01:00
Neeraj Singh
c9147ebfa0 cleanup Mime::LOOKUP after registering image/gif 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:14 +01:00
Neeraj Singh
4154c659fe fix test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:14 +01:00
Neeraj Singh
6f6e754bac implement code that handles text/*, appplication/*, 
and image/*

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:13 +01:00
Neeraj Singh
b798a59bd5 test for text/*, application/* and image/* 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:13 +01:00
Neeraj Singh
d04a21b362 declare regex as a constant 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:13 +01:00
Neeraj Singh
cbb2651cc0 add the fixture file 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:13 +01:00
Neeraj Singh
eb6ccc9953 do not assume that there is no space between 
leading */* and comma

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:12 +01:00
Neeraj Singh
f5fba917f8 failing test for #6022 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:12 +01:00
Neeraj Singh
61950a4b05 current code ignores http header "Accept" if it 
has ....,*/* .

It is possible to a device to send
request such that */* appear at the beginning of the
"Accept" header. This patch ensures that "Accept" header
is ignored for such cases too.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-22 23:06:12 +01:00
Santiago Pastorino
c937ddb5ce Remove unused constant 2010-11-22 19:00:05 -02:00
Santiago Pastorino
6e559168dc There's no need for ternary op here 2010-11-22 18:47:47 -02:00
Santiago Pastorino
559c4292bc Remove unneeded metaprogramming and method generation in favor of direct definition 2010-11-22 16:02:13 -02:00