Xavier Noria
85d64316a4
Merge branch 'master' of git://github.com/lifo/docrails
2010-11-23 21:59:50 +01:00
Emilio Tagua
9f35799221
Refactor && simplify count_records.
2010-11-23 09:51:07 -08:00
Emilio Tagua
e2bad8a2e7
No need to create a variables to use them once.
2010-11-24 01:37:02 +08:00
Emilio Tagua
d29d793c90
Don't create local vars.
2010-11-24 01:37:01 +08:00
Emilio Tagua
6ffe0ef55b
Avoid creating local var.
2010-11-24 01:37:01 +08:00
Emilio Tagua
63c9185b62
Remove explicit return and avoid creating local var.
2010-11-24 01:37:01 +08:00
Emilio Tagua
1b531b7ee2
Remove explicit return.
2010-11-24 01:37:00 +08:00
Emilio Tagua
b8df3a9197
Use params default.
2010-11-24 01:37:00 +08:00
Emilio Tagua
861cdc4c59
Remove unneeded local var.
2010-11-24 01:36:59 +08:00
Emilio Tagua
9c161599ac
Remove uneeded local var definition.
2010-11-24 01:36:59 +08:00
Emilio Tagua
a9e963d51d
Remove confusing parenthesis.
2010-11-24 01:36:59 +08:00
Emilio Tagua
14055ea282
No need to define a local var here.
2010-11-24 01:36:59 +08:00
Ray Baxter
de829f871b
fix typo
2010-11-22 22:11:56 -08:00
Aaron Patterson
dc320d5873
skip cloning if arguments are blank
2010-11-22 17:23:37 -08:00
Aaron Patterson
4ece7e06fd
removing space error
2010-11-22 17:06:55 -08:00
Aaron Patterson
4d31ee1e0e
removing unused variables
2010-11-22 16:14:37 -08:00
Alex Rothenberg
66c09372f3
Removed ids_in_list_limit in favor of in_clause_length defined in database_limits.rb
2010-11-23 06:43:18 +08:00
Neeraj Singh
5debc65c35
Merge branch 'master' of github.com:lifo/docrails
2010-11-22 17:32:27 -05:00
Neeraj Singh
1c68e55ae5
Revert "unscoped takes care of named_scopes too"
...
This reverts commit 126fbd7ed8
2010-11-22 17:32:15 -05:00
Neeraj Singh
c8ab3992f8
unscoped takes care of named_scopes too
2010-11-21 03:29:43 +01:00
Josh Kalderimis
8796f9a31a
removed an AR method which wasn't used internally, had no tests, and had no docs
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-11-20 19:40:32 +01:00
Josh Kalderimis
d7db6a8873
class inheritable attributes is used no more! all internal use of class inheritable has been changed to class_attribute. class inheritable attributes has been deprecated.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-11-20 19:40:29 +01:00
Aaron Patterson
938243feb9
do not require ruby-debug automatically. please require it if you have declared it as a dependency
2010-11-19 16:26:09 -08:00
Aaron Patterson
6bd93f672a
wtf vim
2010-11-19 11:48:23 -08:00
Aaron Patterson
598fc85f9e
fisting typeo, thanks @vinibaggio
2010-11-19 11:42:58 -08:00
Aaron Patterson
a4d9b1d329
adding documentation for reversible migrations
2010-11-19 11:34:42 -08:00
Aaron Patterson
db32b545da
adding Migration#change to the CHANGELOG
2010-11-19 11:20:02 -08:00
Aaron Patterson
87124457e5
fisting my spelling errors
2010-11-19 10:55:57 -08:00
Aaron Patterson
0cc6c46fe9
testing a non-invertible migration case
2010-11-19 10:50:24 -08:00
Aaron Patterson
47017bd169
invertable migrations are working
2010-11-19 10:31:03 -08:00
Aaron Patterson
6519df4157
command recorder will record commands sent to a delegate object
2010-11-19 10:24:16 -08:00
Aaron Patterson
6dbbfae563
adding invertable migration test
2010-11-19 10:24:16 -08:00
Aaron Patterson
0d7410faab
updating documentation
2010-11-19 10:24:16 -08:00
Aaron Patterson
96b50a0392
IrreversibleMigration is raised if we cannot invert the command
2010-11-19 10:24:15 -08:00
Aaron Patterson
b29a24bb6f
commands are reversed
2010-11-19 10:24:15 -08:00
Aaron Patterson
5d93900dc6
add and remove timestamps can be inverted
2010-11-19 10:24:15 -08:00
Aaron Patterson
24b637a80f
inverting add_index
2010-11-19 10:24:15 -08:00
Aaron Patterson
843e319f78
partial implementation of the command recorder
2010-11-19 10:24:15 -08:00
Aaron Patterson
24174d1b3a
this return value is not used, so stop returning it
2010-11-19 10:23:13 -08:00
Aaron Patterson
9280fbf795
instantiate the delegate object after initialize is defined so that our initialize method actually gets called
2010-11-19 10:14:13 -08:00
Aaron Patterson
07a74f196d
connection is set from the connection pool during migrations
2010-11-18 15:53:59 -08:00
Aaron Patterson
e107dcca6b
testing multiple ORd queries
2010-11-18 13:39:57 -08:00
Aaron Patterson
26923756fb
removing space errors
2010-11-18 10:01:29 -08:00
Alex Rothenberg
c5a284f8eb
Adapters can specify maximum number of ids they support in a list of expressions
...
(default is nil meaning unlimited but Oracle imposes a limit of 1000)
Limit is used to make multiple queries when preloading associated has_many or habtm records
2010-11-18 09:59:52 -08:00
Neeraj Singh
126fbd7ed8
unscoped takes care of named_scopes too
2010-11-17 21:46:55 -05:00
Aaron Patterson
80d9b724c3
group can be done by left side only
2010-11-17 17:28:40 -08:00
Santiago Pastorino
c6bfd6802a
When use where more than once on the same column, relation doesn't do an 'or' or 'in' with the values
2010-11-17 17:15:25 -08:00
Aaron Patterson
00693209ec
collapsing same table / column WHERE clauses to be OR [ #4598 state:resolved]
2010-11-17 17:10:50 -08:00
Aaron Patterson
56c5820458
use shorter form for sql literals
2010-11-17 16:15:52 -08:00
Jon Leighton
fe42c00ac3
Fix bug with 0bb85ed9ff which missed out a fixtures declaration in cascaded_eager_loading_test.rb
2010-11-17 15:52:18 -08:00
