Commit Graph

25810 Commits

Author SHA1 Message Date
Vijay Dev
fdbc4e5f4e Merge branch 'master' of github.com:lifo/docrails 2011-11-05 20:45:11 +05:30
Vijay Dev
09298e4257 Revert "outline two ways to invoke a custom active model validator"
This reverts commit d163d3bf7e.

Reason: The alternate approach can be documented in the guide and
not disrupt the existing flow in the readme.
2011-11-05 20:43:04 +05:30
Vijay Dev
53f61acdca Revert "make the inline text a comment in the code block"
This reverts commit 36a5f48f93.

Reason: Editing .gitignore in docrails is not allowed. Docrails is meant
only for documentation.
2011-11-05 20:38:07 +05:30
Jon Leighton
2751e213d8 Merge pull request #3529 from vjebelev/ar_ordered_indexes2
AR changes to support creating ordered (asc, desc) indexes
2011-11-05 08:03:19 -07:00
Florian Walch
bcd25e7576 Fixed after_initialize/after_find guide
Defining after_initialize and after_find as ordinary methods like documented
in the guide doesn't work with Rails 3.1.1; now macro-style is used here, too.
2011-11-05 13:34:01 +01:00
Vlad Jebelev
69dcd45aea AR changes to support creating ordered (asc, desc) indexes 2011-11-04 15:45:24 -05:00
Vijay Dev
cb06727b6c add tests for the case where size is explicitly passed to number_field helper 2011-11-04 22:32:40 +05:30
Jon Leighton
76dedf0232 Merge pull request #3517 from arunagw/test_fix_activerecord
Fix test as one more has_many added
2011-11-04 07:04:43 -07:00
Arun Agrawal
6da558660c Fix test as one more has_many added 2011-11-04 19:30:59 +05:30
Jon Leighton
0fcf8bfbe9 Merge pull request #3516 from cesario/fix_gemspec
Synchronize the gemspecs since CHANGELOG has been renamed to CHANGELOG.md
2011-11-04 06:54:32 -07:00
Franck Verrot
1679aa56f3 Synchronize the gemspecs since CHANGELOG has been renamed to CHANGELOG.md 2011-11-04 14:46:39 +01:00
Jon Leighton
281272ad36 Convert CHANGELOGs to Markdown format.
Reasons:

 * Markdown reads well as plain text, but can also be formatted.
 * It will make it easier for people to read on the web as Github
   formats the Markdown nicely.
 * It will encourage a level of consistency when people are writing
   CHANGELOG entries.

The script used to perform the conversion is at
https://gist.github.com/1339263
2011-11-04 12:55:17 +00:00
Jon Leighton
e6cc2ea201 Allow the :class_name option for associations to take a symbol.
This is to avoid confusing newbies, and to be consistent with the fact
that other options like :foreign_key already allow a symbol or a string.
2011-11-04 11:17:56 +00:00
José Valim
2c67845271 Merge pull request #3514 from waseem/remove_size_attribute_from_number_field
Remove 'size' attribute from number_field form helper fixes #3454
2011-11-04 03:31:39 -07:00
Aaron Patterson
0e407a9041 Merge pull request #1163 from amatsuda/sexier_migration_31
Sexier migrations
2011-11-04 03:29:59 -07:00
Karthik Muthupalaniappan
36a5f48f93 make the inline text a comment in the code block 2011-11-04 15:22:50 +05:30
Karthik Muthupalaniappan
d163d3bf7e outline two ways to invoke a custom active model validator 2011-11-04 15:18:37 +05:30
Waseem Ahmad
56207a3f01 Remove 'size' attribute from number_field form helper fixes #3454
f.number_field generates <input type="number", size="30"../> which is
invalid HTML5. See: http://dev.w3.org/html5/spec/Overview.html#number-state
2011-11-04 15:03:02 +05:30
Jeremy Kemper
533a9f84b0 Merge pull request #3507 from jmazzi/issue-3503
Preserve SELECT columns on the COUNT for finder_sql when possible
2011-11-03 21:17:15 -07:00
Henrik Hodne
8611f14caf Added bundle exec to rake test.
This is in response to rails/rails#3504.
2011-11-03 22:19:49 +01:00
Jon Leighton
b5f908a7ad Stub find_template so that when handle_render_error is called in ActionView::Template, we get to see the actual underlying error rather than a NoMethodError.
This shows an encoding bug on Ruby 1.9.3.
2011-11-03 19:08:09 +00:00
Jon Leighton
d486103570 Fix #3271.
Building the conditions of a nested through association could
potentially modify the conditions of the through and/or source
association.

This is a Bad Thing.
2011-11-03 15:12:08 +00:00
Jon Leighton
567d454d99 Memoize through association 2011-11-03 13:24:39 +00:00
Jon Leighton
19b2a5f2bd Remove all revelant through records.
If a record is removed from a has_many :through, all of the join records
relating to that record should also be removed from the through
association's target.

(Previously the records were removed in the database, but only one was
removed from the in-memory target array.)
2011-11-03 13:13:13 +00:00
Jon Leighton
71bc921ec8 Fix adding multiple instances of the same record to a has_many :through.
Fixes #3425.
2011-11-03 12:39:05 +00:00
Jon Leighton
b4b178f7e9 Fix #3247.
Fixes creating records in a through association with a polymorphic source
type.
2011-11-03 10:23:42 +00:00
Alexey Vakhov
a8468731f7 Fix javascript_include_tag examples in documentation 2011-11-03 09:02:11 +04:00
Alexey Vakhov
7463317115 Fix small typos in routing docs 2011-11-03 08:43:28 +04:00
Vijay Dev
bc09a11a66 minor edit 2011-11-02 23:34:27 +05:30
Vijay Dev
b3c1cfa277 minor edits in AR validations guide 2011-11-02 23:01:30 +05:30
José Valim
982a0f37f5 Merge pull request #3494 from sinisterchipmunk/usage-erb
treat USAGE as an ERB template
2011-11-02 06:41:46 -07:00
Colin MacKenzie IV
5745a5e85e treat USAGE as an ERB template 2011-11-02 09:00:18 -04:00
Jeremy Kemper
836b620850 Revert "Disable 1.9.3 builds until upgraded from -preview1 to -rc1"
This reverts commit 8a6acc17bb.
2011-11-01 17:41:37 -07:00
Vijay Dev
9aa880f2e8 use relative urls for linking to sections in the guides 2011-11-02 00:37:18 +05:30
juandebravo
ed4bde5a09 Fix wrong link in initialization doc 2011-11-01 20:45:00 +02:00
Aviv Ben-Yosef
702aecb126 Fix typo in Dispatcher#controller documentation 2011-11-01 08:59:20 +02:00
Alexey Vakhov
5f4550889d Fix typo in constraints method documentation 2011-11-01 08:55:03 +04:00
Ryan Bigg
e28bd7b226 [config guide] mention that config methods are to be called on Railtie subclasses 2011-11-01 11:18:17 +11:00
Ryan Bigg
dfdbbe059f [engines guide] add 'General engine configuration' section 2011-11-01 11:15:14 +11:00
Aaron Patterson
62a86748ae this should never return nil, so no use for "try" 2011-10-31 15:17:16 -04:00
Christopher Meiklejohn
6cbe4223a7 Ensure that the format isn't applied twice to the cache key, else it becomes impossible to target with expire_action. 2011-10-31 15:10:07 -04:00
Vijay Dev
1afe269a4a assert_match takes a regexp and a string in that order 2011-10-31 19:01:03 +05:30
José Valim
2407a7ad8d Merge pull request #3477 from rud/stable-migrations-version-order-rebased
dump_schema_information: explicitly order inserts into schema_migrations
2011-10-31 03:01:02 -07:00
Laust Rud Jacobsen
ff9c2799c1 dump_schema_information: explicitly order inserts into schema_migrations table
This change reduces churn in the db/development_structure.sql file when using :sql as
active_record.schema_format, and makes comparing diffs much easier.

Test ensures the output SQL-statements are lexically ordered by version.
2011-10-31 10:36:13 +01:00
Alexey Vakhov
d106b34bd5 Update routing guides, root route should be at the top of the file 2011-10-31 10:36:38 +04:00
Gonçalo Silva
2d337ef080 Fix typo on the performance test guide 2011-10-30 18:34:49 -02:00
Santiago Pastorino
818bf1da0e Merge pull request #3469 from kennyj/dont_use_old_code
Refactor ActiveSupport::Cache::FileStore.
2011-10-30 09:42:39 -07:00
kennyj
7670a5187d Refactor ActiveSupport::Cache::FileStore. used method and deleted duplicate code. 2011-10-30 21:50:17 +09:00
Vijay Dev
3e6ecfb454 Merge pull request #3468 from kennyj/fix_a_document_for_compress_limit
fix a document for :compress_threshold. DEFAULT_COMPRESS_LIMIT is 16K.
2011-10-30 03:29:18 -07:00
kennyj
38da6249f0 fix a document for :compress_threshold. DEFAULT_COMPRESS_LIMIT is 16K. 2011-10-30 19:18:23 +09:00