github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,995 Commits 34 Branches 105 Tags
ffdda4ddfb76fec92faea714f03a37baf75351ef
Commit Graph

17995 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Patterson
ffdda4ddfb use blank? instead of present?, mark SQL literals as SQL literals 
Conflicts:

	activerecord/lib/active_record/relation/query_methods.rb
 2010-08-25 05:17:49 -07:00
Aaron Patterson
b28cafe01a no need to send on a public method 2010-08-25 05:17:49 -07:00
Aaron Patterson
ce7c2f72f4 refactor select { is_a? } to grep() 2010-08-25 05:17:49 -07:00
Aaron Patterson
e1e7122271 mark SQL literals as SQL literals 2010-08-25 05:17:49 -07:00
Jakub Suder
4f945e97e5 better callstack reporting in deprecation messages 
now the reported line is the first line in the stack
that's outside Rails, which is the one that actually
caused the problem in the first place

[#5231 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-25 07:23:50 -03:00
Andrew White
0b9357d401 Remove rails info route from rake routes output [#5452 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-25 07:22:20 -03:00
Mikel Lindsaar
c1b49f1e18 Make ActiveResource::InvalidRequestError more user friendly 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-08-25 10:00:37 +02:00
Andrew White
1847d33b4b Use nested scope for routes defined at the :resources scope level (as in Rails 2.3) 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 21:15:13 -03:00
Xavier Noria
3ac6646d6f :nodoc:s #unscoped until its behavior is more clear, now sometimes works, sometimes not 2010-08-25 01:05:51 +02:00
Xavier Noria
a820bd9df6 edit pass to a recent doc patch 2010-08-25 00:22:53 +02:00
Xavier Noria
036f090df1 Merge remote branch 'docrails/master' 2010-08-25 00:17:02 +02:00
José Valim
80e1f730a2 Allow format to be skipped. This is used internally by mount. 2010-08-24 16:58:32 -03:00
José Valim
e197d6f34b Finally fix the bug where symbols and strings were not having the same behavior in the router. 
If you were using symbols before for methods like match/get/post/put/delete, it is likely that this commit will break your routes.
Everything should behave the same if you are using strings, if not, please open up a ticket.
 2010-08-24 16:58:25 -03:00
José Valim
4a90ecb3ad Ensure shortcuts inside resources also generates helpers. 2010-08-24 16:58:12 -03:00
José Valim
edba51cf33 Hide internal apps from rake routes [#5443 state:resolved] 2010-08-24 13:22:48 -03:00
Andrew White
1a6c81c4f9 Revert "Use symbols when specifying custom resource actions" 
This reverts commit 02aabbd19e.
 2010-08-24 17:12:02 +01:00
José Valim
2916521da8 Fix how routes inside namespaces are generated. 2010-08-24 13:05:29 -03:00
Santiago Pastorino
4df19b3f27 Allow actions which start with A-Za-z_ only 2010-08-24 12:43:43 -03:00
Aaron Suggs
3519d61af9 Bump rake dependency to 0.8.4. [#5279 state:resolved] 
This rake version adds the Rake::RDocTask#rdoc_task_name method, used in
railties/lib/rails/tasks/documentation.rake

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 11:57:30 -03:00
Neeraj Singh
747e0744dd @user.touch should not fail if User does not have updated_at/updated_on column. 
[#5439 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 11:24:32 -03:00
Andrew White
11f6179f55 Reset symbolized path parameters when a test request is recycled [#5437 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 11:24:32 -03:00
José Valim
542878304d Ensure prefix in routes are generated properly. 2010-08-24 11:24:31 -03:00
Neeraj Singh
f460de1d23 touch operationg if used along with belongs_to will also be invoked on associated objects 2010-08-24 10:21:58 -04:00
Joost Baaij
20333be581 fix broken relative links [#5415 state:committed] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-08-24 16:20:32 +02:00
José Valim
6ef60bd9ff Ensure timestamps are not generated when explicitly set to false [#5440 state:resolved] 2010-08-24 10:45:16 -03:00
Wincent Colaiuta
7d71b785a9 Add test case for ActiveRecord::Base.record_timestamps = false 
This is a failing test case for Lighthouse ticket #5440:

  https://rails.lighthouseapp.com/projects/8994/tickets/5440

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 10:32:45 -03:00
José Valim
b4f304b7b6 Fix a bug where symbols and strings were not behaving the same in the router. [#5431 state:resolved] 2010-08-24 10:26:25 -03:00
Andrew White
2fb0cbec02 When custom resource actions are specified using strings add the default name and action if the string is a valid ruby method name. 
[#5431 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 10:26:25 -03:00
Krekoten' Marjan
a0284791df Fix test of generated Gemfile with mysql selected as DB driver 
[#5435 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-24 09:38:20 -03:00
Andrew White
02aabbd19e Use symbols when specifying custom resource actions 2010-08-24 07:06:53 +01:00
Trevor Turk
cbacc9700e Note about how to exit the console in the Getting Started guide 2010-08-24 00:13:33 -05:00
David Heinemeier Hansson
21b1f29720 Master is now targeting 3.1.0.beta 2010-08-23 21:44:57 -05:00
David Heinemeier Hansson
96f3bcb816 Master is now targeting 3.1.0.beta 2010-08-23 21:43:47 -05:00
David Heinemeier Hansson
0d657132b0 mysql db defaults to mysql2 gem 2010-08-23 21:41:16 -05:00
David Heinemeier Hansson
3409f2c691 Depend on latest arel RC 2010-08-23 21:27:41 -05:00
Santiago Pastorino
363fe5faf9 Point guides to bundler 1.0.0.rc.6 2010-08-23 23:26:25 -03:00
David Heinemeier Hansson
b983145dfc Depend on latest Bundler RC 2010-08-23 21:24:22 -05:00
David Heinemeier Hansson
eb873f7133 Prefer the mysql2 gem for MySQL database.ymls 2010-08-23 21:19:53 -05:00
Santiago Pastorino
bb75c33754 Config is deprecated on 1.8.8 and 1.9.3 use RbConfig 2010-08-23 23:10:36 -03:00
Aaron Patterson
6f4d100761 marking sql literals as sql literals 2010-08-23 18:48:29 -07:00
Aaron Patterson
ecbdec115b making variable names a little more clear 2010-08-23 18:48:28 -07:00
José Valim
b6e28cea8c Update CHANGELOG for ActionPack. 2010-08-23 21:54:19 -03:00
Aaron Patterson
2e8e6e581f we should mark sql strings as sql literals 2010-08-23 14:28:15 -07:00
Aaron Patterson
5931a1dbd3 sql literal strings should be marked as sql literal strings 2010-08-23 13:57:22 -07:00
Aaron Patterson
ee9e1570be we should mark strings as SQL Literal values 2010-08-23 13:30:12 -07:00
Brian Lopez
6d796a71d2 mysql2 adapter is being maintained in the mysql2 gem itself 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-23 15:59:51 -03:00
Brian Lopez
bde3d7fbaf no need to depend on mysql2 master anymore 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-23 15:50:26 -03:00
Raimonds Simanovskis
2fc29524e1 use database from ARUNIT_DB_NAME environment variable when running tests on Oracle 2010-08-23 10:50:21 -07:00
Neeraj Singh
13ebf69ae4 unscoped does not work when chained with named_scope 2010-08-23 05:45:11 -04:00
Xavier Noria
3538dc0d7a removes words moved in previous edit of the generator generator USAGE 2010-08-23 09:44:56 +02:00