10265 Commits

Author SHA1 Message Date
David Heinemeier Hansson
d19e8f412f Performance speedup for ActionController (closes #4174) [Stefan Kaes] Includes caching of filter chains -- be on the lookout for problems with that!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 04:01:10 +00:00
David Heinemeier Hansson
324ece25e9 Rolled back #2176 because it destroyed performance [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3988 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 03:57:13 +00:00
Rick Olson
afde9943ea fix indifferent hash. The lambdas were acting funny in a running rails app. closes #2176
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3987 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 03:39:46 +00:00
David Heinemeier Hansson
4e7c6f58fb Added option to String#camelize to generate lower-cased camel case by passing in :lower, like "super_man".camelize(:lower) # => "superMan" [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3986 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 03:32:28 +00:00
Rick Olson
f49ba114db Add :script option to in_place_editor to support evalScripts (closes #4194) [codyfauser@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3985 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 19:40:11 +00:00
Rick Olson
a6cfb4e0e4 Fix mixed case enumerable methods in the JavaScript Collection Proxy (closes #4314) [codyfauser@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 19:38:38 +00:00
Rick Olson
9a72cd22cf Don't classify the has_one class when eager loading, it is already singular. Add tests. (closes #4117) [jonathan@bluewire.net.nz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3983 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 19:32:07 +00:00
Nicholas Seckar
48e7edc31b Reject Ruby 1.8.3 when loading Rails; extract version checking code.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3982 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 18:55:31 +00:00
Nicholas Seckar
5ff59bff82 Remove explicit loading of RailsInfo and RailsInfoController.
Move RailsInfo and RailsInfoController to Rails::Info and Rails::InfoController.
Extend load path with Railties' builtin directory to make adding support code easy.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3981 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 18:45:26 +00:00
Nicholas Seckar
b42195cdb7 Fix RailsInfoController.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 18:21:06 +00:00
Rick Olson
753010ac39 add support for COUNT(DISTINCT id) queries in sqlite2 (closes #4300) [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3979 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 17:42:51 +00:00
Rick Olson
8196e8e723 skip count_by_sql test using COUNT(DISTINCT) for sqlite2 only
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 17:19:17 +00:00
David Heinemeier Hansson
46106755b7 Fix boolean test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 17:06:53 +00:00
Nicholas Seckar
ab9f324423 Undo accidental escaping for mail_to; add regression test. Fix incorrect credit in changelog. Closes #4202.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 17:03:02 +00:00
David Heinemeier Hansson
83fa114e51 Rails is not compatible with Ruby 1.8.3, explicitly prevent usage [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 16:55:16 +00:00
Rick Olson
ea25e246e0 Quit ignoring default :include options in has_many :through calls [Mark James]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 16:13:52 +00:00
Rick Olson
fcd4c9529c Allow has_many :through associations to find the source association by setting a custom class (closes #4307) [jonathan@bluewire.net.nz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 07:14:48 +00:00
David Heinemeier Hansson
8ea1fadcbe If RAW_POST_DATA was set explicitly, use that (closes #4281)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 06:42:29 +00:00
David Heinemeier Hansson
5f4f4b03f2 Fix for destroying migrations made when generating a model (closes #4246) [tomtoday@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 06:06:20 +00:00
Rick Olson
639ce3b21d Remember kiddies, Dir[] uses Dir#glob, not a Regexp
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 04:30:10 +00:00
Rick Olson
891a962a19 Added nicer message for assert_redirected_to (closes #4294) [court3nay, Chris McGrath]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 03:50:14 +00:00
Rick Olson
9038303af0 forgot to save changelog... doh
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 03:08:04 +00:00
Rick Olson
9412c0531d Eager Loading support added for has_many :through => :has_many associations (see below). [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 03:05:21 +00:00
David Heinemeier Hansson
3f77a04cb5 Only run migrations that look like migrations
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 02:38:35 +00:00
David Heinemeier Hansson
389a667664 Small pgsql fixes (closes #4083) [pergesu@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3965 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 02:21:58 +00:00
Rick Olson
0925c6b6a0 Allow has_many :through to work on has_many associations (closes #3864) [sco@scottraymond.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3964 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 02:01:40 +00:00
David Heinemeier Hansson
8463cd646e Fixed rails:freeze:gems for Windows (closes #3274) [paul@paulbutcher.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 01:34:14 +00:00
Rick Olson
eb1ae042bd add ticket # to changeset
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3962 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 00:55:56 +00:00
Rick Olson
57af961a80 Raise error when trying to select many polymorphic objects with has_many :through or :include (closes #4226) [josh@hasmanythrough.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 00:53:24 +00:00
Jamis Buck
49efa02b9e Nil charset caused subject line to be improperly quoted in implicitly multipart messages (closes #2662)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 00:18:50 +00:00
Jamis Buck
db0e8ff1c3 Parse content-type apart before using it so that sub-parts of the header can be set correctly (closes #2918)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 23:53:07 +00:00
Rick Olson
9c9069a675 Fixed has_many :through to include :conditions set on the :through association. closes #4020 [jonathan@bluewire.net.nz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 23:14:31 +00:00
Jamis Buck
a46214c4f9 Make custom headers work in subparts (closes #4034)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3956 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 23:06:25 +00:00
Jamis Buck
797de4d057 Use the full template file name for implicitly selected templates, instead of requiring AV to try to detect it (which is broken for this use case) (closes #4297)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3955 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 22:55:20 +00:00
Rick Olson
fbd1e01bd6 Fix that has_many :through honors the foreign key set by the belongs_to association in the join model (closes #4259) [andylien@gmail.com / Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 22:38:49 +00:00
Nicholas Seckar
1e7ce13b37 Change url_for to escape the resulting URLs when called from a view. Closes #4202
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3953 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 22:36:52 +00:00
David Heinemeier Hansson
eba58b2c12 Date in iso8601 should just be a to_s alias
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:46:49 +00:00
David Heinemeier Hansson
7581193678 Added more tests to validates_format_of (closes #3142) [jp.bougie@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:44:08 +00:00
David Heinemeier Hansson
2de765e850 Dates should be able to go xmlschema too [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3950 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:37:10 +00:00
David Heinemeier Hansson
9db8f3e57a SQL Server adapter gets some love (closes #4298) [rtomayko@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:27:40 +00:00
David Heinemeier Hansson
c0ad3b6b68 Added test for Accept header for xml_http_request calls in functional tests (closes #4222) [agkr@pobox.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:23:14 +00:00
David Heinemeier Hansson
f6786f8dcc Make generation of namespaced models produce proper migrations #4219 [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:20:29 +00:00
David Heinemeier Hansson
74f02246ca Doc fix (closes #4210) [Caio Chassot ]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:19:01 +00:00
David Heinemeier Hansson
a79344130b Doc fix (closes #4209) [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:18:06 +00:00
David Heinemeier Hansson
cc6e8ae57a Removed XML argument style for respond_to, so type.xml(object.to_xml) no longer works -- it wasnt worth the exception
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:17:14 +00:00
Jamis Buck
3257a4b9b0 Fix incorrect mysql column type (requires AR test DB to be rebuilt) (closes #4299)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 20:33:00 +00:00
David Heinemeier Hansson
69fbdb9afb use cleanpath of config file in lighttpd server script (closes #4203) [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 20:27:48 +00:00
David Heinemeier Hansson
e18fad6c43 Update lingering uses of deprecated association dependency options (closes #4169) [coffe2code]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 20:25:50 +00:00
David Heinemeier Hansson
6c67905c1c Fixed that eager loading from belongs_to would cause the association to be double-singularized (closes #4117) [jonathan@bluewire.net.nz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 20:20:30 +00:00
David Heinemeier Hansson
f22f352ee3 Added easy support for testing file uploads with fixture_file_upload (closes #4105) [turnip@turnipspatch.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3939 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 20:10:52 +00:00