10265 Commits

Author SHA1 Message Date
David Heinemeier Hansson
8bf987140a Added 'port open?' check to the spawner when running in repeat mode so we don't needlessly boot the dispatcher if the port is already in use anyway #4089 [guy.naor@famundo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 19:21:54 +00:00
David Heinemeier Hansson
3dc7f76037 Fixed UrlHelper#current_page? to behave even when url-escaped entities are present (closes #3929) [jeremy@planetargon.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 19:02:23 +00:00
Jamis Buck
79a82e3a97 Make sure xml_simple requests don't blow up if an empty request body is recieved
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 18:56:19 +00:00
Rick Olson
50103b86e6 fixed has_many :conditions sanitizing (closes #4278) [hakuja@hakuja.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 18:01:50 +00:00
Jamis Buck
b2122159b1 fix broken respond_to test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 17:15:22 +00:00
David Heinemeier Hansson
aced2863f0 Fix the detach option for lighttp (closes #4097) [schultzr@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 17:00:40 +00:00
David Heinemeier Hansson
416385a09d Added OpenBase database adapter that builds on top of the http://www.spice-of-life.net/ruby-openbase/ driver. All functionality except LIMIT/OFFSET is supported (closes #3528) [derrickspell@cdmplus.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3932 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:50:25 +00:00
Nicholas Seckar
240213177e Add ability for relative_url_root to be specified via an environment variable RAILS_RELATIVE_URL_ROOT. Closes #4243.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:45:40 +00:00
David Heinemeier Hansson
fddd33b81e Do not include .svn files in file distro (closes #3195) [jamie@dang.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:32:11 +00:00
David Heinemeier Hansson
f38476ddd2 Styling
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:28:40 +00:00
David Heinemeier Hansson
129a159d12 Fixed link_to "somewhere", :post => true to produce valid XHTML by using the parentnode instead of document.body for the instant form (closes #3007) [Bob Silva]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3928 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:25:11 +00:00
David Heinemeier Hansson
c2fb8ca393 Just use a normal update on the indifferent hash
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3927 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:11:21 +00:00
David Heinemeier Hansson
7bfca7e717 Added :function option to PrototypeHelper#observe_field/observe_form that allows you to call a function instead of submitting an ajax call as the trigger (closes #4268) [jonathan@daikini.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3926 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:08:09 +00:00
David Heinemeier Hansson
8b8a30dd0a Fixed the to_xml case (closes #4201) [twoggle@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3925 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 15:28:46 +00:00
Jamis Buck
9d7de52c2d Add Integration::Session.accept for setting the HTTP Accept header to use (defaults to FF 1.5 value)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3924 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 15:09:27 +00:00
Jamis Buck
36ea93e4b9 rename 'integration_test.rb' -> 'integration.rb'
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3923 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 14:27:36 +00:00
Rick Olson
ddce0ae525 remove space
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3922 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 07:36:50 +00:00
Rick Olson
229c0f4367 Rework table aliasing to account for truncated table aliases. Add smarter table aliasing when doing eager loading of STI associations. This allows you to use the association name in the order/where clause. [Jonathan Viney / Rick Olson] closes #4108
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3921 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 07:31:01 +00:00
David Heinemeier Hansson
f1a350a05c Testing of uncommited should test controllers too (closes #4265) [technomancy@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:47:46 +00:00
David Heinemeier Hansson
9840dc84f1 Allow for respond_to(:html, :js, :xml) (closes #4277) [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3919 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:43:37 +00:00
Jamis Buck
7e46571115 Add a test to make sure basic XML entities get unescaped properly
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:21:04 +00:00
Jamis Buck
4e0028fbab Make Mime::Type.parse consider q values (if any)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3917 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:15:28 +00:00
Rick Olson
263479b5a3 Add AbstractAdapter#table_alias_for to create table aliases according to the rules of the current adapter. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3916 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 05:43:35 +00:00
Jamis Buck
459559a8bc XML-formatted requests are typecast according to "type" attributes for :xml_simple
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 05:07:27 +00:00
Michael Koziarski
93f8bd15a1 Provide access to the underlying database connection with Adapter#raw_connection, allows the use of db-specific methods such as postgresql's lo_* . Closes #2090
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 05:03:34 +00:00
Michael Koziarski
7fdab4446a Remove broken attempts at handling columns with a a default of 'now()' in the postgresql adapter. Closes #2257
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3913 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 04:38:49 +00:00
David Heinemeier Hansson
504ab568f8 Fixed HashWithIndifferentAccess#delete to work with both symbols and strings (closes #2176) [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3912 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 04:01:44 +00:00
David Heinemeier Hansson
0555fc905c Added connection#current_database that'll return of the current database (only works in MySQL, SQL Server, and Oracle so far -- please help implement for the rest of the adapters) (closes #3663) [Tom ward]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:54:04 +00:00
David Heinemeier Hansson
df97ed5e4c Nicer error message on has_many :through when :through reflection can not be found (closes #4042) [court3nay@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3910 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:39:18 +00:00
David Heinemeier Hansson
9bd7db4a98 Fixed that Migration#execute would have the table name prefix appended to its query (closes #4110) [mark.imbriaco@pobox.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3909 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:32:38 +00:00
David Heinemeier Hansson
fe94ba1003 Added access to remote_addr in integration tests (closes #4266) [Chad Fowler]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:27:37 +00:00
David Heinemeier Hansson
c6515451dc Fix test db setup for pgsql (closes #4220) [mlaster@metavillage.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:23:34 +00:00
David Heinemeier Hansson
a2fba43ebc The style police makes an expection on acts_as_tree (closes #4168) [coffee2code]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:22:45 +00:00
David Heinemeier Hansson
ea617708c2 Added migrations support to the Sybase adapter (closes #4293) [John R. Sheets]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:02:32 +00:00
Jamis Buck
1340eb1a7e Be sure to look at array elements when dasherizing keys of a formatted request
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-17 23:15:20 +00:00
David Heinemeier Hansson
d4b27a0b36 Fix soap type registration of multidimensional arrays (closes #4232) [Kent]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-17 22:20:09 +00:00
Jamis Buck
d712310518 Make all tinyint(1) variants act like boolean in mysql (tinyint(1) unsigned, etc.)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-17 22:03:26 +00:00
Jamis Buck
795c71f2ee dasherize the root element when doing to_xml
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3901 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 20:30:01 +00:00
Rick Olson
17e1f7b354 trivial documentation patch for #pagination_links [Francois Beausoleil] closes #4258
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3899 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 06:38:08 +00:00
Rick Olson
ee1ae44e0e remove some commented-out cruft
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 06:22:30 +00:00
Rick Olson
a3502c419e Use association's :conditions when eager loading. [jeremyevans0@gmail.com] closes #4144
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3897 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 06:17:54 +00:00
Rick Olson
fd87a78710 fix AR tests for sqlite
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 05:21:40 +00:00
Rick Olson
02d34440cf Alias the has_and_belongs_to_many join table on eager includes. closes #4106 [jeremyevans0@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 04:18:12 +00:00
David Heinemeier Hansson
4e15bf787e Fixed proxy support for lighttpd (closes #3267) [stephen_purcell@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 04:16:08 +00:00
Nicholas Seckar
065b3af358 Explain thyself
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 04:09:18 +00:00
David Heinemeier Hansson
f7359342af Added protection against proxy setups treating requests as local even when they're not #3898 [stephen_purcell@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:31:40 +00:00
David Heinemeier Hansson
3a7be80f47 Change LEFT OUTER JOIN authors AS authors to LEFT OUTER JOIN authors authors so associations will work for Oracle again (closes #4231) [schoenm@earthlink.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:27:21 +00:00
Rick Olson
a0c459bca7 fix test_find_in_association_with_options test, tweak other tests affected by developer/project addition
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3890 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:24:40 +00:00
David Heinemeier Hansson
9b9a0908e5 Oracle adapter gets some love #4230 [schoenm@earthlink.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:20:46 +00:00
David Heinemeier Hansson
275ea6de49 Added TestRequest#raw_post that simulate raw_post from CgiRequest (closes #3042) [francois.beausoleil@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:15:12 +00:00