Don't charge google checkout orders with bad amounts.

2026-02-01 10:14:57 -05:00 · 2013-05-05 21:19:18 -04:00
parent 7b35405280
commit 00e86bcb8b
1 changed files with 2 additions and 0 deletions
--- a/r2/r2/controllers/ipn.py
+++ b/r2/r2/controllers/ipn.py
@@ -422,6 +422,8 @@ class IpnController(RedditController):
                        pennies = int(float(trans.find("order-total"
                                                      ).contents[0])*100)
                        months, days = months_and_days_from_pennies(pennies)
+                        if not months:
+                            raise ValueError("Bad pennies for %s" % short_sn)
                        charged = trans.find("charge-amount-notification")
                        if not charged:
                            _google_charge_and_ship(short_sn)