github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-27 07:48:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don't include X-SUP-ID if it contains \r\n.

Browse Source 
Prevents an HTTP response splitting attack.

Thanks to @nealpoole (npoole) for the report!
This commit is contained in:
Neil Williams
2011-08-28 11:26:21 -07:00
parent 06dea8a4db
commit 0828095f73
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
r2/r2/controllers/error.py
View File

@@ -179,7 +179,9 @@ class ErrorController(RedditController):
return self.send503()
elif code == 304:
if request.GET.has_key('x-sup-id'):
c.response.headers['x-sup-id'] = request.GET.get('x-sup-id')
x_sup_id = request.GET.get('x-sup-id')
if '\r\n' not in x_sup_id:
c.response.headers['x-sup-id'] = x_sup_id
return c.response
elif c.site:
return self.send404()