github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-26 23:39:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix FlairTemplateBySubredditIndex.insert logic.

Browse Source
This commit is contained in:
Logan Hanks
2011-11-03 11:31:15 -07:00
parent 4eaaf5d451
commit 0911df4160
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
r2/r2/models/flair.py
View File

@@ -213,18 +213,18 @@ class FlairTemplateBySubredditIndex(tdb_cassandra.Thing):
A position value of None means to simply append.
"""
keys = self._index_keys()
ft_ids = list(self)
if position is None:
position = len(keys)
if position < 0 or position > len(keys):
position = len(ft_ids)
if position < 0 or position > len(ft_ids):
raise IndexError(position)
ft_ids.insert(position, ft_id)
# Move items after position to the right by one.
for i in xrange(len(keys), position, -1):
setattr(self, self._make_index_key(i), getattr(self, keys[i - 1]))
# Assign to position and commit.
setattr(self, self._make_index_key(position), ft_id)
# Rewrite ALL the things.
for k in self._index_keys():
del self[k]
for i, ft_id in enumerate(ft_ids):
setattr(self, self._make_index_key(i), ft_id)
self._commit()
def delete_by_id(self, ft_id):