github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-04-27 03:00:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Try to deal with non-W3C compliant popup blockers

Browse Source
This commit is contained in:
Jordan Milne
2014-12-19 03:05:40 -04:00
parent 95a2d12aab
commit 1e660d07f7
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
r2/r2/public/static/js/ui.js
View File

@@ -42,14 +42,22 @@ r.ui.init = function() {
var isWebLink = _.contains(['http:', 'https:'], this.protocol);
if (this.href && isWebLink && !r.utils.onIEMobile()) {
var w = window.open('', '_blank');
w.opener = null;
w.location.href = href;
// suppress normal link opening behaviour
e.preventDefault();
return false;
// some popup blockers appear to return null for
// `window.open` even inside click handlers.
if (w !== null) {
// try to nullify `window.opener` so the new tab can't
// navigate us
w.opener = null;
w.location.href = this.href;
// suppress normal link opening behaviour
e.preventDefault();
return false;
}
}
this.target = "_blank";
}
return true; // continue bubbling
})
}