github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-26 23:39:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

promote: create Decimal from string not float.

Browse Source 
Creating a Decimal from a float results in precision loss.
This commit is contained in:
Brian Simpson
2013-10-18 13:49:48 -04:00
parent 38c8faf140
commit 2af8fe6703
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
r2/r2/lib/promote.py
View File

@@ -862,7 +862,7 @@ def get_refund_amount(camp, billable):
existing_refund = getattr(camp, 'refund_amount', 0.)
charge = camp.bid - existing_refund
refund_amount = charge - billable
refund_amount = Decimal(refund_amount).quantize(Decimal('.01'),
refund_amount = Decimal(str(refund_amount)).quantize(Decimal('.01'),
rounding=ROUND_UP)
return max(float(refund_amount), 0.)
@@ -991,7 +991,7 @@ def get_billable_amount(camp, impressions):
# pre-CPM campaigns are charged in full regardless of impressions
billable_amount = camp.bid
billable_amount = Decimal(billable_amount).quantize(Decimal('.01'),
billable_amount = Decimal(str(billable_amount)).quantize(Decimal('.01'),
rounding=ROUND_DOWN)
return float(billable_amount)