mirror of
https://github.com/reddit-archive/reddit.git
synced 2026-01-29 08:48:18 -05:00
Fix duplicate bubble race condition when hiding.
While a bubble is animating the hide, it's possible to show another bubble within a bubble group. Then, when the hide animation completes, `hideNow` would be called, clobbering the group state set by the newly shown bubble.
This commit is contained in:
@@ -234,7 +234,7 @@ r.ui.Bubble = Backbone.View.extend({
|
||||
|
||||
hideNow: function() {
|
||||
this.cancelTimeout()
|
||||
if (this.options.group) {
|
||||
if (this.options.group && this.options.group.current == this) {
|
||||
this.options.group.current = null
|
||||
}
|
||||
this.$el.hide()
|
||||
|
||||
Reference in New Issue
Block a user