github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-28 08:17:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

converted find_parents() in comment_tree from a recursive algorithm to an iterative one to fix a bug when adding comments to really long threads

Browse Source
This commit is contained in:
spez
2008-12-03 13:58:32 -05:00
parent 54c1055c62
commit 3600220208
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
r2/r2/lib/comment_tree.py
View File

@@ -55,16 +55,19 @@ def add_comment_nolock(comment):
num_children[cm_id] = 0
#dfs to find the list of parents for the new comment
def find_parents(top = None):
children = comment_tree.get(top, ())
if cm_id in children:
return []
else:
for c in children:
parents = find_parents(c)
if parents is not None:
parents.append(c)
return parents
def find_parents():
stack = [cid for cid in comment_tree[None]]
parents = []
while stack:
cur_cm = stack.pop()
if cur_cm == cm_id:
return parents
elif comment_tree.has_key(cur_cm):
#make cur_cm the end of the parents list
parents = parents[:depth[cur_cm]] + [cur_cm]
for child in comment_tree[cur_cm]:
stack.append(child)
#if this comment had a parent, find the parent's parents
if p_id: