github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-28 16:28:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

stats: Do not send template timings.

Browse Source 
They will be kept locally for the admin bar timing logs.
This commit is contained in:
Max Goodman
2013-03-15 14:44:29 -07:00
parent 6101c1ad13
commit 4e0e183ebf
2 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
r2/r2/lib/stats.py
View File

@@ -50,10 +50,11 @@ class TimingStatBuffer:
self.data = collections.defaultdict(complex)
self.log = threading.local()
def record(self, key, start, end):
# Add to the total time and total count with a single complex value,
# so as to avoid inconsistency from a poorly timed context switch.
self.data[key] += (end - start) + 1j
def record(self, key, start, end, publish=True):
if publish:
# Add to the total time and total count with a single complex value,
# so as to avoid inconsistency from a poorly timed context switch.
self.data[key] += (end - start) + 1j
if getattr(self.log, 'timings', None) is not None:
self.log.timings.append(self.Timing(key, start, end))
@@ -198,9 +199,10 @@ class Counter:
class Timer:
_time = time.time
def __init__(self, client, name):
def __init__(self, client, name, publish=True):
self.client = client
self.name = name
self.publish = publish
self._start = None
self._last = None
self._stop = None
@@ -220,7 +222,8 @@ class Timer:
def send(self, subname, start, end):
name = _get_stat_name(self.name, subname)
self.client.timing_stats.record(name, start, end)
self.client.timing_stats.record(name, start, end,
publish=self.publish)
def start(self):
self._last = self._start = self._time()
@@ -253,8 +256,8 @@ class Stats:
def __init__(self, addr, sample_rate):
self.client = StatsdClient(addr, sample_rate)
def get_timer(self, name):
return Timer(self.client, name)
def get_timer(self, name, publish=True):
return Timer(self.client, name, publish)
def transact(self, action, start, end):
timer = self.get_timer('service_time')

6
r2/r2/lib/wrapped.pyx
View File

@@ -207,7 +207,8 @@ class Templated(object):
if self.render_class_name in g.timed_templates:
timer = g.stats.get_timer('render.%s.nocache' %
self.render_class_name)
self.render_class_name,
publish=False)
timer.start()
else:
timer = None
@@ -259,7 +260,8 @@ class Templated(object):
and will substituted last.
"""
from pylons import c, g
timer = g.stats.get_timer('render.%s.cached' % self.render_class_name)
timer = g.stats.get_timer('render.%s.cached' % self.render_class_name,
publish=False)
timer.start()
style = style or c.render_style or 'html'