github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-04-05 03:00:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

make_daily_promotions only runs for current time.

Browse Source 
Specifying an offset would cause the wrong campaigns to go live.
This commit is contained in:
Brian Simpson
2013-11-03 11:04:49 -05:00
parent 534e7e5d39
commit 5caf5502dd
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
r2/r2/lib/promote.py
View File

@@ -603,14 +603,14 @@ def promote_link(link, campaign):
emailer.live_promo(link)
def make_daily_promotions(offset=0):
def make_daily_promotions():
# charge campaigns so they can go live
charge_pending(offset=0)
charge_pending(offset=1)
# promote links and record ids of promoted links
link_ids = set()
for campaign, link in get_scheduled_promos(offset):
for campaign, link in get_scheduled_promos(offset=0):
link_ids.add(link._id)
promote_link(link, campaign)
@@ -622,8 +622,8 @@ def make_daily_promotions(offset=0):
emailer.finished_promo(link)
_mark_promos_updated()
finalize_completed_campaigns(daysago=offset+1)
hooks.get_hook('promote.make_daily_promotions').call(offset=offset)
finalize_completed_campaigns(daysago=1)
hooks.get_hook('promote.make_daily_promotions').call(offset=0)
def finalize_completed_campaigns(daysago=1):