github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-04-27 03:00:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Comment embeds: add/improve link instrumentation

Browse Source
This commit is contained in:
David Wick
2015-01-30 14:35:20 -08:00
parent 01b4d727e5
commit 773b4a1d19
2 changed files with 21 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
r2/r2/templates/base.iframe
View File

@@ -33,6 +33,7 @@
<%
link_data = {"redirect-type": "link", "redirect-thing": thing.link._id}
sr_data = {"redirect-type": "subreddit"}
reddit_data = {"redirect-type": "logo"}
%>
<!doctype html>
@@ -57,7 +58,7 @@
_sr_path=True,
)}
</p>
${plain_link("reddit", "/", _sr_path=False, _class="reddit-embed-footer-img")}
${plain_link("reddit", "/", _sr_path=False, _class="reddit-embed-footer-img", data=reddit_data)}
</footer>
</div>
</body>

29
r2/r2/templates/comment.iframe
View File

@@ -64,18 +64,27 @@
${_("%(name)s's comment was changed.") % dict(name="")}
%else:
<div class="reddit-embed-comment-meta">
%if not thing.score_hidden:
<a href="${add_sr(thing.permalink)}?context=3"
class="reddit-embed-comment-meta-item reddit-embed-score"
data-redirect-type="score"
data-redirect-thing="${thing._id}">
${thing.score} ${ungettext("point", "points", thing.score)}
</a>
%endif
%if thing.edits_visible and edited_recently:
<a href="${add_sr(thing.permalink)}?context=3"
class="reddit-embed-comment-meta-item reddit-embed-edited"
data-redirect-type="edited"
data-redirect-thing="${thing._id}">
edited
</a>
%endif
<a href="${add_sr(thing.permalink)}?context=3"
data-redirect-type="meta"
class="reddit-embed-comment-meta-item reddit-embed-permalink"
data-redirect-type="timestamp"
data-redirect-thing="${thing._id}">
%if not thing.score_hidden:
<span class="reddit-embed-comment-meta-item reddit-embed-score">${thing.score} ${ungettext("point", "points", thing.score)}</span>
%endif
%if thing.edits_visible and edited_recently:
<span class="reddit-embed-comment-meta-item reddit-embed-edited">edited</span>
%endif
<span class="reddit-embed-comment-meta-item reddit-embed-permalink">
${thing_timestamp(thing, thing.timesince, live=True, include_tense=True)}
</span>
${thing_timestamp(thing, thing.timesince, live=True, include_tense=True)}
</a>
</div>
%endif