github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-04-05 03:00:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix mutation of parent extra_page_classes in BrowseController.

Browse Source 
This caused the controller to eventually accumulate both the .top-page
and .controversial-page classes for every request since the parent
class's structure was being mutated.
This commit is contained in:
Max Goodman
2013-10-17 17:57:54 -07:00
parent e0ef19433d
commit 81f7912186
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
r2/r2/controllers/listingcontroller.py
View File

@@ -488,10 +488,12 @@ class BrowseController(ListingController):
self.sort = sort
if sort == 'top':
self.title_text = _('top scoring links')
self.extra_page_classes += ['top-page']
self.extra_page_classes = \
self.extra_page_classes + ['top-page']
elif sort == 'controversial':
self.title_text = _('most controversial links')
self.extra_page_classes += ['controversial-page']
self.extra_page_classes = \
self.extra_page_classes + ['controversial-page']
else:
# 'sort' is forced to top/controversial by routing.py,
# but in case something has gone wrong...