github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-04-27 03:00:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Only use window.open on http links

Browse Source
This commit is contained in:
Jordan Milne
2014-12-16 21:31:50 -04:00
parent 826c445eec
commit a79d6c2ddd
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
r2/r2/public/static/js/ui.js
View File

@@ -35,14 +35,18 @@ r.ui.init = function() {
if (r.config.new_window && (r.config.logged || !smallScreen)) {
$(document.body).on('click', 'a.may-blank, .may-blank-within a', function(e) {
if (!this.target) {
// nullify `window.opener` so the new tab can't navigate us
var href = $(this).attr('href');
var w = window.open(null, '_blank');
w.opener = null;
w.location.href = href;
// suppress normal link opening behaviour
e.preventDefault();
return false;
var proto = this.protocol;
if (this.href && (proto === "http:" || proto === "https:")) {
// nullify `window.opener` so the new tab can't navigate us
var href = $(this).attr('href');
var w = window.open(null, '_blank');
w.opener = null;
w.location.href = href;
// suppress normal link opening behaviour
e.preventDefault();
return false;
}
this.target = "_blank";
}
return true; // continue bubbling
})