github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-25 06:48:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

ZooKeeper: Make reduction of data optional in LiveList.get().

Browse Source 
If we need the raw list of objects so that we can know what objects can
be deleted etc. then we'll need to disable the reduction.
This commit is contained in:
Neil Williams
2012-08-07 10:03:23 -07:00
parent cf527d15cf
commit d896b9a71f
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
r2/r2/lib/zookeeper.py
View File

@@ -91,16 +91,20 @@ class LiveList(object):
@client.ChildrenWatch(root)
def watcher(children):
self.data = self._normalize_children(children)
self.data = self._normalize_children(children, reduce=True)
def _nodepath(self, item):
escaped = urllib.quote(str(item), safe=":")
return os.path.join(self.root, escaped)
def _normalize_children(self, children):
def _normalize_children(self, children, reduce):
unquoted = (urllib.unquote(c) for c in children)
mapped = map(self.map_fn, unquoted)
return list(self.reduce_fn(mapped))
if reduce:
return list(self.reduce_fn(mapped))
else:
return list(mapped)
def add(self, item):
path = self._nodepath(item)
@@ -114,9 +118,9 @@ class LiveList(object):
except NoNodeException:
raise ValueError("not in list")
def get(self):
def get(self, reduce=True):
children = self.client.get_children(self.root)
return self._normalize_children(children)
return self._normalize_children(children, reduce)
def __iter__(self):
if not self.is_watching: