github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-28 16:28:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix secondary sort in recommendations

Browse Source
This commit is contained in:
shlurbee
2013-09-18 08:39:03 -07:00
parent 4023a719a8
commit f0c080a46f
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
r2/r2/lib/recommender.py
View File

@@ -124,8 +124,11 @@ class SRRecommendation(tdb_cassandra.View):
for rank, id36 in rank_id36_pairs:
ranks[id36].append(rank)
recs = [(id36, len(ranks), max(ranks)) for id36, ranks in ranks.iteritems()]
# sort by number of times appeared, then max rank
return sorted(recs, key=itemgetter(1, 2), reverse=True)
# first, sort ascending by rank
recs = sorted(recs, key=itemgetter(2))
# next, sort descending by number of times the rec appeared. since
# python sort is stable, tied items will still be ordered by rank
return sorted(recs, key=itemgetter(1), reverse=True)
def _to_recs(self):
recs = self._values() # [ {rank, srid} ]