Cleanup in get_promotion_list.

This commit is contained in:
bsimpson63
2013-01-30 16:03:21 -05:00
parent ecea06bf90
commit f61587c7af

View File

@@ -806,17 +806,14 @@ PromoTuple = namedtuple('PromoTuple', ['link', 'weight', 'campaign'])
def get_promotion_list(user, site):
# site is specified, pick an ad from that site
if not isinstance(site, FakeSubreddit):
srids = set([site._id])
elif isinstance(site, MultiReddit):
srids = set(site.sr_ids)
# site is Fake, user is not. Pick based on their subscriptions.
elif user and not isinstance(user, FakeAccount):
srids = set(Subreddit.reverse_subscriber_ids(user) + [""])
# both site and user are "fake" -- get the default subscription list
else:
srids = set(Subreddit.user_subreddits(None, True) + [""])
srids = set(Subreddit.user_subreddits(None, ids=True) + [""])
tuples = get_promotion_list_cached(srids)
return [PromoTuple(*t) for t in tuples]