wiki: Move state variables out of inline JS.

r2/r2/lib/template_helpers.py

@@ -150,6 +150,10 @@ def js_config():
         "uitracker_url": g.uitracker_url,
         "static_root": static(''),
     }
+
+    if c.page:
+        config["wiki_page"] = c.page
+
     return config
 
 

r2/r2/public/static/js/wiki.js

@@ -98,10 +98,10 @@ r.wiki = {
         })
     },
 
-    goCompare: function(page, base) {
+    goCompare: function() {
         v1 = $('input:radio[name=v1]:checked').val()
         v2 = $('input:radio[name=v2]:checked').val()
-        url = base + '/' + page + '?v=' + v1
+        url = r.wiki.baseUrl() + '/' + r.config.wiki_page + '?v=' + v1
         if (v2 != v1) {
             url += '&v2=' + v2
         }

r2/r2/templates/wikipagerevisions.html

@@ -22,6 +22,6 @@
 
 ${thing.revisions}
 %if c.page and thing.revisions.things:
-    <button onclick="r.wiki.goCompare('${c.page}', '${c.wiki_base_url}')">${_("compare selected")}</button>
+    <button onclick="r.wiki.goCompare()">${_("compare selected")}</button>
 %endif
 <br/>