mirror of
https://github.com/reddit-archive/reddit.git
synced 2026-01-28 00:07:57 -05:00
Make API banned_by / approved_by mutually exclusive.
This also fixes an API bug where banned_by was always true if you don't have moderator permission for a thing.
This commit is contained in:
@@ -191,9 +191,12 @@ class ThingJsonTemplate(JsonTemplate):
|
||||
return thing.reported
|
||||
ban_info = getattr(thing, "ban_info", {})
|
||||
if attr == "banned_by":
|
||||
return ban_info.get("banner") if ban_info.get('moderator_banned') else True
|
||||
banner = (ban_info.get("banner")
|
||||
if ban_info.get('moderator_banned')
|
||||
else True)
|
||||
return banner if thing._spam else None
|
||||
elif attr == "approved_by":
|
||||
return ban_info.get("unbanner")
|
||||
return ban_info.get("unbanner") if not thing._spam else None
|
||||
|
||||
return getattr(thing, attr, None)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user