The docs are generated from the production code, but the links are to the
deprecated opensource repository (github.com/reddit/reddit), so the
links and line references are wrong.
Faceting returns counts of query matches per subreddit name so we can
show the user all the subreddits that contain links for their query.
This ends up returning many unpopular subreddits, which when looked up
by name are often missing from cache and result in a postgres query. This
is bad for performance, and the feature is not popular with users so it is
safe to remove.
If a link has an inbound tracking url (regular url plus utm query parameters)
or outbound tracking url (redirect via outbound link tracker service),
then replace the link's `href` with the tracking url when clicked.
This ensures links to the same resource with different tracking details
(e.g. comments flatlist button vs self-post title vs self-post source-url)
correctly render as `:visited` despite different `?utm_content=button-name`.
This commit also includes fixes to properly split the cache for rendered
link and comment templates when inbound tracking URLs are enabled.
Some errors don't have a code associated with them so we need to
supply a default value to abort_with_error. This fixes the
USER_DOESNT_EXIST errors that are causing exceptions.
Link.tracking_link adds utm query parameters onto links inside reddit
to track which button was clicked, what component type contains the button
(e.g. post listing, inbox, post listing embedded on a comments page),
what page type the user is visiting, and the page's subreddit.
This feature is enabled via feature flag and disabled by admin mode.
This commit affects programmatically-generated links to comments and messages.
For domains listings, it was possible to have results from the wrong domain be included. Switching to a phrase search fixes that. See https://redd.it/5ew4ve for more info about, and caveats of, this method.
For AllMinus, see https://redd.it/5eqiyy for the general context. This does not need to be explicitly handled for ModMinus, as ModMinus excludes the filtered subreddits from its sr_ids property. Additionally, ModMinus doesn't need special handling since it inherits the already-handled MultiReddit.
The most common, and I really mean it, the most common post in /r/help and related subreddits is when users question why they can't make a subreddit even though they have an old account. The error that users get only mentions account age and does not mention any kind of karma requirement. It's in the /r/help FAQ, but we all know no one reads that.
Just lightly mentioning karma could reduce the traffic on /r/help as well as be more clear.
These were original to prevent users from buying ads when
managed campaign page takeovers were in effect. With auction this
no longer matters since impressions are no longer guaranteed.
More recently it seems roadblocks were used to prevent people from
buying ads in places that were inappropriate. We now have other
ways of dealing with that (`subreddit.hide_sponsored_headlines and
`subreddit.allow_ads`) so these pages are completely obsolete.
Previously the messages in the non-fastlane queue were dropped so some
older comments would not be added to the CommentTree. There may be some
lock contention with multiple queue consumers processing updates for the
fastlaned links, but it shouldn't last very long.
This was used to gradually ramp up reads of the precomputed comment
orders. We've been running for a while with this set to always read,
so the setting can be removed.
This will let us get a sense of how much work is actually done. I'm looking
at splitting the CommentOrderer update out into a separate queue and need
to understand how many writes actually happen.
This warning was no longer true--any missing scores are automatically
calculated and updated.
We actually have the opposite issue--the CommentTree must be updated
before writing scores because the QA score reads it.
