github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-28 16:28:01 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,528 Commits 1 Branch 0 Tags
026514271162f46252cd4359b91eb682cb8465d2
Commit Graph

3528 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Brian Simpson
0265142711 Make analytics selector more selective. 
Promote_Graph rows use 'promotedlink' and 'promoted' classes to get
the same styling as promoted links. Their destination urls were getting
rewritten by analytics.js which was treating them as real promoted links.
 2013-09-23 13:28:35 -07:00
Chad Birch
411e281c80 Gold partners: add link to /r/goldbenefits thread 2013-09-23 13:28:35 -07:00
Chad Birch
2085520a32 "Your comment was gilded" message: update text 2013-09-23 13:28:35 -07:00
Roger Ostrander
d356c32a43 System Messages: Send out 'moderator added' notifications again 2013-09-23 13:28:35 -07:00
Chad Birch
76c8a6e7d7 Automatic gold messages: add "bottlecap" phrases 
This allows defining a set of phrases on a wiki page, and whenever an
automatic gold-related PM is sent, a random phrase is selected and
appended to the message.
 2013-09-23 13:28:35 -07:00
Neil Williams
08d1095edd Only display secure media objects when on HTTPS. 
Not all links that have media objects will have secure media objects, so
a subset of content will have embeds when accessing the site over HTTPS.
 2013-09-23 13:28:35 -07:00
Chad Birch
52765b7c53 Gold partners: update iFixit logo / Rover title 2013-09-23 13:28:35 -07:00
Max Goodman
e0d27579c8 Add .compressed class to items in the spotlight box where appropriate. 
This was causing promoted links to display with the 2 line tagline
formatting even though they did not have a thumbnail.
 2013-09-23 13:28:35 -07:00
Max Goodman
ec5eea9b71 Increase specificity of compressed link styles. 2013-09-23 13:28:35 -07:00
Max Goodman
5b37320724 Normalize thumbnail heights. 
The font size of the a.thumbnail element was causing inconsistent
vertical spacing across browsers. This tweak attempts to replace it with
a consistent 2px bottom margin.
 2013-09-23 13:28:35 -07:00
Max Goodman
33adc2e4ae Allow interest bar to size naturally. 2013-09-23 13:28:34 -07:00
Max Goodman
5f7576a718 Tweak minimum spotlight box heights. 
This adds specific heights for compressed and non-compressed links.
 2013-09-23 13:28:34 -07:00
Chad Birch
3e699d5253 Gold partners: add UPS 2013-09-23 13:28:34 -07:00
Max Goodman
83d03f17a1 Prevent text wrapping artifact upon left bar collapse. 2013-09-23 13:28:34 -07:00
Neil Williams
3c9810f80e Allow pixels on c.secure pageviews. 
The pixel system is now HTTPS-ready so we can use pixels safely on
c.secure requests.
 2013-09-23 11:53:04 -07:00
Neil Williams
e535646372 Switch to a packaged version of LESS. 
Assuming the package from our PPA is used, this upgrades to LESS
v1.4.2.1 in the process.
 2013-09-20 10:49:02 -07:00
Neil Williams
91176e53ad reddit.less: Remove inchoate rule that doesn't work. 2013-09-20 10:49:02 -07:00
Brian Simpson
8a4b6faace Don't send adServerClickUrl. 2013-09-19 18:15:24 -04:00
Brian Simpson
e3945794c1 Per user CPM overrides. 2013-09-19 18:15:08 -04:00
Brian Simpson
1ac1bd4693 Add hook upon to fire when editing a campaign. 2013-09-19 04:37:02 -04:00
Brian Simpson
ea9481fc54 Remove unused sample_promoted_links. 2013-09-19 04:37:02 -04:00
Brian Simpson
9c9ba4ab4a Send subreddit names in POST_request_promo request from Spotlight. 2013-09-19 04:37:02 -04:00
Brian Simpson
7e15f2e3ab Increase promoted link inventory. 
Was using a very conservative estimate to get started, also because
during the beta pageviews were not available on the frontpage.
 2013-09-19 04:37:02 -04:00
Brian Simpson
81b5844bfb Check inventory on freebie and pay. 2013-09-19 04:37:01 -04:00
Brian Simpson
388fa19224 RenderableCampaign: wait to convert bid and spent floats to strings. 
Comparing the string values can give incorrect result when checking
if a campaign is underdelivered.
 2013-09-19 04:37:01 -04:00
Brian Simpson
cf40ae1906 CPM is new message. 2013-09-19 04:37:01 -04:00
Brian Simpson
dd2be333d8 fill_campaign_editor: clean up form disabling on errors. 2013-09-19 04:37:01 -04:00
Brian Simpson
d239be0abc Add back minimum-spend div and fix styling. 2013-09-19 04:37:01 -04:00
Brian Simpson
06c15469f4 Use correct selfserve wiki url. 2013-09-19 04:37:01 -04:00
Brian Simpson
f50452cb43 Hide roadblock error message when inputs change. 2013-09-19 04:37:01 -04:00
Brian Simpson
d5dacda6d8 VBid to validate promoted link bids. 2013-09-19 04:37:01 -04:00
Brian Simpson
3b35f147f2 When calculating maximum bid round down to nearest whole penny. 2013-09-19 04:37:01 -04:00
Brian Simpson
a2f23e93ff Allow users to enter desired budget or desired goal. 
The fields are dependent (impressions = budget / cpm) so changing
one updates the other.
 2013-09-19 04:37:01 -04:00
Brian Simpson
dad5fb7401 Show maximum allowable bid when input bid is too high. 2013-09-19 04:37:01 -04:00
Brian Simpson
50ec6045f2 Check for booked inventory to exclude on the client side. 
Real inventory values (predicted inventory minus booked inventory) are sent to
the client. When checking available inventory on the front end while editing or
creating a campaign we calculate how many impressions have already been booked
for that campaign (if any) and add that into the real inventory value.
 2013-09-19 04:37:01 -04:00
Brian Simpson
d386fb7071 Campaigns can be pending in addition to being live or complete. 
Campaigns are charged 24 hours before going live, so checking whether
a campaign is complete requires more than just checking that it's not
live.
 2013-09-19 04:37:00 -04:00
Brian Simpson
a4263a6991 Send an email when campaign is refunded. 2013-09-19 04:37:00 -04:00
Brian Simpson
d1dbfb270c Manually refund underdelivered campaigns. 2013-09-19 04:37:00 -04:00
Brian Simpson
a972551e1b Hook fires on each new charge, not once for entire charge_pending. 2013-09-19 04:37:00 -04:00
Brian Simpson
e27cbd183b PromoteLinkform: switch up the wording for targeting. 2013-09-19 04:37:00 -04:00
Brian Simpson
43e7ecd048 PromoteLinkForm: show total available impressions. 2013-09-19 04:37:00 -04:00
Brian Simpson
1f5f98fbc0 PromoteLinkForm: wording change for creating additional campaigns. 2013-09-19 04:37:00 -04:00
Brian Simpson
3f4ac47b16 Simplify oversold message. 
Only show the total available for given target and dates, rather than
breaking it down by date.
 2013-09-19 04:37:00 -04:00
Brian Simpson
421dd824b0 Exclude reserved inventory for current campaign from inventory check. 2013-09-19 04:37:00 -04:00
Brian Simpson
ac6657832a finalize_completed_campaigns: be careful with cpm attribute. 2013-09-19 04:37:00 -04:00
Brian Simpson
dfef592449 finalize_completed_campaigns: typo in links lookup. 2013-09-19 04:37:00 -04:00
Brian Simpson
e6bfc29316 Use a very conservative estimate of ad inventory. 
Inventory is estimated using traffic to GET_listing. This is a pretty good
estimate based on historical trends (compare subreddit traffic to impressions for
promoted links targeted to the subreddit). It seems safer to start out with a low
estimate. This is especially needed because the CPM beta will only show promoted
links on the subreddit listing, not on multireddits or the front page.
 2013-09-19 04:37:00 -04:00
Brian Simpson
cb4b603283 Increase minimum height of Spotlight to make reflows less frequent. 2013-09-19 04:37:00 -04:00
Brian Simpson
162aac4912 promote.py whitespace. 2013-09-19 04:37:00 -04:00
Brian Simpson
2fa369e76e promote.new_campaign cleanup. 2013-09-19 04:32:22 -04:00