github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-28 16:28:01 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,544 Commits 1 Branch 0 Tags
3939e7c62df487286a7c045d2a79850d2e8c49fd
Commit Graph

3544 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Neil Williams
3939e7c62d /dev/api: Fix erroneous GET_listing. 
This isn't actually a routed endpoint but an artifact of code reuse.
 2013-09-23 15:42:36 -07:00
Neil Williams
0463da9c80 /dev/api: Document the "moderation" section. 2013-09-23 15:42:36 -07:00
Kruithne
3f44e02032 Corrected minor typographical errors. 2013-09-23 15:42:36 -07:00
Neil Williams
9d541ea0c9 /dev/api: Make "one of" lists use <code>. 
This increases consistency with the rest of the docs which put tokens in
<code> markers (which formats to a monospace font).
 2013-09-23 15:42:36 -07:00
Neil Williams
69e908fa62 /dev/api: Move POST_accept_moderator_invite to moderation section. 
Since that's where POST_leavemoderator lives, it seems more symmetric.
 2013-09-23 15:42:36 -07:00
Neil Williams
2392ad9a86 /dev/api: Fix URL path for GET_moderationlog. 2013-09-23 15:42:36 -07:00
Neil Williams
de4301d24d /dev/api: Document the use of c.site. 
For POST requests, this is done (preferably) by the "r" parameter. Other
requests use the path prefix /r/{subreddit}. Since c.site is a global,
it's hard to actually see if it's used by methods, so this uses an
additional manually added parameter to the api_doc decorator to indicate
when c.site is important.
 2013-09-23 15:42:36 -07:00
Neil Williams
50c3ab5353 /dev/api: Add a note about modhashes on OAuth. 2013-09-23 15:42:35 -07:00
Neil Williams
24729503f9 Remove cup_info system and reimplement cake days more simply. 
This removes a hardcache multi-lookup on every builder'd page and
simplifies the system for cake days.

Cups for the nightly "best *" awards are casualties of this, but they're
little known and probably won't be missed.
 2013-09-23 14:18:18 -07:00
Neil Williams
531c1bd546 Clean up missing line deletion not merged out properly. 2013-09-23 13:31:03 -07:00
Brian Simpson
67658a90b6 Increase promoted link inventory. 2013-09-23 13:28:35 -07:00
Brian Simpson
c9696da9a9 Update promoted link emails. 2013-09-23 13:28:35 -07:00
Brian Simpson
6f2a5b700d Return empty dict if metric_name is not found in PromoMetrics. 2013-09-23 13:28:35 -07:00
Neil Williams
acd485e1bc Add default for new cake system. 2013-09-23 13:28:35 -07:00
Roger Ostrander
34377138ba Email: Use non-hardcache ban fetching system 2013-09-23 13:28:35 -07:00
Chris Lexmond
31459b18f7 OAuth: add new "history" and "save" scopes 
history: gives access to voting history, saved and hidden
save: allows save/unsave for submissions and comments
 2013-09-23 13:28:35 -07:00
Brian Simpson
0265142711 Make analytics selector more selective. 
Promote_Graph rows use 'promotedlink' and 'promoted' classes to get
the same styling as promoted links. Their destination urls were getting
rewritten by analytics.js which was treating them as real promoted links.
 2013-09-23 13:28:35 -07:00
Chad Birch
411e281c80 Gold partners: add link to /r/goldbenefits thread 2013-09-23 13:28:35 -07:00
Chad Birch
2085520a32 "Your comment was gilded" message: update text 2013-09-23 13:28:35 -07:00
Roger Ostrander
d356c32a43 System Messages: Send out 'moderator added' notifications again 2013-09-23 13:28:35 -07:00
Chad Birch
76c8a6e7d7 Automatic gold messages: add "bottlecap" phrases 
This allows defining a set of phrases on a wiki page, and whenever an
automatic gold-related PM is sent, a random phrase is selected and
appended to the message.
 2013-09-23 13:28:35 -07:00
Neil Williams
08d1095edd Only display secure media objects when on HTTPS. 
Not all links that have media objects will have secure media objects, so
a subset of content will have embeds when accessing the site over HTTPS.
 2013-09-23 13:28:35 -07:00
Chad Birch
52765b7c53 Gold partners: update iFixit logo / Rover title 2013-09-23 13:28:35 -07:00
Max Goodman
e0d27579c8 Add .compressed class to items in the spotlight box where appropriate. 
This was causing promoted links to display with the 2 line tagline
formatting even though they did not have a thumbnail.
 2013-09-23 13:28:35 -07:00
Max Goodman
ec5eea9b71 Increase specificity of compressed link styles. 2013-09-23 13:28:35 -07:00
Max Goodman
5b37320724 Normalize thumbnail heights. 
The font size of the a.thumbnail element was causing inconsistent
vertical spacing across browsers. This tweak attempts to replace it with
a consistent 2px bottom margin.
 2013-09-23 13:28:35 -07:00
Max Goodman
33adc2e4ae Allow interest bar to size naturally. 2013-09-23 13:28:34 -07:00
Max Goodman
5f7576a718 Tweak minimum spotlight box heights. 
This adds specific heights for compressed and non-compressed links.
 2013-09-23 13:28:34 -07:00
Chad Birch
3e699d5253 Gold partners: add UPS 2013-09-23 13:28:34 -07:00
Max Goodman
83d03f17a1 Prevent text wrapping artifact upon left bar collapse. 2013-09-23 13:28:34 -07:00
Neil Williams
3c9810f80e Allow pixels on c.secure pageviews. 
The pixel system is now HTTPS-ready so we can use pixels safely on
c.secure requests.
 2013-09-23 11:53:04 -07:00
Neil Williams
e535646372 Switch to a packaged version of LESS. 
Assuming the package from our PPA is used, this upgrades to LESS
v1.4.2.1 in the process.
 2013-09-20 10:49:02 -07:00
Neil Williams
91176e53ad reddit.less: Remove inchoate rule that doesn't work. 2013-09-20 10:49:02 -07:00
Brian Simpson
8a4b6faace Don't send adServerClickUrl. 2013-09-19 18:15:24 -04:00
Brian Simpson
e3945794c1 Per user CPM overrides. 2013-09-19 18:15:08 -04:00
Brian Simpson
1ac1bd4693 Add hook upon to fire when editing a campaign. 2013-09-19 04:37:02 -04:00
Brian Simpson
ea9481fc54 Remove unused sample_promoted_links. 2013-09-19 04:37:02 -04:00
Brian Simpson
9c9ba4ab4a Send subreddit names in POST_request_promo request from Spotlight. 2013-09-19 04:37:02 -04:00
Brian Simpson
7e15f2e3ab Increase promoted link inventory. 
Was using a very conservative estimate to get started, also because
during the beta pageviews were not available on the frontpage.
 2013-09-19 04:37:02 -04:00
Brian Simpson
81b5844bfb Check inventory on freebie and pay. 2013-09-19 04:37:01 -04:00
Brian Simpson
388fa19224 RenderableCampaign: wait to convert bid and spent floats to strings. 
Comparing the string values can give incorrect result when checking
if a campaign is underdelivered.
 2013-09-19 04:37:01 -04:00
Brian Simpson
cf40ae1906 CPM is new message. 2013-09-19 04:37:01 -04:00
Brian Simpson
dd2be333d8 fill_campaign_editor: clean up form disabling on errors. 2013-09-19 04:37:01 -04:00
Brian Simpson
d239be0abc Add back minimum-spend div and fix styling. 2013-09-19 04:37:01 -04:00
Brian Simpson
06c15469f4 Use correct selfserve wiki url. 2013-09-19 04:37:01 -04:00
Brian Simpson
f50452cb43 Hide roadblock error message when inputs change. 2013-09-19 04:37:01 -04:00
Brian Simpson
d5dacda6d8 VBid to validate promoted link bids. 2013-09-19 04:37:01 -04:00
Brian Simpson
3b35f147f2 When calculating maximum bid round down to nearest whole penny. 2013-09-19 04:37:01 -04:00
Brian Simpson
a2f23e93ff Allow users to enter desired budget or desired goal. 
The fields are dependent (impressions = budget / cpm) so changing
one updates the other.
 2013-09-19 04:37:01 -04:00
Brian Simpson
dad5fb7401 Show maximum allowable bid when input bid is too high. 2013-09-19 04:37:01 -04:00