A user will only be sent a ban notification if either of the following
is true:
1. they are subscribed to the subreddit
2. they have ever gained or lost karma (of any type) in the subreddit
Because of these conditions, there is some confusion in cases where
moderators ban someone that has made a post that didn't yet receive any
votes, where they still expect the user to receive a ban message and be
able to see the reason for the ban that they requested to include in it.
This commit makes it so that including a custom reason is not possible
in a case where the message won't actually be sent, to prevent that
confusion.
Currently all subscriptions (new or recurring) have a secret (autorenew-).
To make it easier to find which type of payment it is, this will clear the
secret if this is a recurring subscription (which is the same structure
paypal takes).
This is a good interaction in theory, but gets pretty hairy to test for
in practice due to modmail being a subset of messages as well as
subreddit messages not being restricted to modmail. This issue is
blocking release, so remove the buggy feature for rollout to be addressed
at a later date.
Update normalized_hot to allow certain LabeledMultis
to specify slightly different weighting between subreddits
compared to the current algorithm.
Current merge algorithm always results in an N-subreddit multi
having the first N results being the #1 result from each of
the individual subreddits; this is not always ideal for slow
subreddits (e.g., /r/announcements and /r/blog).
Age-weighting allows a LabeledMulti to scale those older posts
further down the list, and lets them drop off after a number of
days.
The age-weighting will require a change to the use of sgm
in normalized_hot prior to full deployment, as the calculated
ehot values are no longer global amongst all users.
Note: While I'd have preferred to do a "nice" endpoint
like what I did with user friends, there's been enough
delay in exposing /api/friend functionality to OAuth2
consumers that I decided it would be best to take the
less clean solution.
This fixes bold `False`s showing up in the `.json-html`
and `.json-compact` renderstyles. Apparently been an issue for
5 years, but it was only noticed now.
The logic of this code contained a couple subtle errors that could cause
strange behavior. In reddit's current state of having two "automatic
subreddits" (which are always included in the front page set, and not
counted towards the limit), the fact that the automatic_ids list could
have an item removed while being iterated over meant that unsubscribing
from the first automatic subreddit (/r/blog) made it so that it was
effectively impossible to unsubscribe from the second one
(/r/announcements). If you unsubscribed, it would still be present in
your front page regardless, and if you stayed subscribed it would
actually be present twice.
This reverts commit 605fa72772fa84b9245498f817cdc6d872ab3bdd.
This endpoint has had no significant traffic for months, and should be
safe to remove again at this point.
