github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-28 16:28:01 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,236 Commits 1 Branch 0 Tags
511ca3e56d2eb2ae4bcf7013c16f4c670c70ed5e
Commit Graph

2236 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Max Goodman
511ca3e56d wiki: URL-escape constructed API call URLs. 2012-12-06 14:54:13 -08:00
Max Goodman
a0899409b1 wiki: Fix files undefined in finally case. 2012-12-06 14:54:13 -08:00
Max Goodman
d56f02e8ed wiki: Remove debug statement. 2012-12-06 14:54:13 -08:00
Andre D
4ecee12d33 wiki: Rework page creation. 2012-12-06 14:54:13 -08:00
Andre D
f4bab12564 wiki: Use VSrModerator. 2012-12-06 14:54:13 -08:00
Max Goodman
4d86ad0a8f Add small front page gold advertisement. 2012-12-06 14:54:13 -08:00
Max Goodman
8bf881535f Make the subreddit field required. 2012-12-06 14:54:13 -08:00
Max Goodman
09b0be2583 Add maxlength attribute to submit form title field. 2012-12-06 14:54:13 -08:00
Max Goodman
d7644b8f00 Remove spurious submit form title wrap attribute. 
This was prompted by buggy IE10 behavior where the "required" attribute
form validation seems to treat the textarea as empty with the "wrap"
attribute present.
 2012-12-06 14:54:12 -08:00
Ricky Ramirez
aa645a45df sharelink: Clearly specifiy methods of sharing links. 2012-12-06 14:54:12 -08:00
Neil Williams
2d22cd2aa9 Split the rendercache and pagecache. 
The pagecache and rendercache have very different usage profiles.
 2012-12-06 14:54:12 -08:00
Neil Williams
b201405a0e Move CommentPane cache to the render cache pool. 2012-12-06 14:53:51 -08:00
bsimpson63
9da18a9926 Cleanup RenderableCampaign and add batching for live campaigns. 2012-12-06 15:17:16 -05:00
bsimpson63
f7c2437f24 Adweight uses Link fullname as 'link' field. 2012-12-06 15:17:01 -05:00
bsimpson63
4e850ca427 Batch lookup subreddits in make_daily_promotions. 2012-12-06 15:17:01 -05:00
bsimpson63
90dfcdf7be promote.py: Use more descriptive names. 2012-12-06 15:17:01 -05:00
bsimpson63
81272f7dd4 Stop using traffic to weight promotions. 2012-12-06 15:17:01 -05:00
bsimpson63
c944834650 promote.py: Reorganize for readability. 2012-12-06 15:17:01 -05:00
bsimpson63
20061dffb3 Fix typo so we correctly calculate Subreddit traffic weights. 2012-12-06 15:16:50 -05:00
Neil Williams
cadc79f517 DenormalizedRelation: fix bug in fast_query single thing2 case. 2012-12-04 13:44:46 -08:00
Neil Williams
6e7c3d697c CommentPane cache: save some work when not logged in. 
Skip the authorship checks and ThingUpdater work (two iterations over
the comment listing) when the user is not logged in.
 2012-12-04 13:44:46 -08:00
Neil Williams
efa3bb4009 Add migration script for regenerating CommentParticipationByAccount CF. 2012-12-04 11:41:24 -08:00
Neil Williams
68291521b5 Move query_cache scripts to a more general "migrate" directory. 
Not just for the query cache anymore!
 2012-12-04 11:41:24 -08:00
Neil Williams
925c9ccc68 /dev/api: Fully document the "links and comments" section. 2012-12-04 10:29:21 -08:00
Neil Williams
9f5740e3ff /dev/api: Use "fullname" instead of "id" where appropriate. 
ID is used elsewhere to mean the raw numerical ID (usually represented
in decimal) rather than the fullname which includes the type ID and is
in base36.
 2012-12-04 10:29:21 -08:00
Neil Williams
01a67579a8 /dev/api: Improve semantics of param markup and tweaks styles. 
The style changes should make it easier to match param names to
descriptions, especially with multi-line descriptions.
 2012-12-04 10:29:21 -08:00
Neil Williams
e99a34c36b /dev/api: Remove translation markers from param docs. 
The docstrings are untranslated so it is inconsistent to mark the
params for translation.
 2012-12-04 10:29:21 -08:00
Max Goodman
d566d91d84 Temporarily use "[deleted]" in JSON for deleted usernames. 
This is to work around Alien Blue crashing when it encounters a `null`
in the author property. We'll revert this after a grace period for
Alien Blue and any other affected apps to be updated.
 2012-12-03 18:05:21 -08:00
Neil Williams
4e620f96b5 Start writing comment participation by thread. 
This new DenormalizedRelation tracks when a user is the author of a
comment in the given thread.  Once it's backfilled, we can use it to
quickly determine eligibility for the CommentPane cache.
 2012-12-03 15:33:44 -08:00
Neil Williams
3a5eabc7cc JSON: Fix deleted account names being leaked. 2012-12-03 15:33:44 -08:00
Keith Mitchell
faa59a2b4c check-code: Rework check-code for other use cases 
check-code now handles 3 main use cases:

check-code report: Generate a report of pep8, pep257, and pyflakes problems
check-code regression: Diff said report from current ref to the upstream git ref
check-code junit: Create a junit report of all problems in the current git ref

Additionally:
* You can specify which files to check (check-code junit r2/r2/models/link.py)
* You can send output to a file (check-code -O junit.xml junit)
 2012-12-03 14:21:59 -08:00
Neil Williams
2dea71ad1c Subreddit CSS: Dump permacache-based last modified system. 
This system is only used when stylesheets are not hosted on S3. The new
system saves a completely unnecessary C* lookup and ditches one more
thing from the permacache.
 2012-12-03 12:00:28 -08:00
Neil Williams
9188eb5c2d Refactor reddit_base.check_modified to not use last_modified. 
This gives us greater flexibility to use a date from any source, rather
than just the permacache-based last modified system.
 2012-12-03 12:00:28 -08:00
Roger Ostrander
dcc97b6749 No longer clogging up logs with 500 errors 2012-12-03 12:00:27 -08:00
bsimpson63
d63fba2d59 Add multireddit for /r/mod. 2012-12-03 14:22:11 -05:00
bsimpson63
257ea95142 Cleanup SubscriptionBox. 2012-12-03 14:22:11 -05:00
bsimpson63
9e3a2fd316 Detach campaign the cool way. 2012-12-03 14:22:11 -05:00
bsimpson63
44c3589758 Rename button edit to save when editing campaign. 2012-12-03 14:22:05 -05:00
Neil Williams
a7d3f3b612 traffic: minor housekeeping and more docstrings. 2012-12-03 10:58:38 -08:00
Ricky Ramirez
603ec0e049 wiki: Fix bug with wiki permissions. 2012-12-03 10:58:26 -08:00
Neil Williams
24aeadea19 Disable last visit processing on GET_info as well. 2012-12-03 10:49:50 -08:00
Neil Williams
a7cad5dac5 Don't do last visit stuff on POSTs. 
It isn't really necessary to do it on every POST_vote, POST_hide etc.
 2012-12-03 10:49:50 -08:00
Neil Williams
db7e5e9ac6 Temporarily break imgur.com domain listings for the greater good. 
Turns out, this is the entire cause of current permacache lock
contention causing vote processing slowdowns.
 2012-12-01 22:26:06 -08:00
Neil Williams
f8c264a7de Add client side validation attributes to submit page form elements. 
There're several benefits to using the type=url format for the link url
field, including a more context-useful keyboard on some mobile devices
and browser-side validation of URLs before even sending a request to us.

This should save us from the ugly "tried to submit %s but couldn't
parse" warnings coming from people pasting imgur bbcode etc. into the
field.
 2012-11-29 15:16:24 -08:00
Max Goodman
815e8563df gilding: Document the gildComment / thingupdater interaction. 2012-11-29 15:16:21 -08:00
Max Goodman
763e824a48 gilding: Fix bug where thingupdater counts were incremented. 
The value supplied by the inlined thingupdater data is the current
count and should not be incremented by gildComment.
 2012-11-29 15:16:21 -08:00
Max Goodman
e537c3e247 jsonp: Constrain acceptable callback values. 2012-11-29 15:16:21 -08:00
Max Goodman
fd74634669 buttons: Add simple sr name validation. 2012-11-29 15:16:21 -08:00
Logan Hanks
43e29007b2 Update example.ini to enable only comment tree v1. 2012-11-20 14:17:25 -08:00
Neil Williams
f2894776db tdb_sql: Up the number of frames in traceback. 
tdb_sql has a lot of functions. Seven frames was frequently insufficient
to see who was phone.
 2012-11-20 14:09:38 -08:00