Commit Graph

2040 Commits

Author SHA1 Message Date
bsimpson63
5a0fbb5c8f promote.py: Remove unused CAMPAIGN object. 2012-11-01 17:27:04 -04:00
bsimpson63
8a0020c9fb Promote controller users keep_fn to skip deleted links. 2012-11-01 17:27:04 -04:00
bsimpson63
bbe091c599 Move onchange out of set_promote_status. 2012-11-01 17:27:04 -04:00
bsimpson63
7ba1d9dde5 Stop writing to old promoted link queries. 2012-11-01 17:27:04 -04:00
bsimpson63
cac918e423 Read promoted link queries from UserQueryCache. 2012-11-01 17:27:04 -04:00
bsimpson63
31c3cbcd33 Add UserQueryCache queries for promoted links and dual write. 2012-11-01 16:31:07 -04:00
bsimpson63
dd46b66fd7 Only one way to get_transactions. 2012-11-01 16:31:01 -04:00
bsimpson63
63d9877b90 Don't create campaigns attribute for new promoted links. 2012-11-01 16:30:54 -04:00
bsimpson63
c3dd44d59b Clean out unused stuff from promote. 2012-11-01 16:30:47 -04:00
bsimpson63
ac7b6d6916 Stop passing around indx, use PromoCampaigns. 2012-11-01 16:30:40 -04:00
bsimpson63
89a65e9eb1 Get rid of editable_add_props.
It was doing too much, and also the last place where the campaigns dict
attribute was still put onto promoted links.
2012-11-01 16:30:32 -04:00
Keith Mitchell
152c79c62c Make the /health/ads check more useful 2012-11-01 10:47:32 -07:00
Keith Mitchell
9bcf690e99 Remove unused PromoteDates code 2012-10-29 12:32:27 -07:00
Keith Mitchell
f49d997ea9 Remove unused VBid validator 2012-10-29 12:32:22 -07:00
Keith Mitchell
658b8ce0bd MinimalController: str has no attribute append
MinimalController calls set_content_type(), which
in some cases references c.response_wrappers. However,
MinimalController was not setting c.response_wrappers to
a list, which caused an error.
2012-10-29 12:32:11 -07:00
shlurbee
3fe8471c5c Add email link to promo traffic help page 2012-10-29 12:28:00 -07:00
shlurbee
29cf7ce612 Only show traffic settings for promo owner/admin
Promos can have approved "viewers" but they shouldn't be able to edit traffic
settings. This change hides the Settings tab unless the user is owner of the
promo or an admin.
2012-10-29 12:27:58 -07:00
shlurbee
f9b091804a Better handling of inventory special cases 2012-10-29 12:27:55 -07:00
Keith Mitchell
81891ea4d7 ads: Add endpoint for health check on ads
Adds a new route /health/ads which returns in plain text the seconds
since the epoch that the ad system was last updated via make_daily_promotions()
2012-10-26 13:30:38 -04:00
bsimpson63
82014d80b1 Stop writing to old promotion_log attribute. 2012-10-26 13:29:49 -04:00
bsimpson63
e5e7fc2c31 Read from PromotionLog. 2012-10-26 13:29:28 -04:00
bsimpson63
1faa705673 sort the PromotionLog 2012-10-26 13:29:19 -04:00
bsimpson63
bfa2d39cb9 Use _force_utf8 for PromotionLog entries. 2012-10-26 13:29:11 -04:00
Neil Williams
463d969ad0 ZooKeeper: replace deprecated connect() with start(). 2012-10-25 14:03:12 -07:00
Neil Williams
b55934ab6f Account: ensure all non-defaulted attributes are atomically created.
This prevents an issue where registration_ip is not set on the account
object causing downstream code to break. This happened because the app
would crash for whatever reason between committing in register() and
adding the IP and committing again in ApiController:_handle_register.
2012-10-25 14:03:12 -07:00
Logan Hanks
0922ab4ec4 Fix race condition in counting/timing stat buffers. 2012-10-25 14:03:12 -07:00
Neil Williams
5b882b55be thing: Use transactions for committing things.
This should protect us against partial commits leading to broken things
that have fewer data attributes than they're supposed to.  It should
also improve Postgres performance as we'll be doing fewer total
transactions.
2012-10-24 17:35:50 -07:00
Neil Williams
b501ab6771 tdb_sql: Protect TransactionSet against failures in rollback. 2012-10-24 17:35:50 -07:00
Neil Williams
4bb51e74a7 tdb_sql: Code cleanup and documentation; TransSet -> TransactionSet. 2012-10-24 17:35:50 -07:00
Neil Williams
80e5138129 tdb_sql: Fix transaction state not being reset after commit/rollback. 2012-10-24 17:35:50 -07:00
Neil Williams
6c0b6e3846 tdb_sql: Fix duplicate transactions being opened on same connection. 2012-10-24 17:35:49 -07:00
Neil Williams
e8c40301fe lock: Make it cleaner to acquire/release locks outside context managers. 2012-10-24 17:35:49 -07:00
Keith Mitchell
d76e586de3 pep257: Use double guotes in promote.py and bidding.py 2012-10-24 12:55:29 -07:00
Keith Mitchell
1c33743002 code review: Store live promotions as C* data 2012-10-24 12:55:29 -07:00
Keith Mitchell
6bfa552398 tdb_cassandra: Magic up the _ttl attribute for ThingMeta users 2012-10-24 12:55:29 -07:00
Keith Mitchell
e34e8d8d3e Store live promotions as structured C* data
Initially this is dual-write only
2012-10-24 12:55:28 -07:00
Keith Mitchell
6828c6940f bidding.py: Honor g.db_create_tables 2012-10-24 12:54:22 -07:00
Keith Mitchell
b5c9d44ea9 Remove unused import from message.compact 2012-10-24 12:54:13 -07:00
Keith Mitchell
7b2dcb3cf6 Remove unused utility/template_helpers alternatives to query_string 2012-10-24 12:54:08 -07:00
Keith Mitchell
e954889640 query_string(): mako.url_escape expects unicode 2012-10-24 12:53:53 -07:00
shlurbee
d712c2d7ef New promoted traffic page
Splits promo traffic apart into tabs: one for the link traffic, one that shows
campaign traffic stats in a table, and another tab for settings (which is just
viewer list right now.)

Gated by VSponsorAdmin for testing/feedback.
2012-10-23 16:52:16 -07:00
shlurbee
ca1eb8686b Fix traffic viewer messaging
Updates traffic viewer emails to use new message string locations. Fixes
a bug that was preventing emails from being sent when a new traffic viewer
was added.
2012-10-23 16:52:13 -07:00
shlurbee
30bceec164 Remove old fixme
Verified that payment is working correctly. Fixme no longer needed.
2012-10-23 16:52:11 -07:00
shlurbee
aefb174c48 Allow sponsors/admins to edit live campaign
Allows admins/sponsors to edit some campaign fields even after the ad has gone
live. Target can be changed at any time. Bid can only be changed for freebies.
2012-10-23 16:52:07 -07:00
Logan Hanks
1da78397c3 Make @g.stats.amqp_processor flush stats. 2012-10-23 14:30:13 -07:00
Logan Hanks
1468f32a2a Drop in replacement code for python-statsd. 2012-10-23 14:30:13 -07:00
Neil Williams
16d0b1c480 query_cache: Add support for precomputed queries. 2012-10-23 14:30:13 -07:00
bsimpson63
33400828c0 PromotionLog CF and dual write.
PromotionLog will replace the old promotion_log, which was a list
attribute on promoted links.
2012-10-19 12:56:17 -07:00
bsimpson63
1c935d530b Cleanup in promote. 2012-10-19 12:56:17 -07:00
Neil Williams
8fc311487d Add a Pig-based map/reduce system for filling the new query cache. 2012-10-19 12:56:17 -07:00