github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-02-03 11:15:06 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,720 Commits 1 Branch 0 Tags
5b373c3e29e33ea99c372199f48c864d080ecfdd
Commit Graph

1720 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Logan Hanks
5b373c3e29 Fix oauth2 permission enforcement logic. 2012-08-22 15:05:12 -07:00
Logan Hanks
cf6b533b5d Fix error reporting for app icon uploads. 2012-08-22 15:05:12 -07:00
Logan Hanks
3a800ea8f0 Give names to the various adddeveloper errors. 2012-08-22 15:05:12 -07:00
Logan Hanks
f87053efc0 Move all the apps javascript into the r.apps namespace. 2012-08-22 15:05:12 -07:00
Logan Hanks
53d0d40891 Fix alignment of app icons on prefs and authorize pages. 2012-08-22 15:05:12 -07:00
Logan Hanks
6ca678e013 Let developers remove themselves from apps. 2012-08-22 15:05:12 -07:00
Logan Hanks
432a0c3d33 Batch up oauth-related lookups. 2012-08-22 15:05:12 -07:00
Logan Hanks
14de2c0116 Use VSanitizedUrl for redirect_url in POST_updateapp. 2012-08-22 15:05:12 -07:00
Logan Hanks
21b9ffe0ba Clean up how new apps are inserted into /prefs/apps. 2012-08-22 15:05:12 -07:00
Logan Hanks
efe791ea2c Clean up submit buttons in /prefs/apps. 2012-08-22 15:05:12 -07:00
Logan Hanks
feebd01992 Impose a limit on number of app developers, and sort them. 2012-08-22 15:05:12 -07:00
Logan Hanks
5c223a20c1 Update page when an app is created or updated. 2012-08-22 15:05:12 -07:00
Logan Hanks
e8942187e2 Update page as developers are added to/removed from an app. 2012-08-22 15:05:12 -07:00
Logan Hanks
878074e845 Rework how app icon uploads work. 2012-08-22 15:05:12 -07:00
Logan Hanks
5a170ee590 Improve layout of app icon uploader. 2012-08-22 15:05:12 -07:00
Logan Hanks
bd08154d4c Add api docs for app-related methods. 2012-08-22 15:05:12 -07:00
Logan Hanks
d1b46854f9 Hide app creation form until button is clicked. 2012-08-22 15:05:12 -07:00
Logan Hanks
df3e26873b Upload app icons to S3. 2012-08-22 15:05:11 -07:00
Logan Hanks
961c2e8116 Show list of developers in app details. 2012-08-22 15:05:11 -07:00
Logan Hanks
f7236f99e3 Fade out apps when revoked or deleted. 2012-08-22 15:05:11 -07:00
Logan Hanks
545e1c7a3b Clean up the developed apps UI. 2012-08-22 15:05:11 -07:00
Max Goodman
d56046f1d0 Check token validity when verifying OAuth2 requests. 2012-08-22 15:05:11 -07:00
Max Goodman
1fd9c0662a Rename access token is_valid to avoid __getattr__ silliness 2012-08-22 15:05:11 -07:00
Max Goodman
b94978a647 Fix: add client_id to OAuth2 access tokens. 2012-08-22 15:05:11 -07:00
Max Goodman
09c60ba42d Switch user ids to id36s for consistency and str type keys. 2012-08-22 15:05:11 -07:00
Max Goodman
9f7bdd8113 Add comment OAuth2 scope. 2012-08-22 15:05:11 -07:00
Max Goodman
deff9405da Add OAuth2 handling to the main APIController. 2012-08-22 15:05:11 -07:00
Max Goodman
81caf1213d Add support for multiple scopes per OAuth2 access token. 2012-08-22 15:05:11 -07:00
Max Goodman
35006858cb Clean up VClientID validator. 2012-08-22 15:05:11 -07:00
Dave Pifke
51c35458bb Implement revoke/remove/delete buttons on /pref/apps. 
These are ynbuttons, which cannot appear within an existing form.
Thus the "delete app" link appears in an awkward place and the
"remove developer" link currently won't work at all.  chromakode
said he was going to take a look at modifying ynbutton to fix this.

This commit fixes a bug in the OAuth2Client.delete().
 2012-08-22 15:05:11 -07:00
Dave Pifke
b388dc979f Creating and updating apps now works. 2012-08-22 15:05:11 -07:00
Dave Pifke
d7fbadfcd7 Start building view for managing apps. 2012-08-22 15:05:11 -07:00
Dave Pifke
6d293a08bc Add API methods for managing apps. 2012-08-22 15:05:11 -07:00
Dave Pifke
808336ccd8 Fix AttributeError on OAuth2Client.deleted. 2012-08-22 15:05:11 -07:00
Dave Pifke
fe907eb1c4 Navigation for "apps" tab on preferences. 
Adding some controller code and template for the apps tab.  Currently
just a skeleton.
 2012-08-22 15:05:11 -07:00
Dave Pifke
576557244d Tweaks to OAuth2 models. 
Adds the clients-by-user lookup, deletion of clients, and renames
some classes and methods to be more consistent.
 2012-08-22 15:05:11 -07:00
Dave Pifke
cc40171cf5 OAuth client/token relationships with Accounts 
Update the models to be able to update and query:

 - Which OAuth2Clients are developed by a user?
 - Who are the developers of an OAuth2Client?
 - What OAuth2AccessTokens are outstanding for a user?

There's some duplicated code here, and tests are needed, but it's
functional.
 2012-08-22 15:05:11 -07:00
Max Goodman
56a1d9054b Refactor state value passing to OAuth2 error responses. 2012-08-22 15:05:11 -07:00
Dave Pifke
9001852a40 Pass the state value in OAuth2 error redirects. 2012-08-22 15:05:11 -07:00
Dave Pifke
961495b003 Refactor /api/v1/authorize error handling. 2012-08-22 15:05:11 -07:00
Dave Pifke
c826725c3c Add error message to OAuth2 invalid redirect URI failure. 2012-08-22 15:05:11 -07:00
Jason Harvey
367c4201a3 Add accounts_active information to the JSON template. 2012-08-22 11:04:15 -07:00
Jason Harvey
90fb87da88 Modify display of accounts_active info. 
This now relies on the fudged number from subreddit.py for obscurity.

Rewords the default text, and title text of the metric.

Adds a "fudged" class to the block so that low values can be hidden through CSS.
 2012-08-22 11:04:15 -07:00
Jason Harvey
97eb911710 Add a random jitter to accounts_activity metric. 2012-08-22 11:04:14 -07:00
Max Goodman
034aeef022 Stop stripping unicode characters from subreddits_by_topic. 2012-08-21 16:37:18 -07:00
Max Goodman
62792b8731 Use SearchQuery in subreddits_by_topic. 2012-08-21 16:37:18 -07:00
Max Goodman
ca2a05fa34 Return Subreddit objects from subreddit_facets(). 2012-08-21 16:37:18 -07:00
Max Goodman
7dbb0ad337 Add faceting param to CloudSearchQuery. 2012-08-21 16:37:17 -07:00
Max Goodman
2a0dfb4f40 Rename "facets" -> "faceting" in search funcs. 
To avoid confusion with "facets" in search result sets.
 2012-08-21 16:37:17 -07:00
Max Goodman
4208ea88f7 Underline search facets on hover. 2012-08-21 16:37:17 -07:00