Commit Graph

461 Commits

Author SHA1 Message Date
Max Goodman
77b7cfac36 Add loggedin/logged out differentiation to Google Analytics. 2011-05-27 16:01:13 -07:00
Neil Williams
a34347914b code.reddit.com -> github.com/reddit 2011-05-25 10:40:36 -07:00
Neil Williams
3e4df6cb10 Merge pull request #77 from andre-d/bugfix2
Fix #62
2011-05-23 11:10:57 -07:00
Andre D
d0b285e9fd Fixed https://github.com/reddit/reddit/issues/55 2011-05-20 15:52:11 -07:00
Neil Williams
e992c16d99 Fix incorrect use of abort in submit perms check 2011-05-20 15:05:00 -07:00
Neil Williams
cf00e28619 Better handle invalid IndexTank queries. 2011-05-20 15:04:27 -07:00
Andre d
cbb217cbc5 Fixed https://github.com/reddit/reddit/issues/62 2011-05-20 15:36:20 -04:00
Andre D
5a33ecca90 Fixed searching for a url without being logged in 2011-05-19 15:10:13 -07:00
Max Goodman
319dbc036a Properly handle a nonexistent shortlink. 2011-05-18 12:55:26 -07:00
Max Goodman
d7d608e240 Fix the type of the fetch_links links parameter.
Since updating jQuery, the library has new behavior for deep serializing
objects and arrays. This old code accidentally passed in an array, which
triggered the new serialization code. The old code was taking advantage
of the older shallow jQuery parameter serialization, which calls
toString(), combined with the fact that singleton Arrays in JS stringify
into their first item stringified.
2011-05-18 12:55:26 -07:00
Max Goodman
0506b124c5 Fix /submit captcha 404 on reddit mobile. 2011-05-17 17:42:01 -07:00
Max Goodman
f685046d13 Update mobile to jQuery 1.6.1. 2011-05-17 16:13:19 -07:00
Max Goodman
81c7705556 Merge pull request #67 from jsocol/master
Add protocol to <link rel="shorturl">
2011-05-17 15:54:09 -07:00
James Socol
fb7fedee2e Add protocol to shorturl header link. 2011-05-17 18:36:49 -04:00
Max Goodman
18cdeee38d Add is_gold parameter to user JSON. 2011-05-17 15:17:45 -07:00
James Socol
2566c0c13e Add canonical shorturls to the header. 2011-05-17 15:17:44 -07:00
Max Goodman
2db04c9085 Do not wait until jQuery ready before firing a pixel. 2011-05-17 15:17:44 -07:00
Max Goodman
c5fd5ecd55 Remove reddit.css and sprite.png upon make clean. 2011-05-17 15:17:44 -07:00
Max Goodman
13894a7a10 Convert to RGBA to fix an alpha channel rendering issue with PIL/nymph.py. 2011-05-17 15:17:44 -07:00
Max Goodman
5e2f134b95 Make template_debug skip stripping whitespace. 2011-05-17 15:17:44 -07:00
Max Goodman
e4fd6a267d Fix styling of the sponsored link targeting subreddit completion dropdown. 2011-05-17 15:17:44 -07:00
Max Goodman
618b9e8d1d Upgrade to jQuery 1.6.1 loaded from the Google CDN. 2011-05-17 15:17:44 -07:00
Max Goodman
69fb28cc32 Update Socialite static files for 1.4.0 release. 2011-05-17 15:17:44 -07:00
Neil Williams
14fa058d32 Make disable_ads a boolean property. 2011-05-16 14:53:45 -07:00
gabe
92fdd422fb Added option to disable captcha verification 2011-05-16 14:53:20 -07:00
westmaas
e6178bedb1 Make default header image URL configurable. 2011-05-16 14:52:15 -07:00
gabe
63d518f4c9 Make min age for subreddit creation configurable. 2011-05-16 14:52:09 -07:00
westmaas
d411cd55a6 Added support for disabling adds via config file 2011-05-16 14:52:03 -07:00
Max Goodman
2b3b0616c1 Add /api/me resource to fetch user info + modhash. 2011-05-09 14:15:25 -07:00
Max Goodman
d8348f6c87 Modify validate_json semantics to work properly for pure JSON api resources. 2011-05-09 14:15:17 -07:00
Neil Williams
676f71a211 Upgrade to pylibmc 1.1.1.
* Fixes app segfaults when memcache not available.
* Remove "time" parameter from r2.lib.cache.CMemcache.delete_multi
  since it never worked anyway and was removed from pylibmc.
2011-05-09 14:13:05 -07:00
Neil Williams
4007764965 Don't crash when children not viewable. 2011-05-02 23:36:00 -07:00
idonthack
2c3379c5e3 comment permalinks in xml feeds are now valid URIs
previously, comment permalinks in xml feeds were missing the scheme and
authority segments (protocol and hostname). this caused problems with
feed readers and other programs that expected to encounter a valid URI.
2011-04-20 15:27:03 -07:00
Neil Williams
400910ec0a Optimized a whole 'nother bunch of PNGs. 2011-04-20 14:05:38 -07:00
Janne
3462a4b23d Recompressed PNG images for smaller size
Ran the PNG files in static/ through OptiPNG and AdvPNG for smaller file
size.
2011-04-20 11:57:15 -07:00
Neil Williams
68a06c568b April 2011 Merge
* Show "this post is archived" message for things we won't allow votes on.
* Don't mark messages read when pulled via RSS
* Make compact (smartphone) interface respect user's toolbar
* preferences.
* Make mobile interface more friendly for kindles.
* Fix bug that caused comment tree corruption.
* Use cachebuster on traffic pixel for more accurate tracking.
* Make apps restart themselves after a configurable number of requests.
* Move to pycassa 1.0.8.
* Fix bug in calculations for "best" sort.
* Fixes for Firefox Mobile
* Add a global flag to disable editing of the wiki.
* Move the child-comment collapse button to the left.
* Updated list of disallows in robots.txt to save needless hits from
  crawlers.
* Fix vote_q by splitting it into vote_link_q and vote_comment_q.
* Fix bug where /reddits crashes due to 'promos' subreddit.
2011-04-18 16:30:48 -07:00
ketralnis
7fff900bbe February 2011 Merge
* Upgrade discount to 1.6.8
* Start reading Votes, Saves, and Hides from Cassandra (while still dual-writing all three)
* Some XSS fixes
* Significant Gold buying and gifting improvements
  - Move /api/ipn to /ipn
* Allow non-US countries to buy sponsored links
* Increase embed.ly scope
* redd.it support
* Allow postgres port number to be specified in ini file (this changes the format of the .ini file)
* Upgrade Cassandra to 0.7
  - Change g.urlcache to LinksByURL
  - Translate storage-conf.xml to cassandra.yaml
  - TTL support (and enable on Hides)
  - Move permacache keyspace to inside reddit keyspace
* The stalecache: a local memcached that contains slightly old information to speed up some lookups
* Switch to patched Paste that is hopefully download.gz-proof
* Don't store votes on things > 30 days old
* Many many bugfixes/small features
2011-02-23 12:00:44 -08:00
Ryan G
c78f27b4ae Add gold to the footer (thanks gelob) 2010-10-20 10:11:06 -07:00
Markus Gaisbauer
ccedf29d80 Generate comments trees in populate_db 2010-10-18 17:33:54 -07:00
ketralnis
f81c9261be Add missing psql function domain (thanks sjuxax) 2010-10-18 14:56:54 -07:00
ketralnis
7c8ea0b1fc Apply reseph's patch to make the subredditinfobar have a link to the
subreddit's front page
2010-10-18 14:49:45 -07:00
ketralnis
e9b57a5721 Apply Gelob's patch to make the RSS feeds validate 2010-10-18 14:42:17 -07:00
ketralnis
602f1f6904 Apply patch from Preston4tw (Preston Bennes <preston.bennes@gmail.com>)
to make /r/foo/comments work
2010-10-18 14:38:59 -07:00
ketralnis
37e2ba9892 * Combine cassandra clusters into a single one
* Add a new Cassandra CF for comment-sort caching
* Add JSONP support
* Support non-auto-renewing PayPal IPNs
* Gold accounting
* Gold features: comments tracking, larger comment limit
* Autorenewing gold
* Google checkout support
* Profile-page sorting for all
* Title-text on the logo
* Hardcache sharding and profiling
* Self serve enhancements
* Add /r/foo/faq
* Make self-centred reddits allow for more verbose selftext
* Much better down-handling of databases
* Add the ability to take a thread-dump from a running process
* Remove the comscore tracker
* Add comments to modqueue (does not back-populate)
2010-10-18 11:52:44 -07:00
ketralnis
0ae8f2fb96 21 Jul 2010 merge
* Use Flaptor's Indextank product for search, including santip's patch
* for their new API
* Add Cassandra ConsistencyLevels to the ini file, and storage-conf.xml
* to the public repo
* Patch contributed by umbrae in ticket #929: Add jumpToContent support
* for Keyboard Accessibility
* reddit gold
    - paypal/postcard support
    - friends with benefits
    - profile-page sorting for gold members
    - move domain listings into the permacache
2010-07-21 17:48:12 -07:00
Christopher Slowe (KeyserSosa)
52da322156 Bugfixes:
* no-repeat on some background images in the sprite (#797)
     * fix deleted comments on the mobile site -- preserve author anonymity (#624
     * faulty permalinks on pages with all unicode title (#776)
     * no more spreadshirt
     * reorganize comment_tree and _builder.pyx to clean up cache handling
     * fix styling for Bug #78
     * Improve handling of /r/all+all (bug #699), etc (not always a 400 now)
     * Fix the time listings: sometimes we get passed unicode for self.time
     * Don't allow private reddits to show in /r/random
     * Try to allow remote sites to show their own favicons in the reddit
        toolbar

  Speed improvements:
  * CommentBuilder refactor rount 1:
     * create new sort and parent permacache entries so that we don't need to loa
     * update sorts and parents when a new comment comes in
     * update non-date sorts when a new comment vote comes in
     * add more trace info to timeouts in CommentBuilder
  * Some misc. performance hacks (incl. adding _utils.pyx)
  * Increase SR description box limit from 1k to 5k
  * Fix a bug where we weren't properly allowing hidden items to be hidden
    on time-filtered listings
  * Make Subreddit._by_name take a list of names like byID
  * Upload thumbs to S3 with reduced_redundancy==True
  * make rss feeds without a 'feed' get parameter act as if the user is not logged in
  * Require a boto that knows about reduced_redundancy
  * remove fast_queries from Message.add_props and put the onus on fetching the unread messages from the permacache
  * Store the list of popular subreddits in the permacache
    * make SubredditTopBar cacheable per-user.
  * add (as safe as we can make it) annotation for sql selects to track down requests hitting the db when they shouldn't be.

 User submitted features:
  * Merge and clean up Phire's selfs-only/no-selfs patch.

  * Don't show expired items on time-filtered controversy listings

  * Also add the 'hide' button to the toolbar just for breakneckridge.
    Next time someone calls me prickly, breakneckridge had better step
    up to the plate for me or I'm rolling it back.
2010-06-25 17:36:51 -07:00
KeyserSosa
9a4271f641 Upgrade Instructions
====
   * Uninstall the python Cassandra package that we previously depended on (it has a namespace conflict with the new package we depend on).  To find it:

     $ python -c "import cassandra; print cassandra.__file__"

    and rm -r the .egg directory after "site-packages/"

   * This version relies on cython, so if "make" fails, you may have to install cython via your distro's package manager.

     $ cd reddit/r2
     $ python setup.py develop # possibly with "sudo" depending on your install
     $ make

   * Cassandra is now required for the caching layer.  An example storage-conf.xml can be found in reddit/srv/cassandra.  Make sure that the additional <Keyspace> items are included in your conf file.

   * remove the query_queue_reader services if they are running.  add new gen_time_listings.sh instead.  Suggested cron:

    0    */2 *   *   *   $SCRIPTS/gen_time_listings.sh year '("month","year")'
    */5  *   *   *   *   $SCRIPTS/gen_time_listings.sh week '("day","week")'
    *    *   *   *   *   $SCRIPTS/gen_time_listings.sh hour '("hour",)'

   where $SCRIPTS is the location of this script directory

Features and Bugfixes
====
 * Mobile reddit:
   * templates are in r2/templates of the form *.compact
   * css is r2/public/static/css/compact.css
     * beginning of a sass-based (http://sass-lang.com/) compact.scss
   * reachable via .compact extension or from the "i" subdomain.
 * Cassandra is now *required*, and votes are currently written out to both cassandra and postgres (part of an eventual migration).
 * attempt to make the db connection code a little smarter.
   * A dropped DB connection will mark the connection dead and randomly attempt to reconnect.
   * A dropped db connection on start will permanently mark the connection as dead.
 * Calculate the time-filtered top/controversy listings using mapreduce instead of prec_links (new cron job in reddit/scripts)
 * allow default user/pass for database to be specified with '*' to fallback on db_user and db_pass in the INI file
 * Search feedback buttons
 * make deleted comments not show up in your inbox.
 * move last_visited into cassandra
 * Swallow rare, race-conditiony POST_save/hide/subscribe problems
 * Apparently we haven't been breaking properly for the past few weeks.
2010-06-16 17:01:50 -07:00
KeyserSosa
08c431bd85 * Comply with the spec on 304 errors so Chrome won't barf download.gz all over the place
* The error pages have been broken for the past week.
 * Fix /r/all+all
 * Provides about.json to the api for subreddits (it already works for users)
 * Make sure Accounts have data before checking their name and msgtime
 * new bigger arrows for mobile site and a the alien is fingerless now
 * Try to update the _fast_query_timestamps less often to alleviate some of the load it causes on the Accounts DB
 * Swallow rare, race-conditiony POST_save/hide/subscribe problems
2010-05-28 14:55:13 -07:00
KeyserSosa
1d9b9fe72c * transparency updates to some of the pngs thanks to ytknows
* bugfixes in unicode handling
 * Nag nonparticpating jurors 20% of the time
 * fix thumbnails for sponsored links
   * non admins can't change the thumb of a live link
   * the uploader updates the status properly to 'saved'
2010-05-21 16:30:54 -07:00
KeyserSosa
d251ba757d * Improvements to the email verification system
* addition of the 'powered by reddit' footer
2010-05-20 11:39:29 -07:00