David Wick
8ef0d66922
Comment embeds: add feature flag
2015-02-23 18:09:54 -08:00
David Wick
9584157319
Remove new login flow feature flag
2015-02-23 18:09:54 -08:00
David Wick
77ff39a511
Remove dead compact login code
2015-02-23 18:09:54 -08:00
David Wick
cc585b9345
Refactor modals to use a common component
2015-02-23 18:09:54 -08:00
David Wick
e5d579e020
Comment embeds: add UI for creating embed code
2015-02-23 18:09:54 -08:00
David Wick
6493c95ea2
Remove unused css
2015-02-23 18:09:54 -08:00
David Wick
3349dda147
Comment embeds: add support for data attributes in menus
2015-02-23 17:38:52 -08:00
David Wick
7acbd4d6b0
Comment embeds: support including scripts using absolute paths
...
This is useful for generating the script tags needed by the embed
snippet in such a way that it works for both dev and production
environments.
2015-02-23 17:38:43 -08:00
David Wick
cb70bc65d9
Comment embeds: add bootstrap modal
2015-02-23 17:38:37 -08:00
David Wick
47edd7e3d2
Comment embeds: add new framable template
2015-02-23 17:37:58 -08:00
David Wick
01e124c52b
underscore.js: Remove "/" as an escape character
2015-02-23 17:36:20 -08:00
David Wick
88e7eaab9d
Ensure namespace is defined
...
Previously this timings snippet assumed that window.r was an
defined and an object. This ensures we don't throw errors as a
result for admin bar timings.
2015-02-23 17:36:13 -08:00
David Wick
caeab56e17
Gold: remove unused/broken tracking
...
This was causing issues with people who have adblock/ghostery and
is no longer being used so I removed it.
2015-02-23 11:46:12 -08:00
Chad Birch
64c7f0bfdf
Captcha JS: use siblings()
...
Previously this was looking for a parent <form> and then searching for
the hidden iden input inside that form. siblings() is much more
efficient and removes the dependency on a parent form existing (which it
doesn't, on the create subreddit page)
2015-02-20 10:34:59 -07:00
David Wick
89df798970
Ads: Fix AttributeError caused by rename
2015-02-19 18:58:33 -08:00
David Wick
5e13579900
Ads: Show ip/country mismatches to sponsors.
...
This allows sponsors to review payments that come from outside
the billing credit card address.
2015-02-19 16:17:54 -08:00
David Wick
6d4f9ec2b1
Ads payment: use standard country names
2015-02-19 16:17:04 -08:00
David Wick
f9f34ec539
app_globals.py: Add locations
2015-02-19 16:16:53 -08:00
Robert Ditthardt
decac6c13c
Multis: Do not redirect api requests
2015-02-19 14:30:13 -08:00
Robert Ditthardt
3d455ed05c
Multis: Add limit on fetching multis
...
This uses Subreddit.random_reddits to limit the number of subreddits
requested to build a multi. The limit is defined in
LabeledMulti.MAX_SR_COUNT
2015-02-19 14:30:13 -08:00
Keith Mitchell
d3fea5e60c
Multis: Allow listing requests for multiple multis
...
URLs of the form /user/<name>/m/<multi>+<multi>+<multi>+...
will be converted to an anonymous multi comprised of the
union of all subreddits in the named multis.
2015-02-19 14:30:13 -08:00
David Wick
22f7e4daea
analytics.js: Ensure GA callbacks are called.
...
If for whatever reason ga fails to call the callback in a
reasonable amount of time (500ms) then fire it off anyway. One
instance where this was biting us was, an addon for firefox
(ghostery) was stubbing out `_gaq.push` with a noop, causing any
functions pushed into it to never be fired.
2015-02-19 14:22:51 -08:00
David Wick
6f6c4acb0f
analytics.js: Fix code style
2015-02-19 14:21:37 -08:00
David Wick
7f0f31b78f
analytics.js: Use 2 space tabs
2015-02-19 14:21:32 -08:00
David Wick
ca305cb880
Gold: Add funnel events for inline gilding
2015-02-19 14:21:25 -08:00
David Wick
eb6af40d20
Ads: do not track sponsors in funnel
2015-02-19 14:21:15 -08:00
David Wick
3bff0d250e
Future promos: Hide links after being rejected
...
Links that have been rejected should be removed from the page when
the sort is "unseen".
2015-02-19 14:21:07 -08:00
David Wick
6f7fa8aa68
analytics.js: Add optional callback to #fireGAEvent
2015-02-19 14:21:01 -08:00
David Wick
a98e0751e9
Future promos: Hide links after approval
...
Links that have been approved should be removed from the page when
the sort is "unseen".
2015-02-19 14:20:50 -08:00
David Wick
25c22cb295
Remove reference to /r/promos from user pages
2015-02-19 14:20:08 -08:00
David Wick
c93451d317
Ads: ad creation flow funnel tracking
2015-02-19 14:19:57 -08:00
David Wick
8a38390f26
Add hook for successful ad buys
2015-02-19 14:19:49 -08:00
David Wick
d3dca3ba4a
Flagged promotions: display multiple reasons
2015-02-19 14:19:43 -08:00
Trevor Senior
d0beab632e
cache: Import random.
2015-02-18 11:37:38 -05:00
Brian Simpson
28e140d05d
Message.add_props: Use subreddit attribute set by Builder.wrap_items.
2015-02-18 11:37:32 -05:00
Jordan Milne
6cbbabb9a9
Keep a separate list of subdomains that can't be in c.domain_prefix
...
I forgot how insanely brittle this bit of code is since I last tried
messing with it last year. At some point we might want to look into
deprecating everything but oauth., the lang subdomains, and www. To
hell with `www.ssl.circlejerk.json.reddit.com`.
2015-02-18 14:50:41 -08:00
Avinash Dwarapu
dc47412df4
Change /{article}/related to /related/{article} in API docs
...
Frankly surprised this error hasn't been caught...
2015-02-18 14:01:50 -08:00
Brian Simpson
bb07898dcf
Use c3.2xlarge instance for EMR hourly traffic log processing.
2015-02-18 03:57:54 -05:00
Chad Birch
bc73cef822
Subreddit creation: add captcha
2015-02-18 13:22:36 -07:00
Chad Birch
6ae6a1e931
Subreddit creation: remove nonfunctional check
...
This didn't actually even do anything.
2015-02-18 13:21:55 -07:00
Chad Birch
bc1d082a14
Inbox count: add to JSON
2015-02-18 13:21:07 -07:00
Chad Birch
2c8995603a
Inbox count: remove feature flag
2015-02-18 13:21:01 -07:00
Chad Birch
18e922f8b2
butler_q: handle CreationError when inserting
2015-02-18 13:20:44 -07:00
Brian Simpson
5ff830f8d4
StaleCacheChain: record cache hits and misses.
2015-02-17 18:09:27 -05:00
Brian Simpson
cd88707fdb
cache: Add timers.
2015-02-17 18:09:20 -05:00
Neil Williams
198e67fe97
Reduce gzip threshold for main caches to 1400 bytes.
...
The goal here is to reduce network traffic to the main cache nodes.
This will also affect the size of the objects in the cache which could
make things better by fitting more things in cache, or make things worse
by oversubscribing specific slabs. We should watch network traffic on
the cache nodes, hit rates, and eviction rates in the period after
rolling this out. Additionally, this will increase the amount of
gzipping app servers deal with, so response times and CPU should be
monitored as well.
I chose 1400 bytes to be a fudge-factor smaller than the MTU; since the
goal here is network efficiency and not cache memory space, going
smaller than a single packet isn't terribly important.
2015-02-13 17:49:29 -05:00
Brian Simpson
705c4f1992
inventory: Correctly retrieve transactions for freebie campaigns.
2015-02-13 15:04:02 -05:00
John-William Trenholm
9e64e56960
tracker.py: use env var for configuration file
...
Upstart needs to use a environment variable to determine the
configuration file.
2015-02-12 16:00:04 -08:00
Neil Williams
f94e9cc14e
install-reddit: Upgrade Cassandra and use DataStax repos.
...
This modernizes install-script reddit a bit, as we're already running
1.2 in production.
Note: this upgrades Cassandra from a patched 1.0.7 to vanilla 1.2.19. Please see
http://www.datastax.com/documentation/cassandra/1.2/cassandra/upgrade/upgradeC_c.html
for instructions on upgrading which may require some upgrades of the
data on disk.
2015-02-12 13:27:32 -08:00
Neil Williams
f869f10dbc
tdb_sql: Upgrade uses of deprecated last_inserted_ids().
...
This function gets removed in SQLAlchemy 0.8 in favor of the already
present inserted_primary_key.
2015-02-12 13:27:32 -08:00
