We were already tracking creates in the same namespace in tdb_sql.make_thing.
Modify, incr, create, and cache miss all cause Thing to be written to cache.
Tracking these events will let us understand how we're using the cache.
The "is this item in the user's inbox?" check is supposed to be skipped
if the item is a modmail to a subreddit that the user moderates, but the
previous implementation of it also allowed mods to block from any
comment in a subreddit the user moderates.
This change updates the check to make sure that it's a message as well.
Specific features (and test list!)
- [x] no user page visibility (display intersitial instead)
- [X] links in listings removed by default (disabled for moderators)
- [X] comments in listings/trees removed by default (disabled for moderators)
- [X] can't reply to blocked (existing behavior -- retested here)
- [X] block button on messages (existing behavior -- retested here)
- [X] add block button on comment and post replies
- [X] messages: no orangered or inbox
- [X] self posts replies: no orangered or inbox
- [X] self posts comments: no orangered or inbox
- [X] /message/messages/ has no blocked users (comments, post replies, or comment replies)
- [X] /message/inbox has no blocked users (comments, post replies, or comment replies)
- [X] /messages/unread has no blocked users (comments, post replies, or comment replies)
- [X] /comments has no blocked users
- [X] messaging events for PMs (was just mod mail)
- [X] messaging events have with blocked field
- [x] spam messages don't show up
- [x] no orangereds to oneself
- [x] update production.ini to add `events_collector_message_sample_rate`
The button as it stands shows up on local installs, even if automod
is not enabled.
This makes the button only show up if an automod account has been set.
It's important to know that any link posted in the test subreddit will use
the cached results if it's url has been scraped before, and any link posted
*outside* of the test subreddit will do the same, so any tests done here will
leak out if reposted elsewhere on the site.
Also stop extra-quoting them on the backend. Apparently, pylons already quotes cookies on the way out, leading to some cooke being doubly escaped. Correspondingly, aggressively decode loidcreated in JS to counteract any badly-formed cookies.
The thumbnail scraper is crashing on unusual og:image tags, when they
don't have a content= attribute. Example from the wild:
<meta property="og:image">
This just gets rid of the assumption that the attr will be there, so
that it can carry on finding a thumbnail as normal if an unusual tag is
encountered.
Lumen is making some changes to the way they check for authentication
tokens in API requests. Instead of updating this header, we're just
going to remove it since it was already unnecessary to be sending (since
our auth token is being sent in the JSON data).
This will let us see how often different number of comments are viewed
and how much time it takes to generate the order. This will help us decide
how to set precomputed_comment_sort_min_comments.
