Grant URI: https://oauth.reddit.com/grants/installed_client
This minor extension grant allows non-confidential
OAuth2 clients to request user-less OAuth2 tokens.
Consumers should provide a unique ID, and re-use that ID
for subsequent token requests from the same device. ID
generation is left up to the client.
This is separate from client_credentials so that the
client_credentials grant can conform to the official spec.
Installed apps are considered "public" as part of the
OAuth2 spec (unable to keep a secret). Don't
show a secret for such apps on the /prefs/apps page,
and don't check the secret as part of client identification
for such apps.
This implements the client_credentials grant type.
This allows 3rd parties to use the OAuth domain for
logged out (user-less) API access in addition to existing use for
logged in access.
The intent of this patch is to refactor the existing vote-casting code
into a state that's ready for pgvotes to be dropped and replaced with
reads from VoteDetailsByThing. Ideally, no behaviour is changed by this
patch (hence "refactor") and then the later data model change will be
lower risk as a result of less code shuffling.
Once this patch is applied, the `Vote` class/rel is considered an
implementation detail of the vote module and hidden from public view.
In reddit/reddit@76858eb, I expanded the places we could use the report form.
Unfortunately, it got caught by a CSS rule on the reddit gold payment page that
made it visible, despite not being at all useful on that page. :)
Now that CSS rule is slightly more scoped. The only other `<form>` that's
inside `.gold-payment` but **not** `.gold-wrap` is the share dialog, which has
an inline style hiding it.
To avoid debate over "login" the noun and "log in" the verb, we're making a
move towards using "sign in" instead. The first part of this was done in the
login rework in reddit/reddit@c4f5b6c2.
This commit continues to make our verbage consistent on "sign in" and "create
an account", avoiding use of "log in" and "register". Specifically, these
should all be consistent:
* Upper-right modal-popping text
* Headers on modal and /login
* Buttons on modal and /login
* Page title on /login
I didn't change the text in the old login flow, because that feature flag seems
like it's going to be pruned soon.
We want to ditch the postgres-based vote relations as they are not being
used for much right now and make a large ops burden as they use a
massive amount of space.
These column families should take care of one of the last unserved use
cases for votes: day-based data dumps: the about page shows a count of
votes day-to-day, and some awards use yesterday's votes to determine
winners.
I've chosen to use Pacific time because that's when award cron jobs run
and is generally still how we think about "day"s since we're here in SF.
Based on feedback from the /r/modnews post:
* font sizes are now em based, and respect browser default font size preferences
* grey text for blockquote and del elements is darker, meets AA accesibility guidelines
* bold/italics style combinations fixed
* removed larger font sizes for wiki pages
* reduced a lot of the margins and altered some of the line-heights. pages should be
more compact vertically
This should make the markdown styles respect users' browser
preferences better.
In reddit/reddit@c4f5b6c2, we accidentally broke the language-selector modal
that appears in the top-right when logged-out (when logged-in language is
changed from your preferences). The `<div>` that gets popped up snuck up
inside one of the many if-statements in that section, which resulted in it not
getting added to the html on pages where we want to hide the login modal link
(currently only login pages). This restores it, so you can once again change
your language while on /login.
Last change needed to allow for a smooth transition between old and new styles.
This lets stylesheet authors target any styles needed for backwards-compatibility
to 'body.old-markdown'.
Stop gap solution until multiple targets can be added for a single
campaign. Allows people to set up many similar campaigns without
having to start again from scratch.
