Neil Williams
c7f92ca960
Factor out HTTP Basic auth header parsing code for re-use.
2012-08-31 11:38:57 -07:00
Keith Mitchell
05ee678362
Check for c.user before grabbing pref_local_js
...
During some errors, additional tracebacks
were being generated due to the attempted
reference to c.user before it had been properly
set. This should protect against that and let
the proper errors go through.
2012-08-31 11:36:42 -07:00
Keith Mitchell
127e890f5e
Search: Sort by number of comments
2012-08-31 11:36:37 -07:00
Keith Mitchell
4327c8d15c
Fix unicode for plain syntax queries
2012-08-31 11:36:29 -07:00
Keith Mitchell
34418630d6
Let subreddits_by_topic use plain syntax
2012-08-31 11:36:22 -07:00
Keith Mitchell
1dea92c1de
Ensure that unicode is being passed to l2cs
...
This is in preparation for some enhancements
to l2cs that require it to have a decent interface
(i.e., it's going to require unicode rather than
accepting either byte strings or unicode)
2012-08-31 11:36:17 -07:00
Neil Williams
a8c6631c40
Comment Pane Cache: make cache lifetime configurable in INI.
...
This allows us to independently vary it on some servers via ini file
(i.e. fastlane).
2012-08-30 13:28:47 -07:00
Neil Williams
3812f7ba8f
Comment Pane Cache: disable caching for the author of the link.
2012-08-30 13:28:47 -07:00
Neil Williams
cb1d625b1a
fastlane: Make commentstree_q have a fastlane counterpart.
...
This allows us to isolate gigantic comment threads from the rest of the
system.
2012-08-30 13:27:12 -07:00
Neil Williams
c337280e47
fastlane: Separate votes on some links and their comments.
...
If a specific link has ridiculous traffic, we can inform the
apps (via ZK live config) that votes on it should be sent to a
separate, dedicated, queue to avoid overwhelming the rest of the
system.
2012-08-30 13:27:12 -07:00
Neil Williams
5ba0618963
queries: Parameterize queue name for run_commentstree.
...
This allows us to reuse the code for a queue of the same meaning but
different name (i.e. a commentstree fastlane).
2012-08-30 13:27:12 -07:00
Neil Williams
1b6423a073
example.ini: Document subreddit suggester live config options.
2012-08-30 13:27:11 -07:00
DEADB33F
7d3986e3d4
Added 'body.moderator' class to /r/mod and mod-multireddit pages.
2012-08-28 16:20:37 -07:00
Courthold
02c73e7dd2
Add mobile CSS rule to highlight the submitter within the comments.
2012-08-28 16:20:37 -07:00
Matt Rasmus
312da0e997
Remove 'import pylons.config' import.
2012-08-28 16:20:37 -07:00
listen2
52c8463dfa
Fix malformed HTML entities.
...
Found with grep -P -I "&[[:alnum:]#]++[^;=]" * -R
2012-08-28 16:20:37 -07:00
rolmos
102e83fdef
Fix overflow issues with long titles in .compact.
2012-08-28 16:20:37 -07:00
Max Goodman
61fe3dc136
Fix missing interest bar template errors on compact and mobile.
...
The InterestBar template is rendered on /reddits/ and will error out
for compact and mobile unless a template file exists. Since we don't
have a version for compact or mobile yet, just use empty templates.
2012-08-28 16:20:37 -07:00
Max Goodman
aa6e2dc2c8
Update compact .scss file to sync up with .css.
2012-08-28 16:20:37 -07:00
shlurbee
c9d209c5ab
Make campaign fullname available in spotlight
...
Adds campaign to weights of current promos and passes it up to the
spotlight render function to make it available for tracking at runtime.
Notes about rollout:
- This change modifies the live promotions data structure stored in permacache.
To prevent exceptions during rollout, it adds a version number to
the promotion key. Preload the new data structure before pushing this
change by running promote.make_daily_promotions() from staging with the
new code.
2012-08-28 16:06:26 -07:00
shlurbee
53fc3f2c26
Remove dead code
2012-08-28 16:06:22 -07:00
Logan Hanks
7592e36d0f
Show authorized apps on the account activity page.
2012-08-28 11:24:23 -07:00
Logan Hanks
02f1490cb6
Revoke oauth2 access tokens when a user clears sessions.
2012-08-28 11:24:23 -07:00
Logan Hanks
1d50982611
Add apidoc to /api/v1/me.json.
2012-08-27 14:14:40 -07:00
Logan Hanks
5b5754b2e2
Add oauth scope info to apihelp.
2012-08-27 14:14:37 -07:00
Max Goodman
633a710491
Replace abort() to pass exception info to error pages.
2012-08-24 15:40:22 -07:00
Neil Williams
f6a994eff6
make_lock: Add Graphite tracking of lock wait times.
...
This commit deliberately does not muck with the keys used for locking so
that we don't need a downtime to get these statistics.
2012-08-24 12:10:55 -07:00
Max Goodman
8b3e0175ab
Remove stray close tag.
2012-08-24 11:49:18 -07:00
Max Goodman
f5ffcf5d81
Remove redundant <meta> title tag.
2012-08-24 11:49:17 -07:00
Max Goodman
1e448b68dd
Add alt tag to "Powered by reddit" image.
2012-08-24 11:49:17 -07:00
Max Goodman
4c2c050619
Truncate microseconds off <time> datetime attributes.
2012-08-24 11:49:17 -07:00
Max Goodman
af326aae15
Whitespace.
2012-08-24 11:49:17 -07:00
Max Goodman
9bb83901f3
Switch to html5 doctype and add html5shiv.
2012-08-24 11:49:17 -07:00
listen2
6ebac049cd
Fix typo in docstring.
2012-08-24 11:05:34 -07:00
Keith Mitchell
7799bb5db4
Makefile: Use correct path for r2.pot
2012-08-24 10:16:10 -07:00
Neil Williams
5626376497
MFA: Change key username to "/u/username on domain" to avoid conflicts.
...
{username}@{domain} was conflicting with other services which had
similar formats (such as GAFYD). This makes it easier to identify
your reddit account among the other authenticators.
2012-08-23 12:26:54 -07:00
Neil Williams
6a2a0210e1
Move /comments to new query cache.
...
This is another attempt at doing so. We're now using the Leveled
Compaction strategy for SubredditQueryCache and have drastically reduced
gc_grace_seconds (to half an hour). This should ameliorate the tombstone
pileup issues we ran into last time.
2012-08-23 12:26:54 -07:00
maxwellhansen
5f6efe5a6e
install-reddit: Replace another instance of old bash redirect syntax.
2012-08-23 12:26:54 -07:00
Neil Williams
cc1b087c10
CloudSearch: Fix AttributeError when record_stats = False.
...
While the stub-timer I introduced earlier takes care of some issues, it
doesn't take care of when we explicitly set the variable to None!
2012-08-23 12:26:54 -07:00
Neil Williams
c449212f29
traffic: Fix zip_timeseries for when a series has no data at all.
2012-08-23 12:26:54 -07:00
Max Goodman
8929e17f88
Remove "referer" from js_config.
...
Removes XSS reported by jomkr where referer contains "</script>" in IE.
2012-08-22 17:15:24 -07:00
Keith Mitchell
ab306a0423
Search: Squash misuse of datetime.strftime
2012-08-22 15:38:42 -07:00
Neil Williams
6e63366649
tdb_sql/Thing: Remove now-unnecessary UPDATE/INSERT stats tracking.
2012-08-22 15:38:42 -07:00
Neil Williams
5c177fa615
vote_q: Track how long various parts of vote processing take.
2012-08-22 15:38:42 -07:00
Neil Williams
40d234110b
vote_q: Remove unused process_votes_multi.
2012-08-22 15:38:42 -07:00
Neil Williams
31fad45031
stats: Clean up now-unnecessary checks for Timer validity.
2012-08-22 15:38:42 -07:00
Neil Williams
a613f7b17e
stats: Make get_timer return a stub object if Graphite disabled.
...
This saves us from having to do explicit checks for whether or
not the timer exists everywhere we use them.
2012-08-22 15:38:42 -07:00
Logan Hanks
5e9e943f8b
Make OAuth2AuthorizationCode.user_id an id36.
2012-08-22 15:05:25 -07:00
Logan Hanks
533afca2e5
Add oauth_domain to globals, and add to secure_domains.
2012-08-22 15:05:20 -07:00
Logan Hanks
bbc97f841f
Use integer user id when creating authorization codes.
2012-08-22 15:05:12 -07:00