github/reddit
1
1
Fork 0
mirror of https://github.com/reddit-archive/reddit.git synced 2026-04-27 03:00:12 -04:00
Code Issues Packages Projects Releases Wiki Activity
7,161 Commits 1 Branch 0 Tags
cfd5dea2ccc84eb11e3ea875795e00a3acfc3bea
Commit Graph

7161 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matt Lee
cfd5dea2cc Subreddit Rules: Remove action-form css class 
This is binding some extra event handlers to be bound in
action-forms.js that aren't needed on the new form.
 2016-01-25 13:17:25 -08:00
Matt Lee
442557af72 Subreddit Rules: Cache subreddit rules with sessionCache 
Should reduce the number of requests that make it to the API.
 2016-01-25 13:17:25 -08:00
Matt Lee
71d11a8186 Subreddit Rules: Render report form client side 
Refactor the rules templates to enable rendering on the client while
keeping HTML api in place for the time being.
 2016-01-25 13:17:25 -08:00
MelissaCole
0b9287e17f Subreddit Rules: Add ability to edit type of rules 2016-01-25 13:17:25 -08:00
MelissaCole
9b30aff2a7 Subreddit Rules: Support separating types for comments and posts 2016-01-25 13:17:25 -08:00
Matt Lee
5ba63efb13 Subreddit Rules: Remove XSS sinks 
The initial rendering of the rules is done in mako, but all subsequent
rendering of the rules is done client-side. Using the wrong template
tags here creates an unnecessary vulnerability that could be used to
XSS attack a limited set of users (mods could potentially XSS attack
other mods of the same sub).
 2016-01-25 13:17:25 -08:00
MelissaCole
bceac7117c Subreddit rules: Temporarily handle missing created_utc 2016-01-25 13:17:25 -08:00
MelissaCole
a14df90cd7 Subreddit rules: API changes 
Change `when` to `created_utc` and add `description_html`.
 2016-01-25 13:17:25 -08:00
Matt Lee
117927e49f SubredditRules: Update new report form language. 2016-01-25 13:17:24 -08:00
Matt Lee
ba39e8fdbb SubredditRules: Force modtools.less to rebuild. 
Items in LESS_STYLESHEETS do not automatically rebuild when imported files
change. Items in SPRITED_STYLESHEETS automatically build when any other less
file updates, so that works for now.  Stylesheets run through the spriter
will throw an error if they don't actually contain any sprites, so I added a
dummy sprite rule to modtools.less.
 2016-01-25 13:17:24 -08:00
Matt Lee
d560199aa4 SubredditRules: Fix order and alignment of form buttons. 2016-01-25 13:17:24 -08:00
MelissaCole
da92d99b59 Subreddit Rules: Remove reorder subreddit rules 2016-01-25 13:17:24 -08:00
MelissaCole
af97717044 Subreddit Rules: Remove api documentation 2016-01-25 13:17:24 -08:00
Matt Lee
a63bccc686 SubredditRules: Make report form more consistent with share form. 2016-01-25 13:05:49 -08:00
Matt Lee
9c89e4a1f5 SubredditRules: Force-select the radio input when site reason is selected. 2016-01-25 13:05:49 -08:00
Matt Lee
43a53fc493 SubredditRules: Adjust font sizes. 
Font size for rules is increased.  Fixed tiny font size on delete confirmation
and adjusted color and spacing.
 2016-01-25 13:05:49 -08:00
Matt Lee
188e760646 SubredditRules: Open the new rule form by default on empty pages. 2016-01-25 13:05:49 -08:00
Matt Lee
2ea5f9b653 SubredditRules: Give icons a bigger hitbox. 2016-01-25 13:05:49 -08:00
MelissaCole
2a6fe3dbea Add new report form to /subreddits 2016-01-25 13:00:01 -08:00
MelissaCole
72e4f4657d Subreddit rules: Don't feature flag mod note 2016-01-25 12:59:22 -08:00
umbrae
09b0ed0895 Edit subreddit rules: no ES6 function definitions 
This breaks uglify despite working unminified
 2016-01-25 12:59:14 -08:00
MelissaCole
197caa9850 Fix isinstance check 2016-01-25 12:58:03 -08:00
MelissaCole
2036aced15 Subreddit Rules: Support ReportForm for Messages 
Messages don't have a subreddit so this was failing. Only attempt
to get subreddit rules for comments and links.
 2016-01-25 12:58:03 -08:00
MelissaCole
7fe7068daa Feature flag ban reason 2016-01-25 12:58:03 -08:00
MelissaCole
e0ece48432 Feature flag rules page menu item 2016-01-25 12:58:03 -08:00
MelissaCole
501d53a702 Refactor subreddit rules validators and strip whitespace 2016-01-25 12:58:03 -08:00
Matt Lee
281ec4b0d3 SubredditRules: Fix new rule models being uneditable. 2016-01-25 12:58:03 -08:00
Matt Lee
ccbd55d2af SubredditRules: Style subreddit report form. 2016-01-25 12:58:03 -08:00
Matt Lee
d604704310 SubredditRules: Part 3: Styling the about/rules page. 2016-01-25 12:58:03 -08:00
Matt Lee
98a1ebff4b SubredditRules: Part 2: Markup changes and backbone views. 2016-01-25 12:58:02 -08:00
Matt Lee
7126b39749 SubredditRules: Part 1: Icon assets and styles. 2016-01-25 12:58:02 -08:00
Matt Lee
0132c4edd7 SubredditRules: Fixups to backbone model. 2016-01-25 12:58:02 -08:00
Matt Lee
c46c60778d Add client-side errors for subreddit rules. 2016-01-25 12:58:02 -08:00
Matt Lee
43c06e9308 Frontend: Fixups for errors.js. 2016-01-25 12:58:02 -08:00
Matt Lee
f062de4f0c ModTools: Add base templates for new modtools pages. 
Adds a new js module and css file for mod tools, and a new page that
includes them.  This is so that, moving forward, we don’t have to cram
everything into the reddit.js package.
 2016-01-25 12:58:02 -08:00
Matt Lee
13e47c5a3f SubredditRules: Send rendered markdown in api responses. 
In the create and update endpoints, send the rendered description
markdown in the response. We don’t have client-side markdown rendering,
so this is necessary for the rules page to be fully ajax-y.
 2016-01-25 12:58:02 -08:00
MelissaCole
b2f6347741 Remove reddit rule: other option for subreddit rules 2016-01-25 12:58:02 -08:00
Matt Lee
0b1eb7669c SubredditRules: Add subreddit rule Backbone model. 2016-01-25 12:58:02 -08:00
Matt Lee
dea3f9df9b Frontend: Add errors.js 
A js module for handling api errors and client-side validation errors.
Right now, most of this is done through the jQuery-json response and
through custom code on a per-feature basis.  This module provides a way
to consume API errors that would normally be displayed through the
jQuery-json response handler, as well as a way to define errors on the
client side that display in the same way.
 2016-01-25 12:58:02 -08:00
Matt Lee
f2657f10c2 Frontend: Add ui.TextCounter. 
Provides a method of displaying a count of how many characters a user
can type into an input before hitting the maximum length.
 2016-01-25 12:58:02 -08:00
Matt Lee
4fde89fdc5 SubredditRules: Reduce max number to 10. 2016-01-25 12:58:02 -08:00
Matt Lee
477462a10f SubredditRules: Additional API errors. 
Adds the following errors:

SR_RULE_EXISTS if trying to create a new rule with a short_name that
already exists.
SR_RULE_DOESNT_EXIST if trying to update a rule with a short_name that
does not exist.
SR_RULE_TOO_MANY if trying to create a new rule when the subreddit
already has the max number of rules.
 2016-01-25 12:57:58 -08:00
Matt Lee
9e7d65bf3a Frontend: Add flex-direction mixin. 2016-01-25 12:57:32 -08:00
MelissaCole
f973f7f6b1 Add action-thing class for old report dialog 2016-01-25 12:57:32 -08:00
MelissaCole
2ccf011943 Subreddit rules: Fix other_reason input in report dialog 
The `other_reason` input needs to be enabled properly since
`.report-action-form` isn't being used in the report dialog anymore.
 2016-01-25 12:57:32 -08:00
MelissaCole
0c7b0af668 Feature flag new report dialog style 2016-01-25 12:57:32 -08:00
MelissaCole
7aa352a8cd Subreddit rules: feature flag 2016-01-25 12:57:32 -08:00
MelissaCole
8b3fbc996c Update sitewide rules to reflect content policy 2016-01-25 12:57:32 -08:00
MelissaCole
4214856a0d Make all rules available through API 
Subreddit rules and site rules can be rendered in json.
 2016-01-25 12:57:31 -08:00
MelissaCole
ec9dc5927a Modify report form to support subreddit rules 
Instead of preloading the report dialog, this will request it
when the report button is clicked so that the rules for that
subreddit are populated in the form.
 2016-01-25 12:57:31 -08:00