ID is used elsewhere to mean the raw numerical ID (usually represented
in decimal) rather than the fullname which includes the type ID and is
in base36.
This is to work around Alien Blue crashing when it encounters a `null`
in the author property. We'll revert this after a grace period for
Alien Blue and any other affected apps to be updated.
This new DenormalizedRelation tracks when a user is the author of a
comment in the given thread. Once it's backfilled, we can use it to
quickly determine eligibility for the CommentPane cache.
check-code now handles 3 main use cases:
check-code report: Generate a report of pep8, pep257, and pyflakes problems
check-code regression: Diff said report from current ref to the upstream git ref
check-code junit: Create a junit report of all problems in the current git ref
Additionally:
* You can specify which files to check (check-code junit r2/r2/models/link.py)
* You can send output to a file (check-code -O junit.xml junit)
This system is only used when stylesheets are not hosted on S3. The new
system saves a completely unnecessary C* lookup and ditches one more
thing from the permacache.
There're several benefits to using the type=url format for the link url
field, including a more context-useful keyboard on some mobile devices
and browser-side validation of URLs before even sending a request to us.
This should save us from the ugly "tried to submit %s but couldn't
parse" warnings coming from people pasting imgur bbcode etc. into the
field.
This fixes issue #423. morecomments already returns parent_ids, but the
.json version does not. Without parent_id, you cannot know at what
depth the "load more comments…" links should go
This rule was added to ensure that links being returned had at least an
sr_id data attribute. This prevented an issue where replication lag on
Postgres would cause half-baked objects to be returned by queries on the
slave and then loaded in that bizarro state into Memcached breaking them
for a long time.
Now that we are using proper transactions around Thing._commit, this is
no longer necessary and we can shed it for sanity and speed.