Commit Graph

2215 Commits

Author SHA1 Message Date
Neil Williams
efa3bb4009 Add migration script for regenerating CommentParticipationByAccount CF. 2012-12-04 11:41:24 -08:00
Neil Williams
68291521b5 Move query_cache scripts to a more general "migrate" directory.
Not just for the query cache anymore!
2012-12-04 11:41:24 -08:00
Neil Williams
925c9ccc68 /dev/api: Fully document the "links and comments" section. 2012-12-04 10:29:21 -08:00
Neil Williams
9f5740e3ff /dev/api: Use "fullname" instead of "id" where appropriate.
ID is used elsewhere to mean the raw numerical ID (usually represented
in decimal) rather than the fullname which includes the type ID and is
in base36.
2012-12-04 10:29:21 -08:00
Neil Williams
01a67579a8 /dev/api: Improve semantics of param markup and tweaks styles.
The style changes should make it easier to match param names to
descriptions, especially with multi-line descriptions.
2012-12-04 10:29:21 -08:00
Neil Williams
e99a34c36b /dev/api: Remove translation markers from param docs.
The docstrings are untranslated so it is inconsistent to mark the
params for translation.
2012-12-04 10:29:21 -08:00
Max Goodman
d566d91d84 Temporarily use "[deleted]" in JSON for deleted usernames.
This is to work around Alien Blue crashing when it encounters a `null`
in the author property. We'll revert this after a grace period for
Alien Blue and any other affected apps to be updated.
2012-12-03 18:05:21 -08:00
Neil Williams
4e620f96b5 Start writing comment participation by thread.
This new DenormalizedRelation tracks when a user is the author of a
comment in the given thread.  Once it's backfilled, we can use it to
quickly determine eligibility for the CommentPane cache.
2012-12-03 15:33:44 -08:00
Neil Williams
3a5eabc7cc JSON: Fix deleted account names being leaked. 2012-12-03 15:33:44 -08:00
Keith Mitchell
faa59a2b4c check-code: Rework check-code for other use cases
check-code now handles 3 main use cases:

check-code report: Generate a report of pep8, pep257, and pyflakes problems
check-code regression: Diff said report from current ref to the upstream git ref
check-code junit: Create a junit report of all problems in the current git ref

Additionally:
* You can specify which files to check (check-code junit r2/r2/models/link.py)
* You can send output to a file (check-code -O junit.xml junit)
2012-12-03 14:21:59 -08:00
Neil Williams
2dea71ad1c Subreddit CSS: Dump permacache-based last modified system.
This system is only used when stylesheets are not hosted on S3. The new
system saves a completely unnecessary C* lookup and ditches one more
thing from the permacache.
2012-12-03 12:00:28 -08:00
Neil Williams
9188eb5c2d Refactor reddit_base.check_modified to not use last_modified.
This gives us greater flexibility to use a date from any source, rather
than just the permacache-based last modified system.
2012-12-03 12:00:28 -08:00
Roger Ostrander
dcc97b6749 No longer clogging up logs with 500 errors 2012-12-03 12:00:27 -08:00
bsimpson63
d63fba2d59 Add multireddit for /r/mod. 2012-12-03 14:22:11 -05:00
bsimpson63
257ea95142 Cleanup SubscriptionBox. 2012-12-03 14:22:11 -05:00
bsimpson63
9e3a2fd316 Detach campaign the cool way. 2012-12-03 14:22:11 -05:00
bsimpson63
44c3589758 Rename button edit to save when editing campaign. 2012-12-03 14:22:05 -05:00
Neil Williams
a7d3f3b612 traffic: minor housekeeping and more docstrings. 2012-12-03 10:58:38 -08:00
Ricky Ramirez
603ec0e049 wiki: Fix bug with wiki permissions. 2012-12-03 10:58:26 -08:00
Neil Williams
24aeadea19 Disable last visit processing on GET_info as well. 2012-12-03 10:49:50 -08:00
Neil Williams
a7cad5dac5 Don't do last visit stuff on POSTs.
It isn't really necessary to do it on every POST_vote, POST_hide etc.
2012-12-03 10:49:50 -08:00
Neil Williams
db7e5e9ac6 Temporarily break imgur.com domain listings for the greater good.
Turns out, this is the entire cause of current permacache lock
contention causing vote processing slowdowns.
2012-12-01 22:26:06 -08:00
Neil Williams
f8c264a7de Add client side validation attributes to submit page form elements.
There're several benefits to using the type=url format for the link url
field, including a more context-useful keyboard on some mobile devices
and browser-side validation of URLs before even sending a request to us.

This should save us from the ugly "tried to submit %s but couldn't
parse" warnings coming from people pasting imgur bbcode etc. into the
field.
2012-11-29 15:16:24 -08:00
Max Goodman
815e8563df gilding: Document the gildComment / thingupdater interaction. 2012-11-29 15:16:21 -08:00
Max Goodman
763e824a48 gilding: Fix bug where thingupdater counts were incremented.
The value supplied by the inlined thingupdater data is the current
count and should not be incremented by gildComment.
2012-11-29 15:16:21 -08:00
Max Goodman
e537c3e247 jsonp: Constrain acceptable callback values. 2012-11-29 15:16:21 -08:00
Max Goodman
fd74634669 buttons: Add simple sr name validation. 2012-11-29 15:16:21 -08:00
Logan Hanks
43e29007b2 Update example.ini to enable only comment tree v1. 2012-11-20 14:17:25 -08:00
Neil Williams
f2894776db tdb_sql: Up the number of frames in traceback.
tdb_sql has a lot of functions. Seven frames was frequently insufficient
to see who was phone.
2012-11-20 14:09:38 -08:00
Neil Williams
f0310bc0af amqp: Reduce number of messages sent down to consumers preemptively. 2012-11-20 14:09:38 -08:00
Steve Wilber
3a6db1d1e3 add parent_id to "more" things returned from morecomments.json
This fixes issue #423. morecomments already returns parent_ids, but the
.json version does not. Without parent_id, you cannot know at what
depth the "load more comments…" links should go
2012-11-20 13:36:23 -08:00
Neil Williams
bdad9c4635 stats: Condense all vote_link_q shard stats into one stats key. 2012-11-20 13:36:23 -08:00
Andre D
4a48331422 listing: Deleted users should not appear on user listings. 2012-11-20 11:47:32 -08:00
Robert Picard
2a0c595658 Capitalize "I" on the preferences page
Right now it's capitalized sometimes, and lowercased others. After a little
chat in #reddit-dev, it was agreed that it makes sense to capitalize it.
2012-11-20 11:47:32 -08:00
nekosune
117526abe3 Added Error to Stylesheet API on invalid CSS 2012-11-20 11:47:32 -08:00
DEADB33F
82ed3c9a02 Added is_friend to user account JSON response. 2012-11-20 11:47:32 -08:00
Neil Williams
a492f0ac91 AllSR: Remove obviated sr_id > 0 rule.
This rule was added to ensure that links being returned had at least an
sr_id data attribute.  This prevented an issue where replication lag on
Postgres would cause half-baked objects to be returned by queries on the
slave and then loaded in that bizarro state into Memcached breaking them
for a long time.

Now that we are using proper transactions around Thing._commit, this is
no longer necessary and we can shed it for sanity and speed.
2012-11-20 11:47:32 -08:00
Neil Williams
1e4c8bd37f AllSR: minor cleanup in get_links. 2012-11-20 11:47:32 -08:00
Neil Williams
18a0aee2d8 Synchronize mis-merges from production branch. 2012-11-19 19:05:33 -08:00
bsimpson63
f96478b743 Remove unused argument in decrement_month. 2012-11-19 19:05:33 -08:00
bsimpson63
f0ccf5ae27 Truncate promotion_history to most recent 31 days. 2012-11-19 19:05:33 -08:00
bsimpson63
157362fa6b Specify dates we want in traffic queries. 2012-11-19 19:05:33 -08:00
bsimpson63
fee89d18af Use an autocommit Session for traffic. 2012-11-19 19:05:33 -08:00
shlurbee
c0229834c7 Move to_date() function from bidding to utils 2012-11-19 19:05:32 -08:00
Roger Ostrander
cf8ca9a228 Remove extraneous reports. 2012-11-19 19:04:54 -08:00
Neil Williams
722c5a069c Cassandra: Increase timeout.
The cassandra ring is in a different AZ right now, so we need to
increase the timeout.
2012-11-19 19:04:54 -08:00
shlurbee
f17ba944d6 Change admin_override to sponsor_override since that's what the validator is actually checking 2012-11-19 19:04:54 -08:00
Logan Hanks
92bac3f77c Serve public description (not sidebar) in rss description. 2012-11-19 19:04:54 -08:00
Logan Hanks
2eb24e46ce Don't use account._spam to determine access token validity. 2012-11-19 19:04:54 -08:00
Roger Ostrander
65b146772b Backend support for bans. 2012-11-19 19:04:46 -08:00